From: Timur Tabi <timur@codeaurora.org>
To: Jiandi An <anjiandi@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] [v3] pinctrl: qcom: disable GPIO groups with no pins
Date: Wed, 16 Aug 2017 13:32:44 -0500 [thread overview]
Message-ID: <66bfbee6-245d-fddb-f6cb-a2c3c06ffc9b@codeaurora.org> (raw)
In-Reply-To: <7c278367-bf3b-6a26-e31f-ee696cb5534e@codeaurora.org>
On 08/16/2017 01:10 PM, Jiandi An wrote:
>
> Technically the same check added in msm_gpio_irq_mask() and
> msm_gpio_irq_unmask() should be added in msm_gpio_irq_ack(),
> msm_gpio_irq_set_type(), and msm_gpio_irq_set_wake() if it's registered
> with irq domain.
I assume that if the GPIO is never unmasked, then msm_gpio_irq_ack()
will never be called.
msm_gpio_irq_set_type() and msm_gpio_irq_set_wake() might be called, so
I can add checks for those functions. I'm hoping that won't be
necessary, however. The GPIO and IRQ code is too entangled for me to
figure out whether unclaimed GPIOs can still have their interrupts
programmed.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-08-16 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 18:19 [PATCH 0/3][v3] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-07-27 18:19 ` [PATCH 1/3] gliolib: request the gpio before querying its direction Timur Tabi
2017-07-31 13:35 ` Linus Walleij
2017-08-21 21:23 ` Timur Tabi
2017-08-23 8:32 ` Linus Walleij
2017-08-23 23:28 ` Timur Tabi
2017-08-24 21:28 ` Linus Walleij
2017-08-24 22:00 ` Timur Tabi
2017-07-27 18:19 ` [PATCH 2/3] [v3] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-07-31 13:36 ` Linus Walleij
2017-08-09 19:02 ` Timur Tabi
2017-08-16 18:10 ` Jiandi An
2017-08-16 18:32 ` Timur Tabi [this message]
2017-08-16 19:30 ` Jiandi An
2017-08-16 19:31 ` Jiandi An
2017-08-16 19:55 ` Timur Tabi
2017-07-27 18:19 ` [PATCH 3/3] [v2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66bfbee6-245d-fddb-f6cb-a2c3c06ffc9b@codeaurora.org \
--to=timur@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=anjiandi@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).