Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linus.walleij@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Will Deacon <will@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 07/10] arm64: select HAVE_SHARED_GPIOS for ARCH_QCOM
Date: Wed, 7 Jan 2026 16:36:53 +0530	[thread overview]
Message-ID: <66eaf003-c397-4920-b3b7-93ac8a5adfda@oss.qualcomm.com> (raw)
In-Reply-To: <20251112-gpio-shared-v4-7-b51f97b1abd8@linaro.org>

On 11/12/2025 7:25 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Some qualcomm platforms use shared GPIOs. Enable support for them by
> selecting the Kconfig switch provided by GPIOLIB.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  arch/arm64/Kconfig.platforms | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 13173795c43d4f28e2d47acc700f80a165d44671..3dbff0261f0add0516d8cb3fd0f29e277af94f20 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -316,6 +316,7 @@ config ARCH_QCOM
>  	select GPIOLIB
>  	select PINCTRL
>  	select HAVE_PWRCTRL if PCI
> +	select HAVE_SHARED_GPIOS
>  	help
>  	  This enables support for the ARMv8 based Qualcomm chipsets.
>  
>
Enabling shared gpios is breaking hamoa and glymur boot on next-20260106
For hamoa - reg_fixed_voltage_probe which calls gpio api is breaking
Please find the log here - https://lava-oss.qualcomm.com/scheduler/job/24722#L3514

For Glymur - qcom_pcie_parse_perst calls the gpio api <4>[    2.910982] WARNING: drivers/gpio/gpiolib-shared.c:493 at gpio_shared_add_proxy_lookup+0x160/0x24c, CPU#1: kworker/u75:0/109 <4>[    2.911027] Call trace: <4>[    2.911028]  gpio_shared_add_proxy_lookup+0x160/0x24c (P) <4>[    2.911030]  gpiod_find_and_request+0x1c0/0x504 <4>[    2.911032]  devm_fwnode_gpiod_get_index+0x1c/0x6c <4>[    2.911034]  qcom_pcie_parse_perst+0x70/0x150 <4>[    2.911037]  qcom_pcie_probe+0x414/0x804 <4>[    2.911039]  platform_probe+0x5c/0x98 <4>[    2.911042] qcom-eusb2-repeater c448000.spmi:pmic@9:phy@fd00: supply vdd18 not found, using dummy regulator <4>[    2.911043]  really_probe+0xbc/0x298 <4>[    2.911045]  __driver_probe_device+0x78/0x12c <4>[    2.911047]  driver_probe_device+0x3c/0x15c <4>[    2.911049]  __device_attach_driver+0xb8/0x134 <4>[    2.911050]  bus_for_each_drv+0x84/0xe0 <4>[    2.911052]  __device_attach_async_helper+0xac/0xd0 <4>[    2.911053]  async_run_entry_fn+0x34/0xe0
<4>[    2.911055]  process_one_work+0x14c/0x28c <4>[    2.911058]  worker_thread+0x188/0x304 <4>[    2.911059]  kthread+0x11c/0x128 <4>[    2.911060] qcom-eusb2-repeater c448000.spmi:pmic@9:phy@fd00: supply vdd3 not found, using dummy regulator <4>[    2.911061]  ret_from_fork+0x10/0x20 <4>[    2.911063] ---[ end trace 0000000000000000 ]--- <3>[    2.911065] qcom-pcie 1b40000.pci: error -ENOENT: Failed to parse Root Port: -2 <3>[    2.911069] qcom-pcie 1b40000.pci: probe with driver qcom-pcie failed with error -2
Reverting this commit fixes the boot on both platforms


  parent reply	other threads:[~2026-01-07 11:07 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 13:55 [PATCH v4 00/10] gpio: improve support for shared GPIOs Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 01/10] string: provide strends() Bartosz Golaszewski
2025-11-17 20:33   ` Kees Cook
2025-11-18  9:47     ` Bartosz Golaszewski
2025-11-18 10:13       ` Andy Shevchenko
2025-11-12 13:55 ` [PATCH v4 02/10] gpiolib: define GPIOD_FLAG_SHARED Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 03/10] gpiolib: implement low-level, shared GPIO support Bartosz Golaszewski
2025-11-26 15:34   ` Cosmin Tanislav
2025-11-26 15:47     ` Bartosz Golaszewski
2026-03-11 18:38   ` Jon Hunter
2026-03-11 20:14     ` Andy Shevchenko
2026-03-12  7:28       ` Jon Hunter
2026-03-12  7:49         ` Chen-Yu Tsai
2026-03-12  8:41           ` Jon Hunter
2026-03-12  9:28             ` Andy Shevchenko
2026-03-13 14:18           ` Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 04/10] gpio: shared-proxy: implement the shared GPIO proxy driver Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 05/10] gpiolib: support shared GPIOs in core subsystem code Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 06/10] gpio: provide gpiod_is_shared() Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 07/10] arm64: select HAVE_SHARED_GPIOS for ARCH_QCOM Bartosz Golaszewski
2025-11-13  8:51   ` Arnd Bergmann
2025-11-14 19:40   ` Bjorn Andersson
2025-11-18 14:06   ` Mark Brown
2025-11-18 14:13     ` Bartosz Golaszewski
2025-11-18 14:20       ` Mark Brown
2025-11-18 14:27         ` Bartosz Golaszewski
2025-11-18 19:46           ` Mark Brown
2025-11-26 14:24   ` Jon Hunter
2025-11-26 14:28     ` Bartosz Golaszewski
2025-11-26 14:51       ` Jon Hunter
2025-11-26 14:54         ` Bartosz Golaszewski
2025-11-26 14:55           ` Jon Hunter
2025-11-26 15:05             ` Bartosz Golaszewski
2025-11-26 15:29           ` Jon Hunter
2025-11-26 15:33             ` Bartosz Golaszewski
2025-11-26 15:47               ` Jon Hunter
2025-11-26 16:00                 ` Bartosz Golaszewski
2026-01-07 11:06   ` Pankaj Patil [this message]
2026-01-07 12:38     ` Bartosz Golaszewski
2026-01-08  6:49       ` Pankaj Patil
2026-01-08  8:45         ` Bartosz Golaszewski
2026-01-08  9:43           ` Pankaj Patil
2026-01-08 10:52             ` Bartosz Golaszewski
2026-01-08 14:37             ` Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 08/10] ASoC: wsa881x: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE flag from GPIO lookup Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 09/10] ASoC: wsa883x: " Bartosz Golaszewski
2025-11-12 13:55 ` [PATCH v4 10/10] regulator: make the subsystem aware of shared GPIOs Bartosz Golaszewski
2025-11-17  9:20 ` (subset) [PATCH v4 00/10] gpio: improve support for " Bartosz Golaszewski
2025-11-18 11:15 ` Geert Uytterhoeven
2025-11-18 11:55   ` Bartosz Golaszewski
2025-11-18 12:55     ` Geert Uytterhoeven
2025-11-18 13:21       ` Bartosz Golaszewski
2025-11-18 23:23   ` Linus Walleij
2025-11-19  8:01     ` Andy Shevchenko
2025-11-19  8:33     ` Geert Uytterhoeven
2025-11-19 14:29       ` Linus Walleij
2025-11-20 10:39 ` (subset) " Mark Brown
2025-11-20 13:36 ` Mark Brown
2025-11-21  0:27 ` Val Packett
2025-11-21  9:03   ` Bartosz Golaszewski
2025-11-21 10:20     ` Krzysztof Kozlowski
2025-11-26 16:27 ` Dmitry Baryshkov
2025-11-26 16:49   ` Bartosz Golaszewski
2026-01-07 11:47   ` Manivannan Sadhasivam
2026-01-07 12:12     ` Dmitry Baryshkov
2026-01-07 12:23       ` Manivannan Sadhasivam
2026-01-08 14:46 ` Michael Walle
2026-01-08 15:50   ` Bartosz Golaszewski
2026-01-09 14:41     ` Michael Walle
2026-01-09 14:50       ` Bartosz Golaszewski
2026-01-09 15:08         ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66eaf003-c397-4920-b3b7-93ac8a5adfda@oss.qualcomm.com \
    --to=pankaj.patil@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox