From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeykumar Sankaran <jsanka@codeaurora.org>
Subject: Re: [PATCH] drm/msm/dpu: Don't use devm for component devices
Date: Fri, 02 Nov 2018 10:57:46 -0700
Message-ID: <66f6f2363e24a4a9780df8bb5dbc8666@codeaurora.org>
References: <20181102143008.8288-1-jcrouse@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20181102143008.8288-1-jcrouse@codeaurora.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: dri-devel <dri-devel-bounces@lists.freedesktop.org>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, jshekhar@codeaurora.org, seanpaul@chromium.org, abhinavk@codeaurora.org, freedreno@lists.freedesktop.org
List-Id: linux-arm-msm@vger.kernel.org

T24gMjAxOC0xMS0wMiAwNzozMCwgSm9yZGFuIENyb3VzZSB3cm90ZToKPiBEZXZpY2VzIHRoYXQg
YXJlIGJvdW5kIGFzIGNvbXBvbmVudHMgc2hvdWxkIG5vdCB1c2UgZGV2bSBzaW5jZQo+IGRldmlj
ZSBtYW5hZ2VkIG1lbW9yeSBpcyBub3QgZnJlZWQgd2hlbiB0aGUgY29tcG9uZW50IGlzCj4gdW5i
b3VuZC4KPiAKPiBJbiBwYXJ0aWN1bGFyIHRoaXMgaXMgYW4gaXNzdWUgaWYgdGhlIGNvbXBvbmVu
dCBiaW5kIGZhaWxzCj4gZHVlIHRvIGFuIC1FUFJPQkVfREVGRVIuIEluIHRoaXMgY2FzZSB0aGUg
YmluZCB3b3VsZCB0cnkgYWdhaW4KCklzbid0IHRoaXMgdGhlIG9ubHkgY2FzZSB3aGVyZSB1c2lu
ZyBkZXZtIHdvdWxkIGJlIGEgcHJvYmxlbT8gRXZlbiBpbiAKdGhpcyBjYXNlCmRvIHlvdSBleHBl
Y3QgYW55IGxlYWtzIGlmIGRldm1fa2ZyZWUgaXMgY2FsbGVkIGJlZm9yZSBERUZFUmluZyBkdWUg
dG8gCmVycm9ycwphbmQgaW4gdW5ib3VuZHM/CgpUaGFua3MsCkpleWt1bWFyIFMuCj4gbGF0ZXIg
YW5kIGFueSBkZXZtIG1hbmFnZWQgbWVtb3J5IGFsbG9jYXRlZCBkdXJpbmcgdGhlIGZvcm1lcgo+
IGFib3J0ZWQgYXR0ZW1wdCB3b3VsZCBiZSBsZWFrZWQgdW50aWwgdGhlIGRldmljZSBpdHNlbGYg
d2FzCj4gZGVzdHJveWVkLiBTaW5jZSBhbGwgdGhlIG1lbW9yeSBhbGxvY2F0ZWQgZHVyaW5nIGEg
YmluZAo+IHNob3VsZCBiZSBmcmVlZCBkdXJpbmcgYW4gdW5iaW5kIChvciBiaW5kIGVycm9yIGNh
c2UpIHRoZXJlIGlzbid0Cj4gYW55IHJlYXNvbiB0byB1c2UgZGV2bSBmb3IgcmVzb3VyY2VzIHRo
YXQgaGF2ZSBhIGV4cGxpY2l0Cj4gdGVhcmRvd24gc3RlcC4KPiAKPiBUaGlzIGRvZXNuJ3QgcmVt
b3ZlIGRldm0gZm9yIGFsbCByZXNvdXJjZXMgLSBpbiBwYXJ0aWN1bGFyCj4gbXNtX2lvcmVtYXAo
KSBzdGlsbCB1c2VzIGRldm1faW9yZW1hcCgpIGJ1dCB0aGF0cyBhIGdlbmVyaWMKPiBpc3N1ZSB0
aGF0IGNhbiBlYXNpbHkgYmUgYWRkcmVzc2VkIGFzIGEgY2xlYW51cCBsYXRlciBhbmQgdGhlCj4g
dW5iaW5kIGNvZGUgYWxyZWFkeSBkb2VzIHRoZSByZXF1aXNpdGUgZGV2bSBjYWxscyB0byB1bm1h
cCBpdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKb3JkYW4gQ3JvdXNlIDxqY3JvdXNlQGNvZGVhdXJv
cmEub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rl
ci5jIHwgIDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfaW9fdXRp
bC5jIHwgIDQgKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMg
ICAgIHwgMTAgKysrKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf
bWRzcy5jICAgIHwgIDggKysrKystLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z
KCspLCAxMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21z
bS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw
dTEvZHB1X2VuY29kZXIuYwo+IGluZGV4IDgyYzU1ZWZiNTAwZi4uMjg3ZDRjM2U1OGMzIDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gQEAgLTIy
MjAsMTQgKzIyMjAsMTQgQEAgc3RydWN0IGRybV9lbmNvZGVyICpkcHVfZW5jb2Rlcl9pbml0KHN0
cnVjdAo+IGRybV9kZXZpY2UgKmRldiwKPiAgCXN0cnVjdCBkcHVfZW5jb2Rlcl92aXJ0ICpkcHVf
ZW5jID0gTlVMTDsKPiAgCWludCByYyA9IDA7Cj4gCj4gLQlkcHVfZW5jID0gZGV2bV9remFsbG9j
KGRldi0+ZGV2LCBzaXplb2YoKmRwdV9lbmMpLCBHRlBfS0VSTkVMKTsKPiArCWRwdV9lbmMgPSBr
emFsbG9jKHNpemVvZigqZHB1X2VuYyksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFkcHVfZW5jKQo+
ICAJCXJldHVybiBFUlJfUFRSKEVOT01FTSk7Cj4gCj4gIAlyYyA9IGRybV9lbmNvZGVyX2luaXQo
ZGV2LCAmZHB1X2VuYy0+YmFzZSwgJmRwdV9lbmNvZGVyX2Z1bmNzLAo+ICAJCQlkcm1fZW5jX21v
ZGUsIE5VTEwpOwo+ICAJaWYgKHJjKSB7Cj4gLQkJZGV2bV9rZnJlZShkZXYtPmRldiwgZHB1X2Vu
Yyk7Cj4gKwkJa2ZyZWUoZHB1X2VuYyk7Cj4gIAkJcmV0dXJuIEVSUl9QVFIocmMpOwo+ICAJfQo+
IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfaW9fdXRp
bC5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfaW9fdXRpbC5jCj4gaW5k
ZXggODllZTRiMzZiZWZmLi45MGI1M2U5NTA4ZjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL21zbS9kaXNwL2RwdTEvZHB1X2lvX3V0aWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9t
c20vZGlzcC9kcHUxL2RwdV9pb191dGlsLmMKPiBAQCAtMTU1LDkgKzE1NSw3IEBAIGludCBtc21f
ZHNzX3BhcnNlX2Nsb2NrKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgCj4gKnBkZXYsCj4gIAkJcmV0
dXJuIDA7Cj4gIAl9Cj4gCj4gLQltcC0+Y2xrX2NvbmZpZyA9IGRldm1fa3phbGxvYygmcGRldi0+
ZGV2LAo+IC0JCQkJICAgICAgc2l6ZW9mKHN0cnVjdCBkc3NfY2xrKSAqIG51bV9jbGssCj4gLQkJ
CQkgICAgICBHRlBfS0VSTkVMKTsKPiArCW1wLT5jbGtfY29uZmlnID0ga2NhbGxvYyhudW1fY2xr
LCBzaXplb2Yoc3RydWN0IGRzc19jbGspLCAKPiBHRlBfS0VSTkVMKTsKPiAgCWlmICghbXAtPmNs
a19jb25maWcpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9k
aXNwL2RwdTEvZHB1X2ttcy5jCj4gaW5kZXggOTg1Yzg1NTc5NmFlLi41YWMzYzNmM2IwOGQgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gQEAgLTEwODYsMTMg
KzEwODYsMTQgQEAgc3RhdGljIGludCBkcHVfYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVj
dAo+IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+ICAJc3RydWN0IGRzc19tb2R1bGVfcG93
ZXIgKm1wOwo+ICAJaW50IHJldCA9IDA7Cj4gCj4gLQlkcHVfa21zID0gZGV2bV9remFsbG9jKCZw
ZGV2LT5kZXYsIHNpemVvZigqZHB1X2ttcyksIEdGUF9LRVJORUwpOwo+ICsJZHB1X2ttcyA9IGt6
YWxsb2Moc2l6ZW9mKCpkcHVfa21zKSwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIWRwdV9rbXMpCj4g
IAkJcmV0dXJuIC1FTk9NRU07Cj4gCj4gIAltcCA9ICZkcHVfa21zLT5tcDsKPiAgCXJldCA9IG1z
bV9kc3NfcGFyc2VfY2xvY2socGRldiwgbXApOwo+ICAJaWYgKHJldCkgewo+ICsJCWtmcmVlKGRw
dV9rbXMpOwo+ICAJCURQVV9FUlJPUigiZmFpbGVkIHRvIHBhcnNlIGNsb2NrcywgcmV0PSVkXG4i
LCByZXQpOwo+ICAJCXJldHVybiByZXQ7Cj4gIAl9Cj4gQEAgLTExMDksNyArMTExMCw3IEBAIHN0
YXRpYyBpbnQgZHB1X2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgCj4gZGV2aWNlCj4g
Km1hc3Rlciwgdm9pZCAqZGF0YSkKPiAgCWRwdV9rbXMtPnJwbV9lbmFibGVkID0gdHJ1ZTsKPiAK
PiAgCXByaXYtPmttcyA9ICZkcHVfa21zLT5iYXNlOwo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVy
biAwOwo+ICB9Cj4gCj4gIHN0YXRpYyB2b2lkIGRwdV91bmJpbmQoc3RydWN0IGRldmljZSAqZGV2
LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQKPiAqZGF0YSkKPiBAQCAtMTEyMCwxMSArMTEy
MSwxMiBAQCBzdGF0aWMgdm9pZCBkcHVfdW5iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgCj4gc3Ry
dWN0Cj4gZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gCj4gIAlkcHVfcG93ZXJfcmVzb3Vy
Y2VfZGVpbml0KHBkZXYsICZkcHVfa21zLT5waGFuZGxlKTsKPiAgCW1zbV9kc3NfcHV0X2Nsayht
cC0+Y2xrX2NvbmZpZywgbXAtPm51bV9jbGspOwo+IC0JZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBt
cC0+Y2xrX2NvbmZpZyk7Cj4gLQltcC0+bnVtX2NsayA9IDA7Cj4gKwlrZnJlZShtcC0+Y2xrX2Nv
bmZpZyk7Cj4gCj4gIAlpZiAoZHB1X2ttcy0+cnBtX2VuYWJsZWQpCj4gIAkJcG1fcnVudGltZV9k
aXNhYmxlKCZwZGV2LT5kZXYpOwo+ICsKPiArCWtmcmVlKGRwdV9rbXMpOwo+ICB9Cj4gCj4gIHN0
YXRpYyBjb25zdCBzdHJ1Y3QgY29tcG9uZW50X29wcyBkcHVfb3BzID0gewo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gYi9kcml2ZXJzL2dw
dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gaW5kZXggMjIzNWVmODEyOWY0Li4zNGFi
NDg5YjFhNWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1
X21kc3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9tZHNzLmMK
PiBAQCAtMTYxLDcgKzE2MSw3IEBAIHN0YXRpYyB2b2lkIGRwdV9tZHNzX2Rlc3Ryb3koc3RydWN0
IGRybV9kZXZpY2UgCj4gKmRldikKPiAgCWZyZWVfaXJxKHBsYXRmb3JtX2dldF9pcnEocGRldiwg
MCksIGRwdV9tZHNzKTsKPiAKPiAgCW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2NvbmZpZywgbXAt
Pm51bV9jbGspOwo+IC0JZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4g
KwlrZnJlZShtcC0+Y2xrX2NvbmZpZyk7Cj4gCj4gIAlpZiAoZHB1X21kc3MtPm1taW8pCj4gIAkJ
ZGV2bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRwdV9tZHNzLT5tbWlvKTsKPiBAQCAtMTY5LDYgKzE2
OSw4IEBAIHN0YXRpYyB2b2lkIGRwdV9tZHNzX2Rlc3Ryb3koc3RydWN0IGRybV9kZXZpY2UgCj4g
KmRldikKPiAKPiAgCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYtPmRldik7Cj4gIAlwcml2LT5tZHNz
ID0gTlVMTDsKPiArCj4gKwlrZnJlZShkcHVfbWRzcyk7Cj4gIH0KPiAKPiAgc3RhdGljIGNvbnN0
IHN0cnVjdCBtc21fbWRzc19mdW5jcyBtZHNzX2Z1bmNzID0gewo+IEBAIC0xODYsNyArMTg4LDcg
QEAgaW50IGRwdV9tZHNzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCXN0cnVjdCBk
c3NfbW9kdWxlX3Bvd2VyICptcDsKPiAgCWludCByZXQgPSAwOwo+IAo+IC0JZHB1X21kc3MgPSBk
ZXZtX2t6YWxsb2MoZGV2LT5kZXYsIHNpemVvZigqZHB1X21kc3MpLCBHRlBfS0VSTkVMKTsKPiAr
CWRwdV9tZHNzID0ga3phbGxvYyhzaXplb2YoKmRwdV9tZHNzKSwgR0ZQX0tFUk5FTCk7Cj4gIAlp
ZiAoIWRwdV9tZHNzKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+IAo+IEBAIC0yMzksNyArMjQxLDcg
QEAgaW50IGRwdV9tZHNzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgaXJxX2RvbWFp
bl9lcnJvcjoKPiAgCW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2NvbmZpZywgbXAtPm51bV9jbGsp
Owo+ICBjbGtfcGFyc2VfZXJyOgo+IC0JZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2Nv
bmZpZyk7Cj4gKwlrZnJlZShtcC0+Y2xrX2NvbmZpZyk7Cj4gIAlpZiAoZHB1X21kc3MtPm1taW8p
Cj4gIAkJZGV2bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRwdV9tZHNzLT5tbWlvKTsKPiAgCWRwdV9t
ZHNzLT5tbWlvID0gTlVMTDsKCi0tIApKZXlrdW1hciBTCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=