From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA2AC5479D for ; Mon, 9 Jan 2023 13:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbjAINrM (ORCPT ); Mon, 9 Jan 2023 08:47:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236470AbjAINqr (ORCPT ); Mon, 9 Jan 2023 08:46:47 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CE2F1C417 for ; Mon, 9 Jan 2023 05:46:45 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id v25so12991634lfe.12 for ; Mon, 09 Jan 2023 05:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2dzpj24jf9RpxQI+H6xrFSNuIAG8zDeKNesu/MCzMfw=; b=xmIFSOgvwxaDKhy/YRLTuYHZJjqDxUm9lLVy2xHGKt279HjsQlsko0bEOhRKeKkSe8 94tMNE2V/3/EG11YMMYw12PWzyefvGLLpUrquT6nJZC/b0vJrrps04dLDML5VIz8DYEk FS4PG8UT3oR3cRRc5G+uhz/cy42PHXDwQuw2JoXGOo0yEyaMtMdrer+x67BLnwR5yOmk dPAW/AyqFrylvBxwLwZ/uEZOuvFRjSygf7ccNG5e7cA5wIerKVHvxpYmIqCqG+AE0sd2 wJuPnlwlizAUOptwd1NBk8hKmDoVPXBE1k7M/2Xsvw4PmcSMJZT7O7q6dOQRyJnDesxD DS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2dzpj24jf9RpxQI+H6xrFSNuIAG8zDeKNesu/MCzMfw=; b=R5a4/wppB0krZDxy39UAC12yQDwrtFgroQT79jG1ShqpA6O6MBdGm9pIp5RkNKtRsw fWJLrgDvK+p5ckaV7Sxp9MUtn7y8cT4XLiqUu4iq88hmPo3lVGhfxHmRbptkWX4tXF3Y W2EtsRiv0amZ530LGeek2RiMw1qf+fGqAHACMEFeeb9XCYROyy6zJ/WWitczQa17dDIo YQeOOB/rJe7Qzi3YgH46p/mSw9foAmXggbWDpapJTxFuwhjxBRNLU4zVzsSDbSeeC9F8 sjMqg/DsGibn47ptBeMPmTVk8YERUTwrm4uPrcdJHTJNjV2Qvxqxxi3M/PvETi6nU7dq TM1g== X-Gm-Message-State: AFqh2kq9VmBPAMishwAmG3z1MO7oArskXpzj3/eUDfsxACyZXeZOOhfX af/bmJ8tcI4Sj+z1fHYnbKypTg== X-Google-Smtp-Source: AMrXdXu6zIH4kW1H+zgM63Od3vPsNJ62ovOvF89bNmcEmjTfsX4upG6Ss2WSbs0mSHnhSxwQbIz25Q== X-Received: by 2002:a05:6512:3e10:b0:4b5:c489:8cf8 with SMTP id i16-20020a0565123e1000b004b5c4898cf8mr20337420lfv.61.1673272003480; Mon, 09 Jan 2023 05:46:43 -0800 (PST) Received: from [192.168.1.101] (abxi45.neoplus.adsl.tpnet.pl. [83.9.2.45]) by smtp.gmail.com with ESMTPSA id z3-20020a0565120c0300b004cb03999979sm1631168lfu.40.2023.01.09.05.46.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 05:46:43 -0800 (PST) Message-ID: <672320ab-f899-01dd-0f39-3edaf3a04e79@linaro.org> Date: Mon, 9 Jan 2023 14:46:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 06/12] interconnect: qcom: sc8180x: Drop IP0 interconnects Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: Georgi Djakov , Alex Elder , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20230109002935.244320-1-dmitry.baryshkov@linaro.org> <20230109002935.244320-7-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20230109002935.244320-7-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9.01.2023 01:29, Dmitry Baryshkov wrote: > Similar to the sdx55 and sc7180, let's drop the MASTER_IPA_CORE and > SLAVE_IPA_CORE interconnects for this platofm. platform There are no actual users > of this intercoonect. interconnect The IP0 resource will be handled by clk-rpmh > driver. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/core.c | 1 + > drivers/interconnect/qcom/sc8180x.c | 38 ----------------------------- > drivers/interconnect/qcom/sc8180x.h | 4 +-- > 3 files changed, 3 insertions(+), 40 deletions(-) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 5b5fd436f23f..0f392f59b135 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -1081,6 +1081,7 @@ EXPORT_SYMBOL_GPL(icc_provider_del); > > static const struct of_device_id __maybe_unused ignore_list[] = { > { .compatible = "qcom,sc7180-ipa-virt" }, > + { .compatible = "qcom,sc8180x-ipa-virt" }, > { .compatible = "qcom,sdx55-ipa-virt" }, > { .compatible = "qcom,sm8150-ipa-virt" }, > { .compatible = "qcom,sm8250-ipa-virt" }, > diff --git a/drivers/interconnect/qcom/sc8180x.c b/drivers/interconnect/qcom/sc8180x.c > index 0f515bf10bd7..c76e3a6a98cd 100644 > --- a/drivers/interconnect/qcom/sc8180x.c > +++ b/drivers/interconnect/qcom/sc8180x.c > @@ -469,15 +469,6 @@ static struct qcom_icc_node mas_qxm_ecc = { > .links = { SC8180X_SLAVE_LLCC } > }; > > -static struct qcom_icc_node mas_ipa_core_master = { > - .name = "mas_ipa_core_master", > - .id = SC8180X_MASTER_IPA_CORE, > - .channels = 1, > - .buswidth = 8, > - .num_links = 1, > - .links = { SC8180X_SLAVE_IPA_CORE } > -}; > - > static struct qcom_icc_node mas_llcc_mc = { > .name = "mas_llcc_mc", > .id = SC8180X_MASTER_LLCC, > @@ -1201,13 +1192,6 @@ static struct qcom_icc_node slv_srvc_gemnoc1 = { > .buswidth = 4 > }; > > -static struct qcom_icc_node slv_ipa_core_slave = { > - .name = "slv_ipa_core_slave", > - .id = SC8180X_SLAVE_IPA_CORE, > - .channels = 1, > - .buswidth = 8 > -}; > - > static struct qcom_icc_node slv_ebi = { > .name = "slv_ebi", > .id = SC8180X_SLAVE_EBI_CH0, > @@ -1524,11 +1508,6 @@ static struct qcom_icc_bcm bcm_co2 = { > .nodes = { &mas_qnm_npu } > }; > > -static struct qcom_icc_bcm bcm_ip0 = { > - .name = "IP0", > - .nodes = { &slv_ipa_core_slave } > -}; > - > static struct qcom_icc_bcm bcm_sn3 = { > .name = "SN3", > .keepalive = true, > @@ -1604,10 +1583,6 @@ static struct qcom_icc_bcm * const gem_noc_bcms[] = { > &bcm_sh3, > }; > > -static struct qcom_icc_bcm * const ipa_virt_bcms[] = { > - &bcm_ip0, > -}; > - > static struct qcom_icc_bcm * const mc_virt_bcms[] = { > &bcm_mc0, > &bcm_acv, > @@ -1766,11 +1741,6 @@ static struct qcom_icc_node * const gem_noc_nodes[] = { > [SLAVE_SERVICE_GEM_NOC_1] = &slv_srvc_gemnoc1, > }; > > -static struct qcom_icc_node * const ipa_virt_nodes[] = { > - [MASTER_IPA_CORE] = &mas_ipa_core_master, > - [SLAVE_IPA_CORE] = &slv_ipa_core_slave, > -}; > - > static struct qcom_icc_node * const mc_virt_nodes[] = { > [MASTER_LLCC] = &mas_llcc_mc, > [SLAVE_EBI_CH0] = &slv_ebi, > @@ -1857,13 +1827,6 @@ static const struct qcom_icc_desc sc8180x_gem_noc = { > .num_bcms = ARRAY_SIZE(gem_noc_bcms), > }; > > -static const struct qcom_icc_desc sc8180x_ipa_virt = { > - .nodes = ipa_virt_nodes, > - .num_nodes = ARRAY_SIZE(ipa_virt_nodes), > - .bcms = ipa_virt_bcms, > - .num_bcms = ARRAY_SIZE(ipa_virt_bcms), > -}; > - > static const struct qcom_icc_desc sc8180x_mc_virt = { > .nodes = mc_virt_nodes, > .num_nodes = ARRAY_SIZE(mc_virt_nodes), > @@ -1913,7 +1876,6 @@ static const struct of_device_id qnoc_of_match[] = { > { .compatible = "qcom,sc8180x-config-noc", .data = &sc8180x_config_noc }, > { .compatible = "qcom,sc8180x-dc-noc", .data = &sc8180x_dc_noc }, > { .compatible = "qcom,sc8180x-gem-noc", .data = &sc8180x_gem_noc }, > - { .compatible = "qcom,sc8180x-ipa-virt", .data = &sc8180x_ipa_virt }, > { .compatible = "qcom,sc8180x-mc-virt", .data = &sc8180x_mc_virt }, > { .compatible = "qcom,sc8180x-mmss-noc", .data = &sc8180x_mmss_noc }, > { .compatible = "qcom,sc8180x-qup-virt", .data = &sc8180x_qup_virt }, > diff --git a/drivers/interconnect/qcom/sc8180x.h b/drivers/interconnect/qcom/sc8180x.h > index 2eafd35543c7..c138dcd350f1 100644 > --- a/drivers/interconnect/qcom/sc8180x.h > +++ b/drivers/interconnect/qcom/sc8180x.h > @@ -51,7 +51,7 @@ > #define SC8180X_MASTER_SNOC_GC_MEM_NOC 41 > #define SC8180X_MASTER_SNOC_SF_MEM_NOC 42 > #define SC8180X_MASTER_ECC 43 > -#define SC8180X_MASTER_IPA_CORE 44 > +/* 44 was used by MASTER_IPA_CORE, now represented as RPMh clock */ > #define SC8180X_MASTER_LLCC 45 > #define SC8180X_MASTER_CNOC_MNOC_CFG 46 > #define SC8180X_MASTER_CAMNOC_HF0 47 > @@ -146,7 +146,7 @@ > #define SC8180X_SLAVE_LLCC 136 > #define SC8180X_SLAVE_SERVICE_GEM_NOC 137 > #define SC8180X_SLAVE_SERVICE_GEM_NOC_1 138 > -#define SC8180X_SLAVE_IPA_CORE 139 > +/* 139 was used by SLAVE_IPA_CORE, now represented as RPMh clock */ > #define SC8180X_SLAVE_EBI_CH0 140 > #define SC8180X_SLAVE_MNOC_SF_MEM_NOC 141 > #define SC8180X_SLAVE_MNOC_HF_MEM_NOC 142