From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Shuai Zhang <quic_shuaz@quicinc.com>,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: quic_bt@quicinc.com
Subject: Re: [PATCH 2/3] driver: bluetooth: hci_qca: fix host IBS state after SSR
Date: Tue, 15 Jul 2025 11:12:35 +0200 [thread overview]
Message-ID: <67431c9f-d843-488d-af32-c70aa183ba19@oss.qualcomm.com> (raw)
In-Reply-To: <20250715051618.724475-3-quic_shuaz@quicinc.com>
On 7/15/25 7:16 AM, Shuai Zhang wrote:
> After SSR, host will not download the firmware, causing
> controller to remain in the IBS_WAKE state. Host needs
> to synchronize with the controller to maintain proper operation.
>
> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 791f8d472..a17d3f7ae 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1658,10 +1658,14 @@ static void qca_hw_error(struct hci_dev *hdev, u8 code)
> * the QCA_SSR_TRIGGERED and QCA_IBS_DISABLED bits cannot be cleared.
> * This leads to a reset command timeout failure.
> * Also, add msleep delay to wait for controller to complete SSR.
> + *
> + * Host will not download the firmware after SSR, controller to remain
> + * in the IBS_WAKE state, and the host needs to synchronize with it
> */
> if (!test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks)) {
> clear_bit(QCA_SSR_TRIGGERED, &qca->flags);
> clear_bit(QCA_IBS_DISABLED, &qca->flags);
> + qca->tx_ibs_state = HCI_IBS_TX_AWAKE;
> msleep(50);
This touches upon the code introduced in the previous patch.
Any reason they should be separate?
Konrad
next prev parent reply other threads:[~2025-07-15 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 5:16 [PATCH 0/3] Fix SSR issues caused by BT_EN being pulled up by hardware Shuai Zhang
2025-07-15 5:16 ` [PATCH 1/3] driver: bluetooth: hci_qca: fix ssr fail when BT_EN is pulled up by hw Shuai Zhang
2025-07-15 9:11 ` Konrad Dybcio
2025-07-18 23:32 ` Shuai Zhang
2025-07-29 14:18 ` Konrad Dybcio
2025-08-12 8:03 ` Shuai Zhang
2025-08-12 9:16 ` Konrad Dybcio
2025-07-15 5:16 ` [PATCH 2/3] driver: bluetooth: hci_qca: fix host IBS state after SSR Shuai Zhang
2025-07-15 9:12 ` Konrad Dybcio [this message]
2025-07-22 3:51 ` Shuai Zhang
2025-07-15 5:16 ` [PATCH 3/3] driver: bluetooth: hci_qca: Multiple triggers of SSR only generate one coredump file Shuai Zhang
2025-07-15 9:12 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67431c9f-d843-488d-af32-c70aa183ba19@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=quic_bt@quicinc.com \
--cc=quic_shuaz@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).