Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: abhinavk@codeaurora.org
To: Thierry Reding <thierry.reding@gmail.com>
Cc: aravindh@codeaurora.org, linux-arm-msm@vger.kernel.org,
	dri-devel@lists.freedesktop.org, varar@quicinc.com,
	seanpaul@chromium.org, daniel.vetter@ffwll.ch,
	treding@nvidia.com, chandanu@codeaurora.org
Subject: Re: Reverting https://patchwork.freedesktop.org/patch/336850/
Date: Mon, 02 Mar 2020 12:41:08 -0800	[thread overview]
Message-ID: <67a9625bc57d85f675af5074f9ded248@codeaurora.org> (raw)
In-Reply-To: <20200302080912.GA1690850@ulmo>

Hi Thierry

Thanks for the response.
We shall reimplement these locally in our drivers and push the next 
patchset.

Thanks

Abhinav
On 2020-03-02 00:09, Thierry Reding wrote:
> On Fri, Feb 28, 2020 at 05:35:51PM -0800, abhinavk@codeaurora.org 
> wrote:
>> Hi Thierry
>> 
>> For DP drivers using MSM chipsets, we are using drm_dp_link_configure,
>> drm_dp_link_power_up and drm_dp_link_power_down functions. Here is the 
>> patch
>> for reference:
>> 
>> https://patchwork.freedesktop.org/patch/343346/
>> 
>> We will be posting a newer version of the driver soon.
>> 
>> For that, we plan to revert 
>> https://patchwork.freedesktop.org/patch/336850/
>> as now there are more users of the functions and not just tegra.
>> 
>> Let us know if this is the right approach or shall we make the 
>> required
>> functions local to our drivers.
> 
> I think reimplementing these locally in you drivers is the preferred
> way. It's not so much a lack of users (there were 5 or so in total when
> I made the change to remove these helpers), but rather the general
> approach that was being criticized by other driver maintainers. I'm not
> aware of any of their opinions having changed on this subject, so I'd
> recommend going down the path of least resistance.
> 
> Thierry
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-03-02 20:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29  1:35 Reverting https://patchwork.freedesktop.org/patch/336850/ abhinavk
2020-03-02  8:09 ` Thierry Reding
2020-03-02 20:41   ` abhinavk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67a9625bc57d85f675af5074f9ded248@codeaurora.org \
    --to=abhinavk@codeaurora.org \
    --cc=aravindh@codeaurora.org \
    --cc=chandanu@codeaurora.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    --cc=varar@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox