From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards
Date: Tue, 7 Oct 2025 10:45:07 +0900 [thread overview]
Message-ID: <67e313d3-1f91-4205-8aec-fbbfa41004f2@kernel.org> (raw)
In-Reply-To: <20251007-qrb2210-qcm2290-sndcard-v1-1-8222141bca79@linaro.org>
On 07/10/2025 10:26, Alexey Klimov wrote:
> Add soundcard compatible for QRB2210 (QCM2290) platforms.
> While at this, also add QRB2210 RB1 entry which is set to be
> compatible with QRB2210 soundcard.
You explained here what you did, but you should explain why. I don't
quite get why SoC sound card and RB1 sound card are both needed. I would
just go with one.
Please use subject prefixes matching the subsystem. For bindings, the
preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-07 1:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 1:26 [PATCH 0/2] Sndcard compatible for qrb2210/qcm2290 Alexey Klimov
2025-10-07 1:26 ` [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards Alexey Klimov
2025-10-07 1:45 ` Krzysztof Kozlowski [this message]
2025-10-08 2:40 ` Alexey Klimov
2025-10-08 2:52 ` Krzysztof Kozlowski
2025-10-16 15:08 ` Srinivas Kandagatla
2025-10-16 19:46 ` Dmitry Baryshkov
2025-10-17 7:35 ` Alexey Klimov
2025-10-17 11:27 ` Srinivas Kandagatla
2025-10-17 13:50 ` Dmitry Baryshkov
2025-10-22 16:46 ` Alexey Klimov
2025-10-07 1:26 ` [PATCH 2/2] ASoC: qcom: sm8250: add qrb2210-sndcard compatible string Alexey Klimov
2025-10-16 14:24 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e313d3-1f91-4205-8aec-fbbfa41004f2@kernel.org \
--to=krzk@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox