From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A01C433EF for ; Fri, 11 Mar 2022 13:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239268AbiCKNEA (ORCPT ); Fri, 11 Mar 2022 08:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345771AbiCKND7 (ORCPT ); Fri, 11 Mar 2022 08:03:59 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06CB3673D0 for ; Fri, 11 Mar 2022 05:02:54 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id b14so5902311ilf.6 for ; Fri, 11 Mar 2022 05:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GjFRD/9lEJoDZd2iHKsangrWSMTO+5I2agn/qVuV8qs=; b=mFwvW4rXhHFY/F7Hmapw3Rafdjg4wgiZVsST1HQiQHcQcDPio3iFZMTOVmwYR3+Vwp 2+mCtb+tkPhSmYWZtrYicfUyy9ZByxewSj5V6NgpjwcAYfjKAWOwCgXJodJq3ra4vYyx S9LjsdPZ0RYrYFNFFZHh0xB2p38eSgzvv+PvWmyks5dMAmBHjTnG61TgtQ1D4AWKk0xb 9YibeoiGSu5KPoTGcmIC2MP+aw9+UakeJ3Pe2uWfMS3ZTnCGp4GS1jpmpFxsen1vGw7l +XH2VbHgTkYcbkXAgQ1ni7Q8VI47/JiaHwO8SKCq4BAnZUg86stjL4918vAbkdET2UFU oOLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GjFRD/9lEJoDZd2iHKsangrWSMTO+5I2agn/qVuV8qs=; b=gh5EMttYDQQ3QkhVRs98Lj7ZiUaVPOiJK6vpq9IY1Ur0I4YOHQYAV0rgXn4UHy7zZd xcKYGCHxriJe+AM7sp+Fmtg3oET781eBqOrpOrMF3T8PWZdc7tJ6RE8MhD+D+4xw0XU+ wTV1sW1UMXU0QxNpVullSmm+j8GQfhswEf0D7KUvcWxJWM7wh8SYot6LiRqLuiDP4vlp GZYs+iaIefUbF4PEb8BbJ3Lq+2+mS7Thxy6E6eO3/lSvw++oeJeXXWbgejo6HaIiAjw3 Jj3noImnoBSw1uI24e8kybk9L1JDnBsfah/ebnZZPDt99744dC2iORJNEORt7aAUoigD EpSg== X-Gm-Message-State: AOAM533HB3Sh1e/ec69lVs47q/GxDbbEzS3ZmRXjpG78v77ktSkt/1AO OMhEceD5QAN6rbAb3M5MoamObg== X-Google-Smtp-Source: ABdhPJxR9fs0AtdoSZ4y9wsmyyDoVP8I7fhsy0a9F0fDPMq6S4RGQRXFtLgHy4uQJiid5eIa0QtMCA== X-Received: by 2002:a05:6e02:1baf:b0:2c2:46eb:a074 with SMTP id n15-20020a056e021baf00b002c246eba074mr7234018ili.263.1647003773245; Fri, 11 Mar 2022 05:02:53 -0800 (PST) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id l14-20020a056e0205ce00b002c782f5e905sm81979ils.74.2022.03.11.05.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 05:02:52 -0800 (PST) Message-ID: <680f7662-7a7d-4e26-6fdf-e4d961895dcd@linaro.org> Date: Fri, 11 Mar 2022 07:02:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH net-next v2 6/7] net: ipa: embed interconnect array in the power structure Content-Language: en-US To: Jakub Kicinski Cc: davem@davemloft.net, djakov@kernel.org, bjorn.andersson@linaro.org, mka@chromium.org, evgreen@chromium.org, cpratapa@codeaurora.org, avuyyuru@codeaurora.org, jponduru@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220309192037.667879-1-elder@linaro.org> <20220309192037.667879-7-elder@linaro.org> <20220310212523.633287d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Alex Elder In-Reply-To: <20220310212523.633287d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/10/22 11:25 PM, Jakub Kicinski wrote: > On Wed, 9 Mar 2022 13:20:36 -0600 Alex Elder wrote: >> - power = kzalloc(sizeof(*power), GFP_KERNEL); >> + size = data->interconnect_count * sizeof(power->interconnect[0]); >> + power = kzalloc(sizeof(*power) + size, GFP_KERNEL); > > struct_size(), can be a follow up I can do that today; I'll look for other instances in the driver where this could be done as well. Thanks. -Alex