From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9398A1509B6 for ; Fri, 22 Nov 2024 02:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732241738; cv=none; b=qvdFVxEUCft2SNwp4A7e7OlQowBEM66zVBlhULOuX6mGGFWMz6BnnGBnwxClc0nG9pdGvrTFuuX28zc4W7dfmyunODGFEFwIBqHTjGN+etn+dSnuxCDBpgcWy6lUuNcwNsWL1QnMQHdSyoPp6TPYz0Oc0wEPId+z292SqLaXK6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732241738; c=relaxed/simple; bh=VxyaAawq635VFwxzjMATQmgnv597ejgjim9U2dP1BzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HhUhOyh2kIyaT9J+2H2QDhiARk0z0SGrpSHmzgryo7sZWL11h1Zd9kGJF7oWso1yp1D+3YfTL0gT45eI6jjPaZf3gOTWb2ezLI8usiNEnIrp3sc5xfv8RR1bJxkoaXJIwGuwlFU9jUEOkimIJt8dhVwUF2hsyk1OtzQ/fNXfvFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l172e2LS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l172e2LS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AM24TNM025117 for ; Fri, 22 Nov 2024 02:15:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Soz8pIZ6jRj2Y5v7S/U4s/n0e2OeYV7kUBu2uRLlbI0=; b=l172e2LS9szWZQOM QajQ9SZ7bgA5U+G3V724DLiyhJ5jTmibJ5oz3KXVtgJt99IT0mRj0rXsgb3xyCU4 MaHTri/szhqM5bJ4atc/+P3oyljhPcTLP71Mf7uU5VyndU3G5yJlkTwyv1QIDLct tH3AjewNVks6Q2kcWCVYyzunDTLKzre2+BA/0Kl5ZVtChNSTtzmDY5CYMNU8q3bg faVl4ONiOb/Z5+6qu9TqWmcoI7gXOAhSqyL3fdzsjypXLli8NsrMcIlHyQHqWL+9 JLH0D7Q+/YM/pZBYch4kEHrR4hLJhe7uDxm+JX7SovFlpr96iM0MBob1dxVsytHS 3sxRZw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43251nhw09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 22 Nov 2024 02:15:35 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-460958ceccdso3646701cf.1 for ; Thu, 21 Nov 2024 18:15:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732241734; x=1732846534; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Soz8pIZ6jRj2Y5v7S/U4s/n0e2OeYV7kUBu2uRLlbI0=; b=cIK6fD0YR1X5PyjZmjF6Hr6NLePNQByva8SqzSK+4NKpG7T8SsDDTgvgMSugMgFcd/ /8MXzYXuftYNN5wjBcnP8dLJlQ7qZ3dlfMe/nPBzLV/YMym4a8YzLxrKIbtyTOhqJlRD KS9wVCJyaJoxbLlayC1TD8CyjR/ezQVEujD3ogb7V91goH6sG7K15k1av1iA2pek4ycf wOXMynyDas4jhYbg860IAA7kXreuDKuL+dCFoY6IMwjHvImEh9xLqyyjfFgZ2Keuwq22 7D7Rt1ldMPolx8YBmF/UdplJxIPvXIe7eC9K9yDvA89QHvq8bsYDJpAxspIaVJ3pmP2M 7fHw== X-Forwarded-Encrypted: i=1; AJvYcCWRcLGrQrhP9NQ/w9R2WUFADHJTINcEQuSeCFzBwhuNT22lNlAWqzlVUFnX7Lfchcsw+8dsFGqFWXHMvdic@vger.kernel.org X-Gm-Message-State: AOJu0YwCr4Lr+74wrYMNuuthS8KH4p0mvU18Swj571DzGFrXofzQ4fbp J4+oLb+mB66fieAJacCE//znVy2Bxj6C0r5ol5zi5+ePi9ZZIehNNY47UOZRVGsuHS8syayYeMU ZzfJPnD5ZnLfZqKq1a4aiLTTEhF7+ldes2hR0lb/TM4C69Vao53QMRhFG+ZOf18Q3Zce9XccH X-Gm-Gg: ASbGncukj8/p2wK3KuddGVAgGZbZJUXfFuMOusSSRIJtbo+GuGdMA+07/11SDHQN+z5 J2fkWmQmjMnN3BkRy4I5sQ/o/+B76TuE9Dy0UJjjfHcUuA2rLatWQoqFMzyZFHcpZlJm6eanmQ8 cD3Vc0ugIUqdboTc6OWjbpQGztoQ4bgnGJVLbBF9ltd46bMdVx1WiFKdFGWv4IIYzL8Zp9JmKyh 6prBXoEoZD7a1V9wLdS1IzSidLNuPVZ6eVVvtEXj9NBQTfgyZdc9GWimbrQKVd+gvOfv3DLDzkm zVSU6vRcgSnx9DDC+gCjO76E47STW78= X-Received: by 2002:a05:622a:54f:b0:460:ab1b:5ab7 with SMTP id d75a77b69052e-4653d6169b7mr9099811cf.12.1732241734368; Thu, 21 Nov 2024 18:15:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPk1lo1tsdbgqDNM7SSd71npxOR9gKFtFNgAppNMiNw7ZLX7BIToVocOUHAYiuJYlS0LI2Ag== X-Received: by 2002:a05:622a:54f:b0:460:ab1b:5ab7 with SMTP id d75a77b69052e-4653d6169b7mr9099661cf.12.1732241733994; Thu, 21 Nov 2024 18:15:33 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d01d3be73fsm378301a12.39.2024.11.21.18.15.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 18:15:32 -0800 (PST) Message-ID: <68366576-7b3e-4812-8e4e-ed0aa2b4cd01@oss.qualcomm.com> Date: Fri, 22 Nov 2024 03:15:29 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100 To: Rob Herring , Konrad Dybcio Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241116-topic-x1e_usb2_bindings-v1-1-dde2d63f428f@oss.qualcomm.com> <20241119171315.GA1805024-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241119171315.GA1805024-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: z27n6-PogGuwG6runG9fIc86nihVIoiq X-Proofpoint-GUID: z27n6-PogGuwG6runG9fIc86nihVIoiq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 phishscore=0 mlxlogscore=490 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411220017 On 19.11.2024 6:13 PM, Rob Herring wrote: > On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> X1 has multiple DWC3 hosts, including one that's USB2, which naturally >> means it doesn't have a SuperSpeed interrupt. Make it optional to fix >> warnings such as: >> >> usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > > That's a good start, but what about all the other warnings for usb > interrupts?: > > 13 usb@f92f8800: 'interrupt-names' is a required property > 11 usb@76f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short > 11 usb@6af8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short > 11 usb@6af8800: interrupt-names:1: 'qusb2_phy' was expected > 11 usb@6af8800: interrupt-names:0: 'pwr_event' was expected > 11 usb@6af8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short > 9 usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > 7 usb@c2f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short > 5 usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short > 5 usb@8af8800: interrupt-names: ['pwr_event'] is too short > 4 usb@8af8800: interrupts: [[0, 62, 4]] is too short > 4 usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short I'll address most of those shortly. Need to dig up a couple old devices to make sure my findings reflect reality ;) Konrad