From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DBD9FA3743 for ; Mon, 31 Oct 2022 15:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbiJaPfr (ORCPT ); Mon, 31 Oct 2022 11:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbiJaPfq (ORCPT ); Mon, 31 Oct 2022 11:35:46 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C04A46364 for ; Mon, 31 Oct 2022 08:35:44 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id cl5so4861760wrb.9 for ; Mon, 31 Oct 2022 08:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:reply-to:organization:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=TsXJSVmpsfRwUaoUkQeZoN5vrNGuaXJ+yHnFyn7q25I=; b=kNDVSruV16A9lm4yIH6ED5p3NglZj4zIWm6IWzCXkUhLysu/9kFqTnjIKo0B5mdWtE bVkze8vz56g3cNUjHYUhdd2HSRi3Lr77pdsuZdu/ZSMft7E+XFsIZcNWXo6s6H0+dMVH x5hy2kxnN7LVX3Yki1W5sEdlWJRu5LnLP0Z30WQ5M4r6Xw4Aq0ROJk3qcBp2JfWxarBl zZTGvO9QBblm1HmA+daQtS4fyx7f1QGrlVWeziluZvNx7LQ0REWS2xw6IZ/EyUs2cjDK ZxxhWhPVf2FcTxe9wbNDK87W4N6DD4Gjf4lnkHIyHwncXHxqgu0zsO1XLUNAzjCI0n2i /RwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:reply-to:organization:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TsXJSVmpsfRwUaoUkQeZoN5vrNGuaXJ+yHnFyn7q25I=; b=MM4cQA3rzFMW/XU92zC9MS/gnb411FZOwe3iD8NU2vJXntSkqFpVGJ0giccQuBBcaK utYHac3p77QrR/ubhcinqQLJR89BkkfwgUdQzZJR8F1dDbtZrO4Fz1T/PR8q6gUEd2JY 1E1n3+jKv4Sd5PTsh0fzPrje//C4FHZQ+RLgeOFFLDRxDxWXh8xwIUkRdZYMcdwfJZc1 blJtJdWpznHkeUkFBw9hsJR54CwiH3Nt/n4vXoymyPZS2ejfVLb4eOPtT7UGYNQIqhca hcq7H2J2Vghc7/Ji5BL9QDoaCgXEDOP5IGcbytbdXz4Wxee09zrB4ivIGfsNLTqSt93I c1mg== X-Gm-Message-State: ACrzQf04IsKocBFB8KP/G9BtzpfezANuNv5L46xNHYowfo/3mkm6+LVl gaL7BsOeeNutHDy5COMkS/PIZA== X-Google-Smtp-Source: AMsMyM73Wi/PfFl19dSX+YB0TWP0LDVvL+RVag0yoxDj3CQC07pDBzEctGykPU2rWEpvK1FkJgWkuQ== X-Received: by 2002:adf:f4c7:0:b0:236:c415:c707 with SMTP id h7-20020adff4c7000000b00236c415c707mr5202241wrp.24.1667230543206; Mon, 31 Oct 2022 08:35:43 -0700 (PDT) Received: from ?IPV6:2a0d:e487:34f:ed70:97ca:71f8:f780:5cf1? ([2a0d:e487:34f:ed70:97ca:71f8:f780:5cf1]) by smtp.gmail.com with ESMTPSA id i6-20020a05600c070600b003cf483ee8e0sm7306730wmn.24.2022.10.31.08.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 08:35:42 -0700 (PDT) Message-ID: <6858acf3-eb90-41aa-b714-a2ceb6afe9db@linaro.org> Date: Mon, 31 Oct 2022 16:35:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Content-Language: en-US To: Lee Jones Cc: Bjorn Andersson , Satya Priya , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Dmitry Torokhov , Alexandre Belloni , Andy Gross , Alessandro Zummo , linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Rob Herring , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v4-0-dac2dfaac703@linaro.org> <20220928-mdm9615-dt-schema-fixes-v4-8-dac2dfaac703@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services Reply-To: neil.armstrong@linaro.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 31/10/2022 16:32, Lee Jones wrote: > On Fri, 21 Oct 2022, Neil Armstrong wrote: > >> The PM8018 compatible is always used with PM8921 fallback, so PM8018 >> compatible can be safely removed from device ID table >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Neil Armstrong > > Tags should appear chronologically. Indeed, they were added by b4, I'll report this. Thanks, Neil > > I've fixed this up and applied the patch, thanks. > >> --- >> drivers/mfd/qcom-pm8xxx.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c >> index 2f2734ba5273..601106580e2e 100644 >> --- a/drivers/mfd/qcom-pm8xxx.c >> +++ b/drivers/mfd/qcom-pm8xxx.c >> @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = { >> }; >> >> static const struct of_device_id pm8xxx_id_table[] = { >> - { .compatible = "qcom,pm8018", .data = &pm8xxx_data}, >> { .compatible = "qcom,pm8058", .data = &pm8xxx_data}, >> { .compatible = "qcom,pm8821", .data = &pm8821_data}, >> { .compatible = "qcom,pm8921", .data = &pm8xxx_data}, >> >