From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D54E13D503 for ; Thu, 13 Jun 2024 08:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718266786; cv=none; b=S2+FRTUsCU/DnjmNk3OFyqBUQ9WeZ49QOtDmg6xKOMV4foZud92r/4fDjiHM4FUyjBVCO69k3c7GX0Y4sxGZqfQMV1x4kjXuPd+Z984Ou3nynDpCR58Zj02Wb2efk9zvv6NSzMyJ/8VN99090BLbHDACIpgrVXBYyLlbnk+0xsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718266786; c=relaxed/simple; bh=kqwyxqCAid86cD5vG1gVcUsF9oMz7VowpVEj+CbUwUU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pUoGGq3rPoxdHsGZFDgFUgZS1ct/FkXTpFsdpAHJEyfHH+NlCyIZgxGUVQrZfGyH8JJR+8eT5FJR+tZJ8kPSmJSg9UZ6c9kzks7EDOjbpFa6Zc6rkTH8XblOEBcVFnMQF7E25oz5SuKbn8K0BREke9l6apaDdrvbJuEfEzL/sqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=otJk6Np+; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="otJk6Np+" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2eaea316481so591151fa.2 for ; Thu, 13 Jun 2024 01:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718266782; x=1718871582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+0UP0g4SgJBlO7fJs5utFNOMdYzCMBOE1A8PYkpodHE=; b=otJk6Np+lRUpwoKD56lY45QCKqUyWVT0ktrQ2ciJGMMFpb6ibbragctKCvizsGJliJ LfsOHaNJnIr1FfrG/HDRUb7B0d01qf7n/q5HIOHDX203TRyUO5q6V7xWpml50xytfvwy yp1t4WnOITbkFo8uMmDlP9cvPyq76Ya3zxBhyjj20L4M/BlA0ECA7m5S0ar8Kxbw2G6v Q9dhDh1VIcfwH/T2ilYCbtpn2RSnKr1CtptiXa4FayA/8t52qHk34uhPH3rIIsCym/PD 2u1MILHgXe7dkuRVnINcEIN/SI9t225hhH2n2YaZc5fKospk1APiT0WkEOYqaVz6vY/L 7s7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718266782; x=1718871582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+0UP0g4SgJBlO7fJs5utFNOMdYzCMBOE1A8PYkpodHE=; b=i9kIpozsqnD1bVAaNPNGZumTuMWK3eno/NeVk2KIjIvNGDdOABSfash++BPTYCO2sF cLwwxbZr30pi7eDu9qG8tk7DNqYEn9SffCno4orKzW1BgFvgPp7sFEr8xkBRi8cTdLv0 DzaqZtGeYZldBcpuRFWoGIvfg0AcOoiBqstm0Z5YZwUwnDGbx5abIr3V/9NWTmJj2hEu c2SCJXe3B/RPy/HMuFvXke9syHyhrAeU2Y4TGZrlruni3t5kNG1jnKwM44yzyXkNv7ZR MIn5+oTylYPGpJo5XyEFOxUVPLtpKiIn/Rwa0NxFxOHEP6SkrnLP9WB015Z0ofnLax5J Hn2w== X-Gm-Message-State: AOJu0YwtBxA2vvGA0+vjIi6Hiyubeqj5uTH+JjIY6r1NcV05st+Qwgwm DteIRyaAAH+xbqExDvGd/JBuRKDFieWs74LHyw96XAeYPjwDwze1Ont8WYajO0A= X-Google-Smtp-Source: AGHT+IGVP/0aCb+LgJGqQTXXDStsxDbTPr1bzgPtOQZziu+iQkXKZZEEujrtax/g9gdqsncG888sGA== X-Received: by 2002:a2e:2a85:0:b0:2eb:e738:53b2 with SMTP id 38308e7fff4ca-2ebfc8b174dmr26404661fa.1.1718266782557; Thu, 13 Jun 2024 01:19:42 -0700 (PDT) Received: from [192.168.1.3] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c16f00sm1240211fa.61.2024.06.13.01.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 01:19:42 -0700 (PDT) Message-ID: <68a18159-11ff-412c-b742-34ceb0f3a028@linaro.org> Date: Thu, 13 Jun 2024 11:19:34 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 1/8] clk: qcom: clk-alpha-pll: Fix CAL_L_VAL override for LUCID EVO PLL To: Ajit Pandey , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Jagadeesh Kona , Imran Shaik , Satya Priya Kakitapalli , stable@vger.kernel.org, Dmitry Baryshkov References: <20240611133752.2192401-1-quic_ajipan@quicinc.com> <20240611133752.2192401-2-quic_ajipan@quicinc.com> Content-Language: en-US From: Vladimir Zapolskiy In-Reply-To: <20240611133752.2192401-2-quic_ajipan@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ajit, On 6/11/24 16:37, Ajit Pandey wrote: > In LUCID EVO PLL CAL_L_VAL and L_VAL bitfields are part of single > PLL_L_VAL register. Update for L_VAL bitfield values in PLL_L_VAL > register using regmap_write() API in __alpha_pll_trion_set_rate > callback will override LUCID EVO PLL initial configuration related > to PLL_CAL_L_VAL bit fields in PLL_L_VAL register. > > Observed random PLL lock failures during PLL enable due to such > override in PLL calibration value. Use regmap_update_bits() with > L_VAL bitfield mask instead of regmap_write() API to update only > PLL_L_VAL bitfields in __alpha_pll_trion_set_rate callback. > > Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces") > Cc: stable@vger.kernel.org > Signed-off-by: Ajit Pandey > Reviewed-by: Dmitry Baryshkov thank you for the fix! Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir