Re: [PATCH v4 2/4] dt-bindings: mfd: qcom,spmi-pmic: add qcom,pm4125-codec compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/10/2025 11:18, Alexey Klimov wrote:
> On Thu Sep 18, 2025 at 3:03 AM BST, Krzysztof Kozlowski wrote:
>> On Mon, Sep 15, 2025 at 05:27:49PM +0100, Alexey Klimov wrote:
>>> Add qcom,pm4125-codec compatible to pattern properties in mfd
>>> qcom,spmi-pmic schema so the devicetree for this audio block of PMIC
>>> can be validated properly.
>>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>>> ---
>>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> index 078a6886f8b1e9ceb2187e988ce7c9514ff6dc2c..776c51a66f6e7260b7e3e183d693e3508cbc531e 100644
>>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> @@ -137,6 +137,12 @@ patternProperties:
>>>  
>>>    "^audio-codec@[0-9a-f]+$":
>>>      type: object
>>> +    oneOf:
>>> +      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
>>> +      - properties:
>>> +          compatible:
>>> +            const: qcom,pm4125-codec
>>
>>
>> Not much improved. Same feedback applies.
> 
> Around the time of sending this I thought to set separate follow-up patch
> that fixes the other part here -- pm8916-wcd-analog-codec.
> 
> At this point, is it fine to send follow-up patch that does smth like
> this:
> 
> +    oneOf:
> +      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
> +      - properties:
> +          compatible:
> +              - enaum:
> +                - qcom,pm4125-codec
> +                - qcom,pm8916-wcd-analog-codec
> 
> ?
> 
> (I didn't check how if it will compile or pass checks)

You still propose something very different than I asked at v3. Drop the
$ref, you only want a compatible with enum. Look at
qcom,sa8775p-mdss.yaml (but you don't need contains). Or one of many MFD
drivers added last one year.

Best regards,
Krzysztof