From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6EC021313F for ; Thu, 7 Nov 2024 14:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730991048; cv=none; b=aUcBhkGrsL9OQVl0MFVqPMdGgA4UJ/Lwkdhl40ZOSWYy8C/nJshASJDIj14wI2nv7ndNWmKsD5u5p4W7HznaIkqUvjYcdNCR2Qx3u9mpqHzBGSZ0V0gd/AatG/5aRXW2PWzKPCpY2LLv4twFZmtS18ZOIK3D8AF0dx0oTkvGdGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730991048; c=relaxed/simple; bh=c/xTRIrJ5nBsiRyw55IV13bqiTCl2MenC3obfPMlG1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C69JZpjrimi/v5KxiyVl/mGvNySM7/mrqmQlHm6Gdg4zYSEw9caYcjKRzco2b+x+u7Us1979QAuz9eg23N/hcLPdtD0jAo2ukBcxZDa9lI5ZtX5CKqYorRdY1lOIi8wWgTnWpcF9QtST9rWOoILxss6axcB1y2sa7iWzieCs7mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jzaGTWfp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jzaGTWfp" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A79ON1w003902 for ; Thu, 7 Nov 2024 14:50:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= orOKMQLBCv2h1c195dYm+Nmc2xLy3QnFjG1e5d7Rl/o=; b=jzaGTWfp/NtUodwA RsSZofrgtVYoE9CVJy8F23qqbIjw9F7tczczFR+lApvRxRH45Cmo0Ou4ufqTME8H 8OKHwd5+vAGiZMizIVSXxKIP7ZLHyrlWzH3qPfqGqzdc6W+/54AV9hqcwjW41EiC /jYhvl47YZKoMPRUvx4bQ+8ij39K5Pd0Qx7ny/4cu3fOhbdrY0zRZ5IkfyyRxQyq tE6GeIwMTg4YkRkguQZWR780z6kfZpY1QrQ3T55wivy68XEXnOD0wR3I6AwwTxwf OqgvtaFhHBS0fVPivTMdWWMAMFoL01Gcnq0kMyAi2+BV2Vu287zJg6kaRwmaypOs SYzzCQ== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42qfdx7v58-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 07 Nov 2024 14:50:45 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-50dda47ec80so11085e0c.1 for ; Thu, 07 Nov 2024 06:50:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730991044; x=1731595844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=orOKMQLBCv2h1c195dYm+Nmc2xLy3QnFjG1e5d7Rl/o=; b=Ssg7SZlwCZ/wEBtXRnX3bSLoNrt79wLTt+14TTF+g6HpWGid0lTVMETwbv7qsP8ivR x5fsosA3kDHyHcl2b7nXYNkqbuCNA2+H0x6fh1s59kuoQft+2o0y5CP7P6HxKw8D1pmx QaHxyl/3errHl3ZfG9wpsZnTBM5Vzic/+fCu9UiDUWoYHnNXvAxBJKGFVZQnishmZldc LEl7Nwbmes2YpO+UsPNrDemqLffCgywa9IQ2Smg9L1bHiT2Ysb8q8dj/zbvepxNxC0aZ 5+ohMAw4zUKWv8CzzId/ynEQcnkVqlrJJf1okYiXDSB+FEtUkQ+fselE29sMl+4yN7Ye E8UA== X-Forwarded-Encrypted: i=1; AJvYcCUempY6rkSYYjf1cO6yLODlRKtnSk91GaSXAbnzKrvn8RmgyWK73RHg+LmjHJd3e3FBwt1I7GyMvGUmPWzs@vger.kernel.org X-Gm-Message-State: AOJu0YxIoV6tZnRUJy7gRDkLfinhuda4XVbHdDFqKJ/CmAkII1XxPuMy rO4UXsy4c7Kypj1dLkJE2I/zD0dG4G/wXA2tLVjOOpTRdUBiOUwTLqUj0BUSDNa4JreklTB+FMo vppJNiyLoBfnZSz6TsJbigbHRDkn15pd5LC0jkkLekyVKSySy17XqaVAP1HmmDgGs X-Received: by 2002:a1f:d1c4:0:b0:50d:6f0:5879 with SMTP id 71dfb90a1353d-513fe8bbd35mr120060e0c.1.1730991043632; Thu, 07 Nov 2024 06:50:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHus393ipmlzutzTG3KT0B8ynjWizWAAq7Gzr52l40pNnylVkHVxH+LD0GcjNXGrfSrQrhO9A== X-Received: by 2002:a1f:d1c4:0:b0:50d:6f0:5879 with SMTP id 71dfb90a1353d-513fe8bbd35mr120026e0c.1.1730991042981; Thu, 07 Nov 2024 06:50:42 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0a18872sm103586466b.11.2024.11.07.06.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 06:50:42 -0800 (PST) Message-ID: <69000e68-c1ef-4cdd-8fc0-2a04a6d38e02@oss.qualcomm.com> Date: Thu, 7 Nov 2024 15:50:39 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/7] arm64: dts: qcom: ipq5332: Add tsens node To: Manikanta Mylavarapu , srinivas.kandagatla@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com References: <20241104124413.2012794-1-quic_mmanikan@quicinc.com> <20241104124413.2012794-5-quic_mmanikan@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241104124413.2012794-5-quic_mmanikan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: X6X9aTa03FY2dCDDE7UKDrn5I032mUUh X-Proofpoint-ORIG-GUID: X6X9aTa03FY2dCDDE7UKDrn5I032mUUh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=966 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411070115 On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote: > From: Praveenkumar I > > IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsense > node with nvmem cells for calibration data. > > Signed-off-by: Praveenkumar I > Signed-off-by: Manikanta Mylavarapu > --- > Changes in V6: > - No change > > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 66 +++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index d3c3e215a15c..94dca05fdc2a 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -177,6 +177,46 @@ cpu_speed_bin: cpu-speed-bin@1d { > reg = <0x1d 0x2>; > bits = <7 2>; > }; > + > + s11: s11@3a5 { You're adding 's11' etc. to the global label namespace. Please make the names more specific, like tsens_sens11_off [...] > + tsens: thermal-sensor@4a9000 { > + compatible = "qcom,ipq5332-tsens"; > + reg = <0x4a9000 0x1000>, > + <0x4a8000 0x1000>; Please pad the address part to 8 hex digits with leading zeroes. Konrad