From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C68125E471 for ; Mon, 14 Apr 2025 10:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625140; cv=none; b=hkY6GAnxL4SVOMNkCetrardaZdLYSqn1Fs5Zfo9WIkQKsUAu/yryHBXbinLt/p9MJrMeqt5JAcho99s6Ed28cG8RmpZj1Tj+VKL2Vr77uXUFJLQgyGel7VrVNWO/F3lUOi8ApPn7r051g9Jdx7FvXybbucziJ0Bl9n9PWhz2C0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625140; c=relaxed/simple; bh=jDs8thLNCqncuvS6eDO8362rXAxntviZVG8dwQeCguA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RpZ0KKYKIUbUU08I/E6INRjOTmKhDSziK8AoEmgBDS8TSAHAHZuzbwu8Ji9Amiv18JCdZNs9LFmCGOkkP4dYSxYwEAcj5aOl0r+q4CJxTXZqIuQiQ772XaRxciRo2yKawStURB7dgTsroP8QyC/hAYzMre/3NpvaLR8ReT/H5oQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BGFWwjQa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BGFWwjQa" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E99rmS017681 for ; Mon, 14 Apr 2025 10:05:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UMvb8N95/gaSyVsSWCc3DQiAI8CRlEgBC06NE46MZVI=; b=BGFWwjQa2f9cEjFT qbBrfWdM+RFdK0K9hdYfPuRteQ8XNaiYwx67b3Ohkbvu55nMDHsq/Vu1HliRSriu G8YP0GPLDLIhb/pRr+RCG7ds+150Bmpj6tF0j5w3EfAUhGu1egHaUHu5o6JwgAsW EX0UNu99uROjyJlAnmg5ljh5DGJOE374S2ttB89cFaW5GNlrnec2iQX2TZUM9LM2 vVMbxndBqfFYBx/4KJnmDmmcAqD9aVQ2xC9+aA4aCFwbA/GX40vp8Gn9A7FdKEYD Wwz4eulHTX7xCMDig8iDUl0dMS54L7mummSuDy6dnWbx9JFL0RvvwLZSoaxe3BJ9 BsFp/w== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yf4vc6x5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 10:05:38 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6ece59c3108so9376856d6.2 for ; Mon, 14 Apr 2025 03:05:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744625137; x=1745229937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMvb8N95/gaSyVsSWCc3DQiAI8CRlEgBC06NE46MZVI=; b=rajcFwx9oCqBLkY6/BTa9VWx5fpo5NTU5j6dhX/ST+f82iSZ7kYERpuOX2s3MdPQ4o pyo/xApkxi0kSukXMhPIafb+sZZ0LCjv3YS/CETE3za+L0UrCJIAZiwzAXcwS4k4gWlS kByuJyGcoC03VhtBk5+JbAKOndGxbMt57mvs2vgo1DR1+7qxpyN7P59tA2eiG2GUe48i Rt1swdXLj3Ocy/iDLufFPk3aIiv7UqgyKzk7YUTC5zuEyVYQRb/LWyzpJPSzJVK//CVW ObYAm+Mc9+Wyrn4QCtL2nTMsa3ivYeVSzktYQcBzvmu/tf6cvrdBCK33y0TPR2ZBQp0/ b62g== X-Forwarded-Encrypted: i=1; AJvYcCUTbjEYTGO5mt2j5n3iMfbPN5E0ntFYSBXFcvNsKMTbuSU1paH9HWoL7DpOzzLWBelxyryE20XLiqiLCZSO@vger.kernel.org X-Gm-Message-State: AOJu0YwZmHix3HoIUVqCxgkzDN5sI65wLC13tnkLSC5TC6+nMu/knPEg 7zGmIrobTeySW9bbQ9d0NCklgVLZHmiTabyTdKV0yCqhXkNJQA+XDs5MBOKU5f+XHTXtctw+h+j CVDEtinyqcGtaSv2Hljxvj6dypP5eqw06qgJ+PKfr+wOrsl8faqG97stp6vm3odZy X-Gm-Gg: ASbGncsEe46RKdk7/8q7niqgidKQJmN24h1Ur+YJ/n9ZVQ6Z++lx4+xzP8U0W0gKWHg W3RCL3gcnfz9+ZlllP9RX1CiW+RyDPQQLWQWajbSrARi8vrNknoQ2wScuqXF/1dBDrxWRGL5bOb EkAdG+yIxQL+NjfJ2iuGo61BOi7H/PjCLvLe7Dpxi24ymSEyZs/6RniONjwyAdVc4ss/WjGBu+H npP+6fC/x5SQEOwLz1+YDeb5035VKajMt2L9MiyzHKn4MUhE3fMJbvMudqlkRg6EQHsK3aCWEmD 79GeF4kL0tZgCgYagUrMGUF4V8oVrZEQCneJJdbS9fb+dLIYmyGuOGg++/SnJbgEZw== X-Received: by 2002:a05:620a:3197:b0:7c5:8f37:1eb2 with SMTP id af79cd13be357-7c7af113d7bmr603267985a.9.1744625136556; Mon, 14 Apr 2025 03:05:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmBUa5andw4pRRHVYC8/NGtkbW9c5vRVpeMF8s8vhz5E8trZWGxeC/sN+v6rRNhzWhNX/m+Q== X-Received: by 2002:a05:620a:3197:b0:7c5:8f37:1eb2 with SMTP id af79cd13be357-7c7af113d7bmr603256585a.9.1744625133674; Mon, 14 Apr 2025 03:05:33 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1bb3120sm868414666b.1.2025.04.14.03.05.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 03:05:33 -0700 (PDT) Message-ID: <691a2358-bf5d-4f03-ae2d-97fb2e40952a@oss.qualcomm.com> Date: Mon, 14 Apr 2025 12:05:30 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes To: Ayushi Makhija , Dmitry Baryshkov , Krzysztof Kozlowski Cc: konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, andersson@kernel.org, robh@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com, quic_jesszhan@quicinc.com References: <20250404115539.1151201-1-quic_amakhija@quicinc.com> <20250404115539.1151201-8-quic_amakhija@quicinc.com> <0f4eca6c-67df-4730-88b3-a277903deabc@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 4ShOaasY5N_ec46WUHJqV7Xm-VaRegfk X-Authority-Analysis: v=2.4 cv=IZ6HWXqa c=1 sm=1 tr=0 ts=67fcddf2 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=gEfo2CItAAAA:8 a=ovN_W45TYzZQxDyi82gA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: 4ShOaasY5N_ec46WUHJqV7Xm-VaRegfk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140073 On 4/14/25 11:56 AM, Ayushi Makhija wrote: > Hi Dmitry, > > On 4/11/2025 1:31 AM, Dmitry Baryshkov wrote: >> On Thu, Apr 10, 2025 at 06:37:54PM +0530, Ayushi Makhija wrote: >>> Hi Dmirity/Konard >>> >>> On 4/7/2025 1:42 AM, Dmitry Baryshkov wrote: >>>> On Fri, Apr 04, 2025 at 05:25:36PM +0530, Ayushi Makhija wrote: >>>>> Add anx7625 DSI to DP bridge device nodes. [...] >>>>> @@ -517,9 +548,135 @@ &i2c11 { >>>>> >>>>> &i2c18 { >>>>> clock-frequency = <400000>; >>>>> - pinctrl-0 = <&qup_i2c18_default>; >>>>> + pinctrl-0 = <&qup_i2c18_default>, >>>>> + <&io_expander_intr_active>, >>>>> + <&io_expander_reset_active>; >>>> >>>> These pinctrl entries should go to the IO expander itself. >>>> >>>>> pinctrl-names = "default"; >>>>> + >>>>> status = "okay"; >>>>> + >>>>> + io_expander: gpio@74 { >>>>> + compatible = "ti,tca9539"; >>>>> + reg = <0x74>; >>>>> + interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; >>>>> + gpio-controller; >>>>> + #gpio-cells = <2>; >>>>> + interrupt-controller; >>>>> + #interrupt-cells = <2>; >>>>> + >>>>> + gpio2-hog { >>>> >>>> This needs a huuge explanation in the commit message. Otherwise I'd say >>>> these pins should likely be used by the corresponding anx bridges. >>> >>> Thanks, for the review. >>> >>> Previously, I was referring to the downstream DT and misunderstood the use of gpio-hog. >>> After reading the schematic, I realized that gpio2, gpio3, gpio10, and gpio11 are all input pins >>> to the IO expander TC9539. We have already configured gpio2 and gpio10 as interrupts in the >>> ANX7625 bridges, so the gpio-hog is not required. It is working without the gpio-hog configuration. >> >> Please make sure that there are pinctrl entries for all pins. >> > > Thanks, for the review. > > While declaring the pinctrl entries inside the io_expander node, I am getting below error while checking the DTBS check against DT-binding. > > Error : /local/mnt/workspace/amakhija/linux_next_11042025/linux/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: gpio@74: 'dsi0-int-pin-state', 'dsi1-int-pin-state' do not match any of the regexes: > '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# > > io_expander: gpio@74 { > compatible = "ti,tca9539"; > reg = <0x74>; > interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > > pinctrl-0 = <&io_expander_intr_active>, > <&io_expander_reset_active>; > pinctrl-names = "default"; > > dsi0_int_pin: dsi0-int-pin-state { > pins = "gpio2"; > input-enable; > bias-disable; > }; > > dsi1_int_pin: dsi1-int-pin-state { > pins = "gpio10"; > input-enable; > bias-disable; > }; > > }; > > I couldn't find any devicetree example of tca9539 which is using pinctrl. The gpio-pca95xx.yaml DT binding does not match with any regex of the patterns properties. It looks like patternProperties should be extended, perhaps with something that includes pincfg-node.yaml? Krzysztof? Konrad