From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C48CC77B7A for ; Tue, 30 May 2023 23:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233622AbjE3Xn7 (ORCPT ); Tue, 30 May 2023 19:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbjE3Xn6 (ORCPT ); Tue, 30 May 2023 19:43:58 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E61B2 for ; Tue, 30 May 2023 16:43:56 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-77703f20aa9so117943339f.1 for ; Tue, 30 May 2023 16:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685490235; x=1688082235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D3ypystYzBp0z6BGyUyrOubrVmHDSkpBeVSSYpzrgNU=; b=y9u0NB4kWnHYwt549HNPXWJTG3IRqe8/i0EgPjGKGvZyD3aP2NoPLebMVxLbcZdGoI B+1piYrPAfQVtfFMiqq4dy3hooHR5gQ2g1kves8qith5oI92YNMOzgnj/Q9RS/f7M9YH typUsW4DaeYZdS011PpV+S5goYadVJHRJ4mmOdUmWKHHgxFr2ch2RTCVA5C/6OpAHbbP zZSV8SaEUhvODRyfGj50W5/Pbe+d81pHxDxWupxNAcEFlKHLZ4IArqaV1NhbJ8aYjuB0 ICsS+U4VmwCuLpSyNSeNDLk4yaRC62eZ1VzHy0kFHfpSYmt2RsnWTRukVJ11lVyEKiqo 4dZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685490235; x=1688082235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D3ypystYzBp0z6BGyUyrOubrVmHDSkpBeVSSYpzrgNU=; b=AO+OwKRA3bvj2Z/AKVwIuHRbqleunXzasdVYGMbYboUZmPYhUhLqDIFPhxA20EBLjF JsvYmudVAcrjSRbYLabqy8UepYARLNsZhnU3IZkEffc3LOr17N7ELQtk2HTNAIEn8dTR i0z7YZOWpcEfZZvoqIFr+95hm2u4A2roB8TwLMmFLqt/r0QwQ6kxL1nhm4GcXWjhPV6H B+VQ66kIFhbevmYpQtCPdNxn/Cwq1xrFa3GZY4PjZ076vP14Pm1wN2XRE5xK7g8ikedP MiAjmqtmRJDOSqPCrNqvq/2JGZOtjauOJkikE6sKs+1OANWKjrSq00YmKsgSsqwazfSo UmsQ== X-Gm-Message-State: AC+VfDzHA0UuRgtxCwUSOSRdNiFEBjw0nFgMEOCZpSJy4eqqsPtab2DH M7nJDIUCF7Zs9uUVPm0fp00HUA== X-Google-Smtp-Source: ACHHUZ5eAUPfBfmQO0GDa5baK1HyIohLoaAUddvYA3t+pGk/ntaEhQaO5j0ioafC/00n6ndwS115vA== X-Received: by 2002:a5d:87c2:0:b0:76c:65df:a118 with SMTP id q2-20020a5d87c2000000b0076c65dfa118mr2397211ios.6.1685490235653; Tue, 30 May 2023 16:43:55 -0700 (PDT) Received: from [10.211.55.3] ([98.61.227.136]) by smtp.gmail.com with ESMTPSA id l5-20020a5e8805000000b0076c5c927acesm3522902ioj.13.2023.05.30.16.43.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 16:43:55 -0700 (PDT) Message-ID: <694f1e23-23bb-e184-6262-bfe3641a4f43@linaro.org> Date: Tue, 30 May 2023 18:43:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE Content-Language: en-US To: Bert Karwatzki , Alex Elder , Simon Horman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <7ae8af63b1254ab51d45c870e7942f0e3dc15b1e.camel@web.de> <2b91165f667d3896a0aded39830905f62f725815.camel@web.de> <3c4d235d-8e49-61a2-a445-5d363962d3e7@linaro.org> <8d0e0272c80a594e7425ffcdd7714df7117edde5.camel@web.de> From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/30/23 6:25 PM, Bert Karwatzki wrote: > From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki > To: davem@davemloft.net > To: edumazet@google.com > To: kuba@kernel.org > To: pabeni@redhat.com > Cc: elder@kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Date: Wed, 31 May 2023 00:16:33 +0200 > Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE > > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > for the size of the removed struct ipa_status which had size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. If the network maintainers can deal with your patch, I'm OK with it. David et al if you want something else, please say so. Reviewed-by: Alex Elder > Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") > Signed-off-by: Bert Karwatzki > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data,