linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Joel Selvaraj <joelselvaraj.oss@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Caleb Connolly <caleb@connolly.tech>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v4 4/4] arm64: dts: qcom: sdm845: do not customize SPI0 pin drive/bias
Date: Thu, 22 Dec 2022 16:14:47 +0100	[thread overview]
Message-ID: <697f07b4-87e6-9fa5-4298-82b075a96264@linaro.org> (raw)
In-Reply-To: <20221222151319.122398-4-krzysztof.kozlowski@linaro.org>



On 22.12.2022 16:13, Krzysztof Kozlowski wrote:
> Each board should define pin drive/bias for used busses.  All boards
> using SPI0 (db845c and cheza) already do it, so drop the bias/drive
> strength from SoC DTSI.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Cc: Doug Anderson <dianders@chromium.org>
> 
> Changes since v3:
> 1. Rb tag
> 
> Changes since v2:
> 1. New patch.
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index dcea535de9b7..cac70212cc2a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2785,8 +2785,6 @@ qup_i2c15_default: qup-i2c15-default-state {
>  			qup_spi0_default: qup-spi0-default-state {
>  				pins = "gpio0", "gpio1", "gpio2", "gpio3";
>  				function = "qup0";
> -				drive-strength = <6>;
> -				bias-disable;
>  			};
>  
>  			qup_spi1_default: qup-spi1-default-state {

  reply	other threads:[~2022-12-22 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 15:13 [PATCH v4 1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name Krzysztof Kozlowski
2022-12-22 15:13 ` [PATCH v4 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Krzysztof Kozlowski
2022-12-22 15:14   ` Konrad Dybcio
2022-12-22 18:52   ` Doug Anderson
2022-12-22 15:13 ` [PATCH v4 3/4] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-12-22 18:53   ` Doug Anderson
2022-12-22 15:13 ` [PATCH v4 4/4] arm64: dts: qcom: sdm845: do not customize SPI0 pin drive/bias Krzysztof Kozlowski
2022-12-22 15:14   ` Konrad Dybcio [this message]
2022-12-22 15:14 ` [PATCH v4 1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name Konrad Dybcio
2023-01-10 16:17 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=697f07b4-87e6-9fa5-4298-82b075a96264@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=caleb@connolly.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=joelselvaraj.oss@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).