From: Luca Weiss <luca@z3ntu.xyz>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: Nia Espera <nespera@igalia.com>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Vinod Koul <vkoul@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
Rob <Me@orbit.sh>, Clayton Craft <clayton@igalia.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Luca Weiss <luca.weiss@fairphone.com>,
~postmarketos/upstreaming@lists.sr.ht,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: sm8350: Fix remoteproc interrupt type
Date: Sat, 21 Oct 2023 21:34:10 +0200 [thread overview]
Message-ID: <6985565.DvuYhMxLoT@z3ntu.xyz> (raw)
In-Reply-To: <ca42af11-7b92-4d07-9b93-367f92c886fe@linaro.org>
On Samstag, 21. Oktober 2023 19:44:20 CEST Konrad Dybcio wrote:
> On 10/19/23 06:06, Manivannan Sadhasivam wrote:
> > On Wed, Oct 18, 2023 at 10:17:15PM +0200, Konrad Dybcio wrote:
> >> On 10/18/23 16:25, Nia Espera wrote:
> >>> In a similar vein to
> >>> https://lore.kernel.org/lkml/20220530080842.37024-3-manivannan.sadhasiva
> >>> m@linaro.org/, the remote processors on sm8350 fail to initialize with
> >>> the 'correct' (i.e., specified in downstream) IRQ type. Change this to
> >>> EDGE_RISING.
> >>>
> >>> Signed-off-by: Nia Espera <nespera@igalia.com>
> >>> ---
> >>
> >> Hm, apparently 8250 and 7180 have the same thing.
> >>
> >> Mani, could you elaborate on this?
> >
> > So the remoteproc driver expects the wdog interrupts to be edge triggered
> > as the rest of the interrupts, but DT specifies them as level triggered.
> > This won't cause any issue during the first instance of the probe as the
> > driver requested trigger will be given precedence. But if the probe
> > defers for some reason and during the next try, request_irq() will fail
> > with error similar to below:
> >
> > irq: type mismatch, failed to map hwirq-x for interrupt-controller@xxxxxx!
> >
> > This error is often confusing and I tried to fix it. But Maz didn't agree
> > with me, so I just ended up fixing the DTs for some platform I have
> > access to.
> >
> > So ideally, DTs of all platforms should be fixed to pass correct trigger
> > type.
> So, this should be edge for all platforms, correct?
I'd believe so, iirc when I looked at the driver it always requests that
interrupt type.
For reference, these are my patches:
sm6350:
https://github.com/z3ntu/linux/commit/0522b7a1b981d80884a785c7e654bb5094ea1bc2
sc7280:
https://github.com/z3ntu/linux/commit/ead1d7b8f5648535b857cfa9250aac2480f00ed3
>
> Konrad
next prev parent reply other threads:[~2023-10-21 19:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:25 [PATCH v2 0/6] support oneplus-lemonade(p) devices Nia Espera
2023-10-18 14:25 ` [PATCH v2 1/6] iio: adc: add smb139x bindings Nia Espera
2023-10-18 14:30 ` Krzysztof Kozlowski
2023-10-18 14:25 ` [PATCH v2 2/6] arm64: dts: qcom: sm8350: Fix DMA0 address Nia Espera
2023-10-18 14:25 ` [PATCH v2 3/6] arm64: dts: qcom: pm8350k: remove hanging whitespace Nia Espera
2023-10-18 14:25 ` [PATCH v2 4/6] arm64: dts: qcom: sm8350: Fix remoteproc interrupt type Nia Espera
2023-10-18 20:17 ` Konrad Dybcio
2023-10-18 20:21 ` Luca Weiss
2023-10-19 4:06 ` Manivannan Sadhasivam
2023-10-21 17:44 ` Konrad Dybcio
2023-10-21 19:34 ` Luca Weiss [this message]
2023-10-23 13:59 ` Konrad Dybcio
2023-10-18 14:25 ` [PATCH v2 5/6] dt-bindings: arm: qcom: add oneplus-lemonade(p) bindings Nia Espera
2023-10-18 14:32 ` Krzysztof Kozlowski
2023-10-18 14:25 ` [PATCH v2 6/6] arm64: dts: qcom: sm8350-lemonade(p): new devices Nia Espera
2023-10-18 14:34 ` Krzysztof Kozlowski
2023-10-18 14:43 ` Nia Espera
2023-10-18 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6985565.DvuYhMxLoT@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=Me@orbit.sh \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=clayton@igalia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nespera@igalia.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox