From: Jinlong Mao <quic_jinlmao@quicinc.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>, Leo Yan <leo.yan@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: coresight: Remove pattern match of ETE node name
Date: Wed, 17 Jan 2024 10:14:35 +0800 [thread overview]
Message-ID: <69875d89-651e-41ff-a1be-385dcbb15108@quicinc.com> (raw)
In-Reply-To: <f616989b-2d84-483d-80c4-d3c6eb97b137@arm.com>
On 1/16/2024 5:33 PM, Suzuki K Poulose wrote:
> On 16/01/2024 06:45, Mao Jinlong wrote:
>> Remove pattern match of ETE node name. Use ete with the number as the
>> name for ete nodes.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>> .../bindings/arm/arm,embedded-trace-extension.yaml | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> index f725e6940993..ed78cc7ae94a 100644
>> ---
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> +++
>> b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> @@ -22,8 +22,6 @@ description: |
>> with any optional connection graph as per the coresight bindings.
>> properties:
>> - $nodename:
>> - pattern: "^ete([0-9a-f]+)$"
>> compatible:
>> items:
>> - const: arm,embedded-trace-extension
>> @@ -55,13 +53,13 @@ examples:
>> # An ETE node without legacy CoreSight connections
>> - |
>> - ete0 {
>> + ete-0 {
>
> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>
Hi Suzuki & Krzysztof ,
If name all the ete nodes' name as 'ete', there will be error below when
build images.
arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:314.6-325.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:327.6-338.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:340.6-351.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:353.6-364.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:366.6-377.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:379.6-390.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
Thanks
Jinlong Mao
>
>
next prev parent reply other threads:[~2024-01-17 2:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 6:45 [PATCH v2 0/2] arm64: dts: qcom: Add coresight nodes for sm8450 Mao Jinlong
2024-01-16 6:45 ` [PATCH v2 1/2] dt-bindings: arm: coresight: Remove pattern match of ETE node name Mao Jinlong
2024-01-16 7:28 ` Krzysztof Kozlowski
2024-01-16 9:33 ` Suzuki K Poulose
2024-01-17 2:14 ` Jinlong Mao [this message]
2024-01-17 7:40 ` Krzysztof Kozlowski
2024-01-17 7:49 ` Jinlong Mao
2024-01-17 7:53 ` Krzysztof Kozlowski
2024-01-17 7:55 ` Jinlong Mao
2024-01-16 6:45 ` [PATCH v2 2/2] arm64: dts: qcom: Add coresight nodes for sm8450 Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69875d89-651e-41ff-a1be-385dcbb15108@quicinc.com \
--to=quic_jinlmao@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox