From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
bjorn.andersson@linaro.org, agross@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions
Date: Tue, 12 Jul 2022 18:13:01 +0200 [thread overview]
Message-ID: <6acfc783-149d-dcdb-a033-ca5b2c1ee81f@somainline.org> (raw)
In-Reply-To: <20220712125922.3461675-4-bryan.odonoghue@linaro.org>
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> The Venus clock frequencies are a copy/paste error from msm8916. Looking
> at the original clock-gcc-8936.c ftbl_gcc_venus0_vcodec0_clk defines we
> have:
>
> - 133 MHz
> - 200 MHz
> - 266 MHz
>
> These values are born out by the relevant qualcomm documentation for the
> msm8936/msm8939 Venus core performance levels.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 6a3e2326c72a3..2aad40dbef8e6 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1824,9 +1824,9 @@ static struct clk_branch gcc_ultaudio_pcnoc_sway_clk = {
> };
>
> static const struct freq_tbl ftbl_gcc_venus0_vcodec0_clk[] = {
> - F(100000000, P_GPLL0, 8, 0, 0),
> - F(160000000, P_GPLL0, 5, 0, 0),
> - F(228570000, P_GPLL0, 3.5, 0, 0),
> + F(133330000, P_GPLL0, 6, 0, 0),
> + F(200000000, P_GPLL0, 4, 0, 0),
> + F(266670000, P_GPLL0, 3, 0, 0),
> { }
> };
>
next prev parent reply other threads:[~2022-07-12 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
2022-07-12 16:11 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock Bryan O'Donoghue
2022-07-12 16:12 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio [this message]
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP " Bryan O'Donoghue
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system " Bryan O'Donoghue
2022-07-12 16:18 ` Konrad Dybcio
2022-07-12 16:19 ` Bryan O'Donoghue
2022-07-19 4:48 ` [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6acfc783-149d-dcdb-a033-ca5b2c1ee81f@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox