From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71444C6FD1D for ; Tue, 21 Mar 2023 15:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbjCUPWc (ORCPT ); Tue, 21 Mar 2023 11:22:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231591AbjCUPWb (ORCPT ); Tue, 21 Mar 2023 11:22:31 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B1C28D32 for ; Tue, 21 Mar 2023 08:22:01 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id a32so15889811ljr.9 for ; Tue, 21 Mar 2023 08:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679412117; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=56s6rLJdjpBDM1hl6x5LvM4qWyj2EYIhrrSbFYI0uDM=; b=zqwm8vcih1yhUl8T9pyw3CAI+LBPWgmIxn/gIBf4VHx6uF0/DWXPVGKv5yDU3R3ovK BQm8nTeYnFUOhR6DOdYxo7TULlVccnBzadotgYiQ7UA0dp/kVXokvEU3JCeWWTT7SlAh GavUCO8Gx/Jrvblt/zg8q7F+2y4nuJGM8itRxRQ9icjjVq5Oi1KZbPONboGTGbmvO35O MwW3NpIa/EsVyM14w+v5PmQTeajuMfJERRHZMV2D1yPSkoKs/Ra3VQtkvVkk1esqmrXE c5h1NoA4L7IZtXSqjnkPrfnqbfBA/DdMFFgTBlndo0YRxQhm+ZCK11of7jXpaoDMGSfa XG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679412117; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=56s6rLJdjpBDM1hl6x5LvM4qWyj2EYIhrrSbFYI0uDM=; b=J6v3IXgk/iwg8WoE1bFrWpYDKiIw98MVEPx9prUYpahHnGGfMIlZO7HfG7OfiF8ED5 WP2aPk5Ohls/t49jhYHQ7GrPsZVacW+sl/rdi1OHfjmoMW7DXjMknKZZtp86uPvzAzTZ 0ncb4ZC8FWCT7b3L84DBhOIDNafi/DN8FCzN34NEQICJyPP7YhmVoXJ1KHLuvKqyByRP GKRNlHuBysDDJBoKZozj4BtGN/G5YaTswRrAGqB9e1HNOOs8kt83ZsAM84F3MmM8EZTY v+3YeGz7ZVW0fUPy9IcPXiR1RoiK7S7CyjkDBFTkOIrYB8IOo6uphMtnHOWLgBAPnmg7 U4TQ== X-Gm-Message-State: AO0yUKUL2TXsFXxjqPOnprnvEiZOAYyw9Ce2srK/YhGQO3NdhtdzpVGG YROSaMwpyjlmv3b1nndlo5Ey9Y/KGIbF0TaupGwhJe2Z X-Google-Smtp-Source: AK7set8XMA5X4kDNh9wjuk2eLvIAc4k4TD2f3llxCFuB71vUCBzGOc+i1nk0t8977tyEMaoTolG90g== X-Received: by 2002:a2e:b008:0:b0:29b:d35c:f0a4 with SMTP id y8-20020a2eb008000000b0029bd35cf0a4mr1030021ljk.37.1679412117603; Tue, 21 Mar 2023 08:21:57 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p1-20020a2e7401000000b0029353caa593sm2291789ljc.5.2023.03.21.08.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 08:21:56 -0700 (PDT) Message-ID: <6b2f4d0d-ba39-dd2b-e41e-b5accb4df1a2@linaro.org> Date: Tue, 21 Mar 2023 17:21:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 00/10] drm/msm: fix bind error handling Content-Language: en-GB To: Johan Hovold , Rob Clark , Abhinav Kumar Cc: Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230306100722.28485-1-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/03/2023 15:02, Johan Hovold wrote: > On Mon, Mar 06, 2023 at 11:07:12AM +0100, Johan Hovold wrote: >> I had reasons to look closer at the MSM DRM driver error handling and >> realised that it had suffered from a fair amount of bit rot over the >> years. >> >> Unfortunately, I started fixing this in my 6.2 branch and failed to >> notice two partial and, as it turned out, broken attempts to address >> this that are now in 6.3-rc1. >> >> Instead of trying to salvage this incrementally, I'm reverting the two >> broken commits so that clean and backportable fixes can be added in >> their place. >> >> Included are also two related cleanups. > > Any further comments to these patches (except for 9/10, which should be > dropped)? > > As the patches being reverted here were first added in 6.3-rc1 there is > still time to get this into 6.3-rc (e.g. before AUTOSEL starts trying to > backport them). I will take a look at the patches. Additional question, as you have been looking into this area. We have plenty of code which is only called under the `if (kms)` condition. Could you hopefully move these parts to separate functions, so that the error handling is also simpler? If not, I'll put this to my todo list, but it might take some time before I have time for that. > > Johan > >> Johan Hovold (10): >> Revert "drm/msm: Add missing check and destroy for >> alloc_ordered_workqueue" >> Revert "drm/msm: Fix failure paths in msm_drm_init()" >> drm/msm: fix NULL-deref on snapshot tear down >> drm/msm: fix NULL-deref on irq uninstall >> drm/msm: fix drm device leak on bind errors >> drm/msm: fix vram leak on bind errors >> drm/msm: fix missing wq allocation error handling >> drm/msm: fix workqueue leak on bind errors >> drm/msm: use drmm_mode_config_init() >> drm/msm: move include directive >> >> drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 3 - >> drivers/gpu/drm/msm/msm_drv.c | 67 +++++++++++++------- >> 2 files changed, 44 insertions(+), 26 deletions(-) -- With best wishes Dmitry