From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C378C00144 for ; Mon, 1 Aug 2022 20:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234645AbiHAUM5 (ORCPT ); Mon, 1 Aug 2022 16:12:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234725AbiHAUMH (ORCPT ); Mon, 1 Aug 2022 16:12:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62BF33DF19; Mon, 1 Aug 2022 13:12:04 -0700 (PDT) Received: from [192.168.2.145] (109-252-119-232.nat.spd-mgts.ru [109.252.119.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7244A6601BA5; Mon, 1 Aug 2022 21:12:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1659384722; bh=Ww02GIODxPF1eQWZ6lWAqTXwqaa5UD98G24csRrYi5c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cyu+trJyxvIzAtsbdH+eRaHNA5ReSc+WTnNm85JhbbY69TX86XOdfKFz6K6Bgtt46 V3Rj9gR4f7vJWIccBBNOEfRNZsgUNDlCdSLbwT61J+kMBlGmqqX6FTNgaPsV1TZd28 ns4xMUMxmjX0rjQf8hjiyfknQjYqDOrMwXXu71G73LR64iXE1lNPNnN1sVRtp6VgCX Ys4oEw31upAURNwAx0VCNqt4XCees5Rcr7up0uXnX1WfGwn+HijQaAAHYTN0mj6GHh 7z79MZKBEZsa0ciGtS38BnXqmSgTgk6ikSpSREhuugd27TAEXOxtDBELcx+t7M74U5 gtRZNHM1r+SXg== Message-ID: <6b35b912-68e5-e722-0b5a-0f7bd06c22c2@collabora.com> Date: Mon, 1 Aug 2022 23:11:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper Content-Language: en-US To: Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Daniel Vetter , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , David Airlie , open list References: <20220726175043.1027731-1-robdclark@gmail.com> <20220726175043.1027731-10-robdclark@gmail.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 8/1/22 23:00, Rob Clark wrote: > On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko > wrote: >> >> On 7/26/22 20:50, Rob Clark wrote: >>> +/** >>> + * drm_gem_lru_remove - remove object from whatever LRU it is in >>> + * >>> + * If the object is currently in any LRU, remove it. >>> + * >>> + * @obj: The GEM object to remove from current LRU >>> + */ >>> +void >>> +drm_gem_lru_remove(struct drm_gem_object *obj) >>> +{ >>> + struct drm_gem_lru *lru = obj->lru; >>> + >>> + if (!lru) >>> + return; >>> + >>> + mutex_lock(lru->lock); >>> + lru_remove(obj); >>> + mutex_unlock(lru->lock); >>> +} >>> +EXPORT_SYMBOL(drm_gem_lru_remove); >> >> I made a preliminary port of the DRM-SHMEM shrinker on top of the the >> latest version of dma-buf locking convention and yours LRU patches. It >> all works good, the only thing that is missing for the DRM-SHMEM >> shrinker is the drm_gem_lru_remove_locked(). >> >> What about to add a locked variant of drm_gem_lru_remove()? > > Sounds fine to me.. the only reason it didn't exist yet was because it > wasn't needed yet.. There is no use for the drm_gem_lru_move_tail_locked() as well, you're not using it in the MSM driver. Hence I thought it might be good to add the drm_gem_lru_remove_locked(), or maybe the drm_gem_lru_move_tail_locked() should be dropped then? > I can respin w/ an addition of a _locked() version, or you can add it > on top in your patchset. Either is fine by me The either option is fine by me too. If you'll keep the unused drm_gem_lru_move_tail_locked(), then will be nice to add drm_gem_lru_remove_locked(). -- Best regards, Dmitry