From: jeyr@codeaurora.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org,
linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH] misc: fastrpc: fix improper packet size calculation
Date: Mon, 20 Sep 2021 15:01:07 +0530 [thread overview]
Message-ID: <6b3663fcadfdc5bc0cc82eedce533905@codeaurora.org> (raw)
In-Reply-To: <YUhPlj8eeszBNZTE@kroah.com>
On 2021-09-20 14:38, Greg KH wrote:
> On Mon, Sep 20, 2021 at 01:45:31PM +0530, Jeya R wrote:
>> The buffer list is sorted and this is not being
>> considered while calculating packet size. This
>> would lead to improper copy length calculation
>> for non-dmaheap buffers which would eventually
>> cause sending improper buffers to DSP.
>
> You do have the full 72 columns to use :)
Thanks, will update the commit message considering this.
>
>>
>> Signed-off-by: Jeya R <jeyr@codeaurora.org>
>> ---
>> drivers/misc/fastrpc.c | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> What commit does this fix?
>
> thanks,
>
> greg k-h
Payload calculation function was modified to handle buffer overlapping
calculation in this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/misc/fastrpc.c?h=v5.15-rc2&id=25e8dfb83cda0a123bb1e091d6c3599cde050d76
Here during buffer overlap calculation, the buffer list is getting
sorted. This needs to be considered during the calculation of payload
size also by using unsorted buffer index "raix".
next prev parent reply other threads:[~2021-09-20 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 8:15 [PATCH] misc: fastrpc: fix improper packet size calculation Jeya R
2021-09-20 9:08 ` Greg KH
2021-09-20 9:31 ` jeyr [this message]
2021-09-20 9:46 ` Greg KH
2021-09-20 12:21 ` Srinivas Kandagatla
-- strict thread matches above, loose matches on Subject: below --
2021-09-21 10:35 Jeya R
2021-09-21 10:39 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b3663fcadfdc5bc0cc82eedce533905@codeaurora.org \
--to=jeyr@codeaurora.org \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).