From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA06C433FE for ; Sun, 20 Nov 2022 12:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbiKTMTr (ORCPT ); Sun, 20 Nov 2022 07:19:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiKTMTo (ORCPT ); Sun, 20 Nov 2022 07:19:44 -0500 Received: from smtp.smtpout.orange.fr (smtp-20.smtpout.orange.fr [80.12.242.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0A363E0A9 for ; Sun, 20 Nov 2022 04:19:42 -0800 (PST) Received: from [192.168.1.18] ([86.243.100.34]) by smtp.orange.fr with ESMTPA id wjIPoqSZxFUJ3wjIPoqDBa; Sun, 20 Nov 2022 13:19:39 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 20 Nov 2022 13:19:39 +0100 X-ME-IP: 86.243.100.34 Message-ID: <6b68b7c2-e070-0a88-35ee-2060dcbdee91@wanadoo.fr> Date: Sun, 20 Nov 2022 13:19:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 3/3] interconnect: qcom: Add QDU1000/QRU1000 interconnect driver To: Melody Olvera , Andy Gross , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski Cc: Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118182245.31035-1-quic_molvera@quicinc.com> <20221118182245.31035-4-quic_molvera@quicinc.com> Content-Language: fr From: Christophe JAILLET In-Reply-To: <20221118182245.31035-4-quic_molvera@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Le 18/11/2022 à 19:22, Melody Olvera a écrit : > Add interconnect provider driver for Qualcomm QDU1000 and QRU1000 > platforms. > > Signed-off-by: Melody Olvera > --- > drivers/interconnect/qcom/Kconfig | 9 + > drivers/interconnect/qcom/Makefile | 2 + > drivers/interconnect/qcom/qdu1000.c | 1079 +++++++++++++++++++++++++++ > drivers/interconnect/qcom/qdu1000.h | 95 +++ > 4 files changed, 1185 insertions(+) > create mode 100644 drivers/interconnect/qcom/qdu1000.c > create mode 100644 drivers/interconnect/qcom/qdu1000.h > [...] > +static int qnoc_probe(struct platform_device *pdev) > +{ > + int ret; > + > + ret = qcom_icc_rpmh_probe(pdev); > + if (ret) > + dev_err(&pdev->dev, "failed to register ICC provider\n"); > + > + return ret; > +} > + > +static int qnoc_remove(struct platform_device *pdev) > +{ > + struct qcom_icc_provider *qp = platform_get_drvdata(pdev); > + > + icc_nodes_remove(&qp->provider); > + icc_provider_del(&qp->provider); qcom_icc_rpmh_remove()? (more future proof, less verbose and more consistent with qcom_icc_rpmh_probe() in the probe) CJ > + > + return 0; > +} > + > +static const struct of_device_id qnoc_of_match[] = { > + { .compatible = "qcom,qdu1000-clk-virt", > + .data = &qdu1000_clk_virt > + }, > + { .compatible = "qcom,qdu1000-gem-noc", > + .data = &qdu1000_gem_noc > + }, > + { .compatible = "qcom,qdu1000-mc-virt", > + .data = &qdu1000_mc_virt > + }, > + { .compatible = "qcom,qdu1000-system-noc", > + .data = &qdu1000_system_noc > + }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, qnoc_of_match); > + > +static struct platform_driver qnoc_driver = { > + .probe = qnoc_probe, > + .remove = qnoc_remove, > + .driver = { > + .name = "qnoc-qdu1000", > + .of_match_table = qnoc_of_match, > + }, > +}; [...]