From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Subject: Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform
Date: Wed, 29 Oct 2025 09:02:18 +0100 [thread overview]
Message-ID: <6b76d7d9-4f82-4eec-880c-3da2386971a3@kernel.org> (raw)
In-Reply-To: <20251024151521.2365845-4-krishna.kurapati@oss.qualcomm.com>
On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>
> Enable USB support on SM8750 QRD variant. The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
>
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>
> status = "okay";
> };
> +
> +&usb_1 {
Still wrongly ordered. Please follow DTS coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 8:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 15:15 [PATCH v9 0/3] Introduce USB DT support for SM8750 Krishna Kurapati
2025-10-24 15:15 ` [PATCH v9 1/3] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs Krishna Kurapati
2025-10-28 21:14 ` Dmitry Baryshkov
2025-10-31 7:47 ` Krishna Kurapati PSSNV
2025-10-24 15:15 ` [PATCH v9 2/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform Krishna Kurapati
2025-10-28 21:15 ` Dmitry Baryshkov
2025-10-29 15:50 ` Krishna Kurapati PSSNV
2025-10-29 16:34 ` Bjorn Andersson
2025-10-29 16:42 ` Krishna Kurapati PSSNV
2025-10-29 17:09 ` Bjorn Andersson
2025-10-29 8:02 ` Krzysztof Kozlowski
2025-10-24 15:15 ` [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform Krishna Kurapati
2025-10-29 8:02 ` Krzysztof Kozlowski [this message]
2025-10-29 8:12 ` Krzysztof Kozlowski
2025-10-29 8:07 ` Krzysztof Kozlowski
2025-10-29 11:42 ` Krishna Kurapati PSSNV
2025-10-29 12:05 ` Krzysztof Kozlowski
2025-10-29 12:30 ` Krishna Kurapati PSSNV
2025-10-29 13:06 ` Dmitry Baryshkov
2025-10-31 7:48 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b76d7d9-4f82-4eec-880c-3da2386971a3@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox