From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C43C41513 for ; Sat, 12 Aug 2023 01:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236940AbjHLBwG (ORCPT ); Fri, 11 Aug 2023 21:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjHLBwF (ORCPT ); Fri, 11 Aug 2023 21:52:05 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3147230DB; Fri, 11 Aug 2023 18:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691805125; x=1723341125; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=eUUEU5LEbeviw+Tdt86pjS6LMPIps7FsAMnnYjoKRyE=; b=ALoadXrEpsalpeiuSu9RKA/c948YvWngPAJcKt9dDbiufhtPybSTIPgX jKL3fh0HdzXGKCpor6UlMUm4Ge/F7c5wCvnaGxUB3GRB1153PCxxOOkGP z+wTH98R1kCW3WM5u0lvwQWyuScLgD382kWz6XmkAH2gutM/C5ehAvw3Y 5a1C1Qq3IWXcg28kG4+n0eltI1jKBukeTib3JphSEAPOUCIuvRXSrRH3E ERwIGnOep/BVAhw+mWXdxJOT5QZRUoHYhlK6teZV0437w29+Wz/DXQpXz UcFz+dNMg8m+8XLYCtMFCj9cGZ/aA+3JsSBwODDVi569TitDmi/Mf6YKJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10799"; a="352121573" X-IronPort-AV: E=Sophos;i="6.01,167,1684825200"; d="scan'208";a="352121573" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 18:52:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="876364144" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.215.79]) ([10.254.215.79]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 18:51:57 -0700 Message-ID: <6bb11581-4b24-1e54-d3f6-674cde3e4539@linux.intel.com> Date: Sat, 12 Aug 2023 09:51:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 06/25] iommu/tegra-gart: Remove tegra-gart Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <6-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <6-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2023/8/3 8:07, Jason Gunthorpe wrote: > Thierry says this is not used anymore, and doesn't think it makes sense as > an iommu driver. The HW it supports is about 10 years old now and newer HW > uses different IOMMU drivers. > > As this is the only driver with a GART approach, and it doesn't really > meet the driver expectations from the IOMMU core, let's just remove it > so we don't have to think about how to make it fit in. > > It has a number of identified problems: > - The assignment of iommu_groups doesn't match the HW behavior > > - It claims to have an UNMANAGED domain but it is really an IDENTITY > domain with a translation aperture. This is inconsistent with the core > expectation for security sensitive operations > > - It doesn't implement a SW page table under struct iommu_domain so > * It can't accept a map until the domain is attached > * It forgets about all maps after the domain is detached > * It doesn't clear the HW of maps once the domain is detached > (made worse by having the wrong groups) > > Cc: Thierry Reding > Cc: Dmitry Osipenko > Acked-by: Thierry Reding > Signed-off-by: Jason Gunthorpe > --- > arch/arm/configs/multi_v7_defconfig | 1 - > arch/arm/configs/tegra_defconfig | 1 - > drivers/iommu/Kconfig | 11 - > drivers/iommu/Makefile | 1 - > drivers/iommu/tegra-gart.c | 371 ---------------------------- > drivers/memory/tegra/mc.c | 34 --- > drivers/memory/tegra/tegra20.c | 28 --- > include/soc/tegra/mc.h | 26 -- > 8 files changed, 473 deletions(-) > delete mode 100644 drivers/iommu/tegra-gart.c Reviewed-by: Lu Baolu Best regards, baolu