From: Bryan O'Donoghue <bod@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver
Date: Fri, 27 Mar 2026 22:11:21 +0000 [thread overview]
Message-ID: <6c52f934-1b08-4e93-a753-d4c90e827f1f@kernel.org> (raw)
In-Reply-To: <62zcubxembr6iat4d7n3o7aecqtx3ne2a42ilxfoap65oaefhh@mecahghgrwrf>
On 27/03/2026 20:54, Dmitry Baryshkov wrote:
> I think, I've left similar feedback already. Please rework a single
> structure-less table into generic and per-lane configuration. It doesn't
> make sense to repeat the same configuration N times, just with the
> different offset.
If you remember you also said that was fine for a follow-on series after
merging, and you asked for a commit log to that effect.
i.e.
"The register init sequence table is imported verbatim from the existing
CAMSS csiphy driver. A follow-up series will rework the table to extract
the repetitive per-lane pattern into a loop."
---
bod
next prev parent reply other threads:[~2026-03-27 22:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 1:04 [PATCH v5 0/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-26 1:04 ` [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Bryan O'Donoghue
2026-03-26 1:46 ` Vladimir Zapolskiy
2026-03-26 2:03 ` Bryan O'Donoghue
2026-03-26 10:28 ` Vladimir Zapolskiy
2026-03-26 14:42 ` Bryan O'Donoghue
2026-03-26 14:49 ` Vladimir Zapolskiy
2026-03-27 1:03 ` Bryan O'Donoghue
2026-03-27 7:54 ` Vladimir Zapolskiy
2026-03-27 20:51 ` Dmitry Baryshkov
2026-03-27 22:29 ` Bryan O'Donoghue
2026-03-27 23:12 ` Vladimir Zapolskiy
2026-03-27 23:23 ` Dmitry Baryshkov
2026-03-27 23:40 ` Bryan O'Donoghue
2026-03-29 10:54 ` Dmitry Baryshkov
2026-03-30 9:46 ` Konrad Dybcio
2026-03-28 0:41 ` Vladimir Zapolskiy
2026-03-26 2:31 ` Rob Herring (Arm)
2026-03-27 10:07 ` Konrad Dybcio
2026-03-27 10:10 ` Konrad Dybcio
2026-03-27 14:38 ` Bryan O'Donoghue
2026-03-27 15:28 ` Neil Armstrong
2026-03-27 17:42 ` Bryan O'Donoghue
2026-03-30 7:49 ` Neil Armstrong
2026-03-30 9:02 ` Bryan O'Donoghue
2026-03-30 9:17 ` Neil Armstrong
2026-03-30 9:25 ` Bryan O'Donoghue
2026-03-30 11:34 ` Konrad Dybcio
2026-03-30 11:41 ` Bryan O'Donoghue
2026-04-15 9:41 ` Konrad Dybcio
2026-03-30 11:49 ` Dmitry Baryshkov
2026-03-30 12:03 ` Bryan O'Donoghue
2026-03-30 10:39 ` Vladimir Zapolskiy
2026-03-26 1:04 ` [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-27 2:23 ` Hangxiang Ma
2026-03-27 10:07 ` Konrad Dybcio
2026-03-27 20:57 ` Dmitry Baryshkov
2026-03-27 20:54 ` Dmitry Baryshkov
2026-03-27 22:11 ` Bryan O'Donoghue [this message]
2026-03-27 22:30 ` Dmitry Baryshkov
2026-04-02 2:22 ` Vijay Kumar Tumati
2026-04-06 14:28 ` Abel Vesa
2026-04-06 15:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c52f934-1b08-4e93-a753-d4c90e827f1f@kernel.org \
--to=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox