Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dylan Van Assche <me@dylanvanassche.be>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dts: arm64: qcom: sdm845: add SLPI remoteproc
Date: Fri, 31 Mar 2023 11:05:48 +0200	[thread overview]
Message-ID: <6cab9930-1222-e715-be1d-ffdc44713aa8@linaro.org> (raw)
In-Reply-To: <20230330165322.118279-2-me@dylanvanassche.be>

On 30/03/2023 18:53, Dylan Van Assche wrote:
> Add the SLPI remoteproc to the SDM845 Qualcomm SoC which is responsible
> for exposing the sensors connected to the SoC. The SLPI communicates
> over GLink edge 'dsps' and is similar to other DSPs e.g. ADSP or CDSP.
> This patch allows the SLPI to boot and expose itself over QRTR as
> service 400.
> 
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 36 ++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 2f32179c7d1b..3b547cb7aeb8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -3311,6 +3311,42 @@ glink-edge {
>  			};
>  		};
>  
> +		slpi_pas: remoteproc@5c00000 {

This does not look like correct place. Are you sure you followed the
order by unit address?



Best regards,
Krzysztof


  reply	other threads:[~2023-03-31  9:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 16:53 [PATCH v3 0/4] dts: qcom: arm64: sdm845: SLPI DSP enablement Dylan Van Assche
2023-03-30 16:53 ` [PATCH v3 1/4] dts: arm64: qcom: sdm845: add SLPI remoteproc Dylan Van Assche
2023-03-31  9:05   ` Krzysztof Kozlowski [this message]
2023-03-31  9:27     ` Dylan Van Assche
2023-03-30 16:53 ` [PATCH v3 2/4] dts: arm64: qcom: sdm845: add SLPI FastRPC support Dylan Van Assche
2023-03-31  2:03   ` Konrad Dybcio
2023-03-31  9:36     ` Dylan Van Assche
2023-03-31 12:20       ` Konrad Dybcio
2023-03-31 13:14         ` Dylan Van Assche
2023-03-31 16:58           ` Konrad Dybcio
2023-03-30 16:53 ` [PATCH v3 3/4] dts: arm64: qcom: sdm845-oneplus: enable SLPI Dylan Van Assche
2023-03-31  1:59   ` Konrad Dybcio
2023-03-31  9:04   ` Krzysztof Kozlowski
2023-03-30 16:53 ` [PATCH v3 4/4] dts: arm64: qcom: sdm845-shift-axolotl: " Dylan Van Assche
2023-03-31  1:59   ` Konrad Dybcio
2023-03-31  9:04   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cab9930-1222-e715-be1d-ffdc44713aa8@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@dylanvanassche.be \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox