From: Sibi Sankar <sibis@codeaurora.org>
To: trix@redhat.com
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: initialize local variable
Date: Tue, 25 Aug 2020 12:57:47 +0530 [thread overview]
Message-ID: <6cfe9537e007bb74a481a4caba2a4123@codeaurora.org> (raw)
In-Reply-To: <20200819184637.15648-1-trix@redhat.com>
On 2020-08-20 00:16, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this problem
>
> pdr_interface.c:596:6: warning: Branch condition evaluates
> to a garbage value
> if (!req.service_path[0])
> ^~~~~~~~~~~~~~~~~~~~
>
> This check that req.service_path was set in an earlier loop.
> However req is a stack variable and its initial value
> is undefined.
>
> So initialize req to 0.
>
> Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart
> helpers")
>
Tom,
Thanks for the patch.
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/soc/qcom/pdr_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/pdr_interface.c
> b/drivers/soc/qcom/pdr_interface.c
> index 088dc99f77f3..f63135c09667 100644
> --- a/drivers/soc/qcom/pdr_interface.c
> +++ b/drivers/soc/qcom/pdr_interface.c
> @@ -569,7 +569,7 @@ EXPORT_SYMBOL(pdr_add_lookup);
> int pdr_restart_pd(struct pdr_handle *pdr, struct pdr_service *pds)
> {
> struct servreg_restart_pd_resp resp;
> - struct servreg_restart_pd_req req;
> + struct servreg_restart_pd_req req = { 0 };
> struct sockaddr_qrtr addr;
> struct pdr_service *tmp;
> struct qmi_txn txn;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-08-25 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 18:46 [PATCH] soc: qcom: initialize local variable trix
2020-08-25 7:27 ` Sibi Sankar [this message]
2020-11-24 4:10 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cfe9537e007bb74a481a4caba2a4123@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).