Re: [PATCH v2 04/13] dt-bindings: media: qcom,glymur-iris: Add glymur video codec

Krzysztof Kozlowski
2026-04-25T10:41:06Z

On 25/04/2026 11:56, Vishnu Reddy wrote:
>
> On 4/24/2026 10:39 PM, Krzysztof Kozlowski wrote:
>> On 23/04/2026 15:29, Vishnu Reddy wrote:
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - clocks
>>> + - clock-names
>>> + - dma-coherent
>>> + - interconnects
>>> + - interconnect-names
>>> + - interrupts
>>> + - iommus
>>> + - memory-region
>>> + - power-domains
>>> + - power-domain-names
>>> + - resets
>>> + - reset-names
>>> +
>>> +unevaluatedProperties: false
>>> +
>> I think I commented around here but probably not specific enough. You
>> miss here either reference to venus or usage of additionalProperties
>> instead of unevaluatedProperties.
>>
>> If you intend not to use qcom,venus-common.yaml, then explain WHY in
>> commit msg and switch to additionalProperties: false.
>>
>> Otherwise, you miss $ref.
>>
>> Rest looked good.
>
> Iris glymur platform have more clocks and power domains, which exceed
> the maxItems limits defined in qcom,venus-common.yaml. Inheriting from
> it would cause dt-schema validation failures, so I have chosen not to
> reference it.

Instead, you should extend the common schema. It's already flexible, so
what is the problem here?

You then need to duplicate all of the common properties...

Best regards,
Krzysztof