From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D4FB1EDA3A; Thu, 20 Mar 2025 07:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742455308; cv=none; b=Qqm7Bmn3nN2nWgHKX89MGOs6BcANIU6iNG593kL2Ypb2qBi0quXSYFOpb82GFtjcjb4TLyNr62q7q9HdVeGZzyEnA97+T6PTmUqr9qYiQK/QsPevlJ1gj9XVogOvyl1forSCprIipEqoeuctOw6z5x9asxcIQFiB7WxKLBj8ksY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742455308; c=relaxed/simple; bh=LPFNRfq1ARkgilTcOqF5DTW8sEDkK6LkNiXxUH933bg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OTcKNNXIE/N44Z4MRvyBwtiyi/+J2P4ZC7XN2VbEDK0JZxfE7y+JW6PcOXbwxvxKYjF8KuhZQIw0YlFEdNdqo6iIhaQ2WU9n8sHnzUvKnpdo6fR866hOvBf46nPaLE1q6KGOQ+ODQ8a/4sQIeFbv/FiNQaiwoV+xx/hVk9P7elM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PQ+pWIg3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PQ+pWIg3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA2D8C4CEDD; Thu, 20 Mar 2025 07:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742455308; bh=LPFNRfq1ARkgilTcOqF5DTW8sEDkK6LkNiXxUH933bg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PQ+pWIg3kVhN5Omh9Nx1hntZCFqbooR87jFiN8wUn69vxM3n2CNdZPfl/N9wnaWzg K62hXYU0q/wwCGVaEFm7zC2DgtIMFtqidwBYMqpXtwtjr3adtv2sLh2ekt7G7m0zHj izsFAVHwLBgGhgax2fJL57J9f6PUvSofjaAL0s8U0ysOz4jrMBTrMRXVyeJ1aaOEfU 69t/6UDyRL8EgWhRmVa/4p61hL+pPlCoKW6vtQDxhaNuPWNospy2VNvO3JFo48vh7s L5D1ZFbpg/jzfUOlJdr5GoVfnJObhzbCwymoFaM34MMbgzjn99j75nsIhNEBkECT5t Q/cotZaFZm7IA== Message-ID: <6d946f17-704a-4f5e-8e1e-c05dcbb55d70@kernel.org> Date: Thu, 20 Mar 2025 08:21:41 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] wifi: ath12k: properly set single_chip_mlo_supp to true in ath12k_core_alloc() To: Dmitry Baryshkov Cc: Baochen Qiang , neil.armstrong@linaro.org, Vasanthakumar Thiagarajan , Jeff Johnson , Johannes Berg , Jeff Johnson , Aditya Kumar Singh , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250303-topic-ath12k-fix-crash-v1-1-f871d4e4d968@linaro.org> <24b2f1f8-97bd-423a-acbd-9a5cd45e4a40@oss.qualcomm.com> <7901d7f0-d6d0-4bf3-89ad-d710e88477b7@linaro.org> <7b4b598f-bc13-aa4b-8677-71477e1f5434@quicinc.com> <38cd738c-1a2a-4382-80f8-d57feb7c829d@quicinc.com> <91a5a1f7-6eef-4ea0-bcde-350640984a7b@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19/03/2025 12:25, Dmitry Baryshkov wrote: > On Wed, Mar 19, 2025 at 11:29:18AM +0100, Krzysztof Kozlowski wrote: >> On 19/03/2025 10:46, Baochen Qiang wrote: >>> >>> >>> On 3/19/2025 5:12 PM, neil.armstrong@linaro.org wrote: >>>> Hi, >>>> >>>> On 19/03/2025 10:06, Vasanthakumar Thiagarajan wrote: >>>>> >>>>> >>>>> On 3/19/2025 1:34 PM, Neil Armstrong wrote: >>>>>> On 18/03/2025 17:35, Jeff Johnson wrote: >>>>>>> On 3/3/2025 7:00 AM, Neil Armstrong wrote: >>>>>>>> In commit 46d16f7e1d14 ("wifi: ath12k: rename mlo_capable_flags to >>>>>>>> single_chip_mlo_supp") >>>>>>>> the line: >>>>>>>>     ab->mlo_capable_flags = ATH12K_INTRA_DEVICE_MLO_SUPPORT; >>>>>>>> was incorrectly updated to: >>>>>>>>     ab->single_chip_mlo_supp = false; >>>>>>>> leading to always disabling INTRA_DEVICE_MLO even if the device supports it. >>>>>>>> >>>>>>>> The firmware "WLAN.HMT.1.1.c5-00156-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1" >>>>>>>> crashes on driver initialization with: >>>>>>>>   ath12k_pci 0000:01:00.0: chip_id 0x2 chip_family 0x4 board_id 0x3d soc_id 0x40170200 >>>>>>>>   ath12k_pci 0000:01:00.0: fw_version 0x110f009c fw_build_timestamp 2024-05-30 11:35 >>>>>>>> fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.1.c5-00156- >>>>>>>> QCAHMTSWPL_V1.0_V2.0_SILICONZ-1 >>> >>> this FW version is not upstream yet, why are you testing with it? >>> >>> Generally we only support upstrmea driver + upstream FW. >> FW does not have to be upstream. We work, here in upstream, with all >> sort of vendors and all sorts of devices, for which vendors might not >> send yet their FW or we are unclear about licensing rules. > > If you are working with non-supported firmware, then, basically, you are > on your own. I think you'd get the same response from any other vendor > shipping firmware files. Consider reporting an issue to i915 or amdgpu > driver _and_ stating that you are using some non-standard firmware files > that were not provided to you by the corresponding team. FW extracted from whatever-we-got-there is entire history of all WiFi drivers... And no one asked here for support. Best regards, Krzysztof