From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: align LED node names with dtschema
Date: Fri, 25 Nov 2022 15:55:26 +0100 [thread overview]
Message-ID: <6e1af6bf-d10c-c70b-e23f-690fb9242e4c@linaro.org> (raw)
In-Reply-To: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org>
On 25.11.2022 15:42, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
>
> qcom/msm8998-oneplus-cheeseburger.dtb: leds: 'button-backlight' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> qcom/sc7180-trogdor-coachz-r1.dtb: pwmleds: 'keyboard-backlight' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> index b951f98d1b7b..9fb1fb9b8529 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> @@ -22,7 +22,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&button_backlight_default>;
>
> - button-backlight {
> + led-keypad-backlight {
> gpios = <&pmi8998_gpio 5 GPIO_ACTIVE_HIGH>;
> color = <LED_COLOR_ID_WHITE>;
> function = LED_FUNCTION_KBD_BACKLIGHT;
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 65601bea0797..74a90948db6b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -354,7 +354,7 @@ max98360a: audio-codec-0 {
>
> pwmleds {
> compatible = "pwm-leds";
> - keyboard_backlight: keyboard-backlight {
> + keyboard_backlight: led-0 {
> status = "disabled";
> label = "cros_ec::kbd_backlight";
> function = LED_FUNCTION_KBD_BACKLIGHT;
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 448da9794722..27f479ff9d80 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -307,7 +307,7 @@ max98360a: audio-codec-0 {
> pwmleds: pwmleds {
> compatible = "pwm-leds";
> status = "disabled";
> - keyboard_backlight: keyboard-backlight {
> + keyboard_backlight: led-0 {
> label = "cros_ec::kbd_backlight";
> function = LED_FUNCTION_KBD_BACKLIGHT;
> pwms = <&cros_ec_pwm 0>;
next prev parent reply other threads:[~2022-11-25 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:42 [PATCH 1/2] arm64: dts: qcom: align LED node names with dtschema Krzysztof Kozlowski
2022-11-25 14:42 ` [PATCH 2/2] ARM: " Krzysztof Kozlowski
2022-11-25 14:55 ` Konrad Dybcio
2022-11-25 14:55 ` Konrad Dybcio [this message]
2022-12-06 18:19 ` (subset) [PATCH 1/2] arm64: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e1af6bf-d10c-c70b-e23f-690fb9242e4c@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).