From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219C4C43217 for ; Fri, 25 Nov 2022 14:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiKYOzc (ORCPT ); Fri, 25 Nov 2022 09:55:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiKYOza (ORCPT ); Fri, 25 Nov 2022 09:55:30 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E2A827B16 for ; Fri, 25 Nov 2022 06:55:29 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id g7so7264438lfv.5 for ; Fri, 25 Nov 2022 06:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ptvcI10luTBZiVVBFz4/ilrVxDAvmrtYyie3Ti+0rs0=; b=FN/dzwAoQJuHkYBYb5uOz5qDGLcqAaCODQHHpchoZ62kw4bpPq+3S9Uv681iafViLf 41T5LU+FgWXz4dzCCcYeXEGd79qWlqBn4uxfQp2/7zp6F1imRhKeYTfV+AXjqhTEJZf7 fMK4Nh6w1+MJjBNNCPG7/WEiidEYncCcCptjv/Zq5h8VxCG3aAdwq5CnYf4G8g1IsYvI d+Z5I03rluLOVe3xaQA/LK+k3opMM7FEfbFIzjDcRd1i61FOKt9SyUu5MNxTP/11UGx4 8sBtRke+2cMPTB883a95KOE6Lr2H9SMfBrCx8jpeau9iKc6Aqybjjlpc4nOFXadp8Re1 tx5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ptvcI10luTBZiVVBFz4/ilrVxDAvmrtYyie3Ti+0rs0=; b=lknCIdmhWG1iPpFvIbVML3FT/qBoszqkJcFGUkLdSQZlC+zRjEsR1dkZpRWtWhJRJJ XQwj4c6zoWJtfOK5f/wmQ5Jkvc5kOgtbqEAUDJltbndDzjwJUPUSf2epD5jNHz8FZAcU +8OqUnzBDYHAkEUwhzi3AqfH4CNShW/pXkhEiESgDJXHOci2jPRCf0yvGOAfNiwMysGl r637mRcGjjiu9CbIU3A8dXJZRE9RWXpwedWNaLVFp64DFpCOAZf8fX4YR276g4/BeFSD Qf9bi7+CYIwUaN6Qc1pJARB9pN8oh3uWuxS/CN3rkSYWHJBprdlRFSwjm61hMF38JjC/ /vvw== X-Gm-Message-State: ANoB5pnfNqypWmexZLz8ferTJdZTJifzwcAMPs9biqOfoQ84VdsLZyrr eO7VM3wzL/Delr0UA4cX54DJDA== X-Google-Smtp-Source: AA0mqf61fTgjgw9ZGP3SPPQ6IHP2AxKJXa6/s+ZyOO/C6xPQjtfuwbieVuXwvRLsR5KpQG06sLkbag== X-Received: by 2002:a05:6512:340b:b0:4a2:5897:2b44 with SMTP id i11-20020a056512340b00b004a258972b44mr14499027lfr.431.1669388128044; Fri, 25 Nov 2022 06:55:28 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id g7-20020a0565123b8700b00494978b0caesm538857lfv.276.2022.11.25.06.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 06:55:27 -0800 (PST) Message-ID: <6e1af6bf-d10c-c70b-e23f-690fb9242e4c@linaro.org> Date: Fri, 25 Nov 2022 15:55:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] arm64: dts: qcom: align LED node names with dtschema Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221125144209.477328-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25.11.2022 15:42, Krzysztof Kozlowski wrote: > The node names should be generic and DT schema expects certain pattern: > > qcom/msm8998-oneplus-cheeseburger.dtb: leds: 'button-backlight' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > qcom/sc7180-trogdor-coachz-r1.dtb: pwmleds: 'keyboard-backlight' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > index b951f98d1b7b..9fb1fb9b8529 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > @@ -22,7 +22,7 @@ leds { > pinctrl-names = "default"; > pinctrl-0 = <&button_backlight_default>; > > - button-backlight { > + led-keypad-backlight { > gpios = <&pmi8998_gpio 5 GPIO_ACTIVE_HIGH>; > color = ; > function = LED_FUNCTION_KBD_BACKLIGHT; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 65601bea0797..74a90948db6b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -354,7 +354,7 @@ max98360a: audio-codec-0 { > > pwmleds { > compatible = "pwm-leds"; > - keyboard_backlight: keyboard-backlight { > + keyboard_backlight: led-0 { > status = "disabled"; > label = "cros_ec::kbd_backlight"; > function = LED_FUNCTION_KBD_BACKLIGHT; > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 448da9794722..27f479ff9d80 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -307,7 +307,7 @@ max98360a: audio-codec-0 { > pwmleds: pwmleds { > compatible = "pwm-leds"; > status = "disabled"; > - keyboard_backlight: keyboard-backlight { > + keyboard_backlight: led-0 { > label = "cros_ec::kbd_backlight"; > function = LED_FUNCTION_KBD_BACKLIGHT; > pwms = <&cros_ec_pwm 0>;