From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28700CCA47F for ; Wed, 29 Jun 2022 09:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231384AbiF2JXx (ORCPT ); Wed, 29 Jun 2022 05:23:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbiF2JXw (ORCPT ); Wed, 29 Jun 2022 05:23:52 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E192F377D9 for ; Wed, 29 Jun 2022 02:23:51 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id g26so31296448ejb.5 for ; Wed, 29 Jun 2022 02:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=90oPbUZjWIrdVFwHuCcwlnH1DzBnkawJPEGv8+dYOgY=; b=et0B8ipcxLAqwpKDEuUybySKbX7Mop9S0Me/WEzpbuUcyy8FDLmGtl8IVobHaGXP18 peoX4QRbjD6Y93UNGNw1V6zR6d9t7TCmMKBPDqpUiZvuUoSS/H4/RDs47J3+ZLArrlqm D/FJDtKA0gXMhgHVfSgjqAx+Ojoo9U1rt1vwhHJn/IBxPTBdnAO1XmEk1Wt3n1kTScg3 4rjueOV/bGoFs85iEsYxbyFk7ngNMv5Hf/b4zwx+z7hv/2OuMSZjeFsRy7TRq/8rW7em wuazk9ddC36enNbbZXa2M6KTILayrU3ez5zPzLRkGlXrCc1BK4cpi0bOXvUxkozfZUlI AuEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=90oPbUZjWIrdVFwHuCcwlnH1DzBnkawJPEGv8+dYOgY=; b=d2YqSfDqNj4Re/AWVhQ7Xp3yukf0gYWcHanegnM107CC2dEWOBahuGBZW6tnHrhSe0 PezU/V5xQqQuLFIqfG7Rhk4AUn3Z7izfCzdEsLwfHKam+mCGxOGMXCREwrD3+rwdQJJM R60Q+8ReLaX0jPAlxtM/xlumn3v1HeIC5cXP4gPRLW1ePPIZrwPnyh6uWIfLZVRmvMFW lDu3K/V52TCz3mnN9pUaicKHbH6Oc8m2SRcjeSoBw7tcEW2tf05oihSW42VBjJfJXkpv AVfW9EQ9RSQbTuLTXowt/ISYGPPeIB+vqJS+9Bpem81mbn4u0rP9FsWJEEmJd9XbHqIF EWsw== X-Gm-Message-State: AJIora8Z/COzbbZd8fDxG5NJ4fUSFdUHuisW4EmOUDVSO0z5tNdL4o9n WgQSKEaGyp310VlU1KsJeBwyRg== X-Google-Smtp-Source: AGRyM1sH34zUmPzWXRo+UkpWhTTGzBc2msaGYCRe6PpnoP/U/CXe6rqkeba7JnLYw13W5oRY1ZhUTQ== X-Received: by 2002:a17:906:d555:b0:726:2b3a:d80a with SMTP id cr21-20020a170906d55500b007262b3ad80amr2412956ejc.144.1656494630452; Wed, 29 Jun 2022 02:23:50 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id bq15-20020a056402214f00b00435a742e350sm11074643edb.75.2022.06.29.02.23.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 02:23:49 -0700 (PDT) Message-ID: <6e1b37e6-83e8-a920-61d9-044b08e93605@linaro.org> Date: Wed, 29 Jun 2022 11:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 08/11] dt-bindings: display/msm: add mdp-opp-table to dpu-sdm845 Content-Language: en-US To: Dmitry Baryshkov , Rob Herring Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krishna Manikandan , AngeloGioacchino Del Regno References: <20220625232513.522599-1-dmitry.baryshkov@linaro.org> <20220625232513.522599-9-dmitry.baryshkov@linaro.org> <20220627180506.GA2679395-robh@kernel.org> <772E0163-AC47-47E1-A0C6-CA04CA874282@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <772E0163-AC47-47E1-A0C6-CA04CA874282@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/06/2022 22:23, Dmitry Baryshkov wrote: >>> + $ref: /schemas/opp/opp-v2.yaml# >>> + >>> ports: >>> $ref: /schemas/graph.yaml#/properties/ports >>> description: | >>> @@ -116,11 +120,12 @@ examples: >>> <0x0aeb0000 0x2008>; >>> reg-names = "mdp", "vbif"; >>> >>> - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, >>> + clocks = <&gcc GCC_DISP_AXI_CLK>, >>> + <&dispcc DISP_CC_MDSS_AHB_CLK>, >> >> What does the OPP table have to do with clocks? Adding a clock anywhere >> but the end is an ABI break. > > I should split this to a separate patch. And, I must admit, this clock change has already landed. We did not think that it is an ABI break since we have clock-names here. xxx-names are only a helper and order of items is always strict, thus any change in the order is always ABI break. Best regards, Krzysztof