From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F1BC04A95 for ; Thu, 29 Sep 2022 08:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235529AbiI2I3f (ORCPT ); Thu, 29 Sep 2022 04:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235172AbiI2I33 (ORCPT ); Thu, 29 Sep 2022 04:29:29 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 261E813EAFC for ; Thu, 29 Sep 2022 01:29:26 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id bk15so951658wrb.13 for ; Thu, 29 Sep 2022 01:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=bpujdPbvMkKZc5tbT0tesQargul5oOFWG757hhJb/PI=; b=S+MBQ80rqHpEy6NEzdghu7ouA0nlstzMZO9Saw2V8CTa/0OE+fpOyEtEpWnJ5a33MZ 2zwKxqsKiGGlhR/4NLysLq43VTA2zD4e1z9PcdNGWaTFDPTZoZgmMgJmpzQLLdSuXQki 3UxJ5CNla358jTuqu4ssay4iY3uunEAjeUnNzs6uH0RQbOux2hAcJgwpZcaRvKB2DW25 sHoBQ24LKekSRT/apOh73b0ZExISLGEUYJSiTewZC4btdD67F7IzGpGxTAlG4Ip+2Q/+ Udesxn69qPH0WMUMoGAmU2sl3+VyQpVoVmiDlE6MI4C5LpxdKhafAm7PkHE7RaOKPQGI /8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=bpujdPbvMkKZc5tbT0tesQargul5oOFWG757hhJb/PI=; b=EM94IjV5swy3I+dgu6UgzAvXGBp6MGJGZxlQowEeMW77X7cIzLky0o/9aJ8CFP0JW0 q+TB5ss+zb2LECVQVzcQb4nS7WpWIQpyYA+Nx+v4Ak8SsPD0lqGf7PNubV8meyanlz0a 0AigUVpYFmgysdtjJYXwe7FSHyxpEuGdcJw1Ri1tpnlzbFb3J2OKjLDhao+cw7mMp3ik EMPxXb1rjUgB0B/qV1+X8ArSUNOvc86HS3GrbgDeHogil5yK5JytPOmOBDRF7ob+DF/t d3HipLsvmXR9xMFKPz2PJF4Q59u2fFUW+Mks5PdqdCNjrr/k1G8v9gsBFc4ByxPX7dS8 Ydpw== X-Gm-Message-State: ACrzQf1S1g5/5DTE647BjMzUfXSace3/h7aD+nNe76ho3Rp/k1uGmj41 OzBcwyvRR9PpWmNWZWuHPinCgg== X-Google-Smtp-Source: AMsMyM6kYyKnh1/JwTgKQ0f0DN5Ba74UeFtjFSwCtJ6Xed8FffnuPm3vCjv67+qK5DVvgDx79qu+mQ== X-Received: by 2002:a05:6000:797:b0:22c:be73:ff82 with SMTP id bu23-20020a056000079700b0022cbe73ff82mr1331315wrb.618.1664440164403; Thu, 29 Sep 2022 01:29:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:1f17:3ea3:4e46:dff? ([2a01:e0a:982:cbb0:1f17:3ea3:4e46:dff]) by smtp.gmail.com with ESMTPSA id z2-20020a05600c0a0200b003a4efb794d7sm4102412wmp.36.2022.09.29.01.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 01:29:23 -0700 (PDT) Message-ID: <6ed642ea-424d-49ed-eb30-e09588720373@linaro.org> Date: Thu, 29 Sep 2022 10:29:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Konrad Dybcio Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org> <20220928-mdm9615-dt-schema-fixes-v1-5-b6e63a7df1e8@linaro.org> <0636d53f-508f-8a86-0973-2641c9020622@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <0636d53f-508f-8a86-0973-2641c9020622@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 28/09/2022 20:03, Krzysztof Kozlowski wrote: > On 28/09/2022 11:14, Neil Armstrong wrote: >> The PMIC is an PM8018, but was compatible with the PM8921. Both compatibles >> was left but it makes no sense anymore the leave both. > > Why? It makes sense for backwards compatibility. If you think it does > not make sense, please say why. We had the same debate at submission 7y ago, some of the pm8018 new compatible were rejected in bindings & drivers so I left both... As of today only the pwrkey bindings is missing, so should I resubmit the pm8018-pwrkey bidings and drop the pm8921-pwrkey compatible ? > >> >> The pwrkey compatible is left to PM8921, unlike the others because >> the interface is stricly compatible with the PM9821 pwrkey. > > typo: strictly > typo: PM8921 > > Again, why? The old code looked correct. In all three places. The qcom,pm8018-rtc require a single compatible, same for qcom,pm8018, so what's the way to fix it ? > >> >> Signed-off-by: Neil Armstrong >> > > Best regards, > Krzysztof > Thanks, Neil