Re: [PATCH v3 24/27] soc: qcom: ubwc: drop macrotile_mode from the database

Dmitry Baryshkov
2026-03-13T14:30:01Z

On Fri, Mar 13, 2026 at 11:28:26AM +0100, Konrad Dybcio wrote:
> On 3/12/26 2:29 PM, Dmitry Baryshkov wrote:
> > All the users have been migrated to using qcom_ubwc_macrotile_mode()
> > instead of reading the raw value from the config structure. Drop the
> > field from struct qcom_ubwc_cfg_data and replace it with the calculated
> > value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and
> > UBWC_3_1 (with macrotile mode).
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
>
> [...]
>
> > static const struct qcom_ubwc_cfg_data sar2130p_data = {
> > - .ubwc_enc_version = UBWC_3_0, /* 4.0.2 in hw */
>
> Is it referring to the values reported by MDSS (4.0.2 enc, 4.3.1
> dec)? FWIW the other doc only mentions UBWC3 for the platform..

Yes. The code (and the database) has its roots in the msm_mdss.c, which
had that comment. Other blocks on SAR2130P might have different UBWC
support levels, leading to UWBC 3.0 (3.1) as a common denominator.

--
With best wishes
Dmitry