Re: [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks

Dmitry Baryshkov
2026-03-13T14:27:42Z

On Fri, Mar 13, 2026 at 11:25:18AM +0100, Konrad Dybcio wrote:
> On 3/12/26 2:29 PM, Dmitry Baryshkov wrote:
> > Unlike other drivers, the DPU driver checks for exact UBWC version,
> > making it hard to add minor versions if necessary. Invert the order of
> > UBWC checks, letting the DPU driver handle new minors transparently.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
>
> [...]
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
>
> > } else {
> > DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_version);
>
> note this is existing behavior, but do we want to write to these
> registers on platforms without UBWC, instead of returning early?

I'd really hope that developers who port DPU to such platforms will see
the warning and fix it during the porting effort.

--
With best wishes
Dmitry