From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECB91EB9E3 for ; Mon, 29 Sep 2025 05:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759124555; cv=none; b=KdLj5G+hZ+vSY8rWxK5P2dWABSBZ9DQsdmLiUWoPxyAuQu5R5OEvBeUTgn8hezI6yToD1b6nsTpFtVqhtTr9wIJTJ7uGeRozOz9Mznm5tK/D17oX62CCMgi3rjIy66nKJuJynxmFW8LZ27ZAb+1rG+8Lk8E9VxZaY5twdLPWGis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759124555; c=relaxed/simple; bh=djbdttzWVeZdtdcCBQG2ls7rum6/KDgqWatmSRYyy9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bg1rQVR1grnvwVTk4Wa+SOasq6GPp7VY9KBSA/njzQtVoRR2W7Jj5YtykPGG6L4gUnzXRCSkt3UacjtQ7OqaHwh8qb/puRKWneGhu1EB86DftLF9jRgX1J9fU9vHPpem58l+ZHSGvJ64UlO0OsXS57wLjkzp6JYoR0wxEpnWhUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q8AlYXXd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q8AlYXXd" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58SNmZoY000929 for ; Mon, 29 Sep 2025 05:42:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rfBzbpwct3yDDq36E8SAQ+hFmXrqjfgGSlZ22u0SUWo=; b=Q8AlYXXdoNZAjB2q TEw+Ewb9XF31iytwBx8jZKR3L4h+xeL2pVn8rUmUwIk52sxlPtTL2ppJ6MIO0tsA pM2ZpaR7XomqPrculQZd8FYRUtavCio+xHdB5VFXgpaZRPB4RgWzgXJ3cz2YDZJk pY6U02VJK4YlXk6Kh0BPl3CFdRslagBhrQzLI9Zlj/Ks5aOBUDp1XNrpxAqchKnr pqQYXiDcyigt1JmKqz6A+2MHx0DGm3QKTdXwNL6x137Ih3PXPHUlDBRiEZw2rTp3 FNBjCJrRX32OgDQy5ifUrXrvH82UaoEHCUZB+KqynpdaRqN1aakmfOc3T5ZSrBAP y+wnnQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e7gxkyuf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 29 Sep 2025 05:42:32 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b588fd453d7so2069242a12.2 for ; Sun, 28 Sep 2025 22:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759124551; x=1759729351; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rfBzbpwct3yDDq36E8SAQ+hFmXrqjfgGSlZ22u0SUWo=; b=G2D/BydqGXpQzS+Fb0eMqGt1lAtkhln+JHyTamd0ufT6UaVLSdgDimbOzePA5+E3RM 1U+jfK6TWNZ9tml5ibgLIo9Ppn7bkosIhlu2JqmHY8E04V+55/lVgvJJ9InL+xrJupc6 d1nG9eFsXWfF1ApgbQqkcZavXOLp8vafNKUGLgznVh0Ylgr3RDv0Mms+UPMvttfTTu6k 7RkASSi8RYfE8EZLRcQkr47GYEQqI9OZagDeT/IJ8iDU9/FBZ6apEbESTgri+go84Hd4 /BsU/Y7UqPsTbbreOISchYTcLFqKzmN0Vn5jQl2Yy30Qhop1o7smKB9qPF8sxYR8SgDb MqRw== X-Gm-Message-State: AOJu0YyASx7vEzjgdjHrohxxtbwklIH2W5ADxlJs9brBdIEGRCdlcZ+r pInpOuii4lERBeGvVo0NdTlfqhFWZYZT+62IxmAFQ5oj+nXT6iU7Wleh7dX+Qj+EYt8+gmL/akZ EUUmuinAg0QJGIv0FxAtAg2wVBwP5y/r1y6eMlFJhZat6v0QcKBcMvM7nxYcdZdL/EtMY X-Gm-Gg: ASbGncvrL82Eccfw5Jbt4pGDhElab2i6KlB2uqwRoPIUyOcewciHVkovvnOcHpm3L3Z A7p5niVDOvy7xrM4yPVacB7sHRFDGiMZqnsbj9jvktaeFctuHcYEiOtNTyxto7tILvVdl+L+BVN KDJwHnGUqUqT65dN/nd0lotop6ixOpeSTJYtq6ADEY4M3V9UNZCp2myknMQTQnB0UJ06zd0vXCc FLtUFIW/wOMQeuQPmrd0/EQFk1EJ8mNNvgFnfaJT/pFP1V/b0HEybTU8aCzw5RKRfD/Cy75fvT/ 4rsrvZzoX2As+F2qBSjzwfq/OrZLTEMMBYjKGoajchGl6XOI/2nXA+xYRSWvWmrWFKefCLRvI56 oUb4EXqInIY0qOGhrclAP+X5ZxUDrmzxxOug= X-Received: by 2002:a17:90b:1c04:b0:332:2773:e7bf with SMTP id 98e67ed59e1d1-3342a2b9566mr15491888a91.18.1759124551541; Sun, 28 Sep 2025 22:42:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcs/k3kR5lOsN+V9n/ODodNKvmnVPplyVbFJ8XSQZMHLdp/E45BWmNDfJA1eXIMQW/p9GKdw== X-Received: by 2002:a17:90b:1c04:b0:332:2773:e7bf with SMTP id 98e67ed59e1d1-3342a2b9566mr15491859a91.18.1759124551062; Sun, 28 Sep 2025 22:42:31 -0700 (PDT) Received: from [10.133.33.234] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3350256d403sm11124204a91.14.2025.09.28.22.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Sep 2025 22:42:30 -0700 (PDT) Message-ID: <70241129-1e08-41f8-b60c-b72ec079702a@oss.qualcomm.com> Date: Mon, 29 Sep 2025 13:42:26 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3 configuration for serial engines To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jyothi Kumar Seerapu References: <20250924-knp-dts-v1-0-3fdbc4b9e1b1@oss.qualcomm.com> <20250924-knp-dts-v1-13-3fdbc4b9e1b1@oss.qualcomm.com> <9685e29d-bff3-4188-b878-230d0f161ce3@oss.qualcomm.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: <9685e29d-bff3-4188-b878-230d0f161ce3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 7T_owxfoGG4yIC3gLg-g-Z8-fcidGYlt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAyNSBTYWx0ZWRfX2OQtsDvGohVQ czUzmPFkqun5EHRJbLPmhDVnZgQg5O8RMfikMItr3l6zKSPyoLfZWlJaToTpKr0bMCW28EKknS7 TImOPVaa6a+EBNQCzmTrBPaoawV82R5hPsHrPqkOTya3q0eH7dy7AY2IU8514ujLqSbT6ea4Zps 9dqPhMFvUHC23oB3D6x7Mkq/e+tTB3fnXYHS1CpwYFqJmbr3ZS99q4GzdhtQOpVEFaV7C7WKgqV zoKbj0urI37Y/AnjP6FS6X4Sawjq7sInkLa+5tsSRLj5Xed0qE62TtS4aX+dXjynBv9zUp9JnhC 7BLQO+BSIXl3OEpOPC0BaAhFGII8pF1D2P1YS/uwkhTkbLDpj49eopkkn1C+nu8Kem/wiera6kB MXbjmjjoueZg/PJhgkt0BcEatSNKVQ== X-Proofpoint-GUID: 7T_owxfoGG4yIC3gLg-g-Z8-fcidGYlt X-Authority-Analysis: v=2.4 cv=dP6rWeZb c=1 sm=1 tr=0 ts=68da1c48 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=_ltKwtvy-Tbn6v8TjEMA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-29_02,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270025 On 9/25/2025 8:28 PM, Konrad Dybcio wrote: > On 9/25/25 2:17 AM, Jingyi Wang wrote: >> From: Jyothi Kumar Seerapu >> >> Add device tree support for QUPv3 serial engine protocols on Kaanapali. >> Kaanapali has 24 QUP serial engines across 4 QUP wrappers, each with >> support of GPI DMA engines, and it also includes 5 I2C hubs. >> >> Signed-off-by: Jyothi Kumar Seerapu >> Co-developed-by: Jingyi Wang >> Signed-off-by: Jingyi Wang >> --- > > [...] > >> + gpi_dma2: dma-controller@800000 { >> + compatible = "qcom,kaanapali-gpi-dma", "qcom,sm6350-gpi-dma"; >> + reg = <0x0 0x00800000 0x0 0x60000>; >> + >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; > > odd indentation (on almost all gpi_dma instances) > > [...] > will fix Thanks, Jingyi >> - remoteproc_soccp: remoteproc-soccp@d00000 { >> - compatible = "qcom,kaanapali-soccp-pas"; >> - reg = <0x0 0x00d00000 0x0 0x200000>; >> + i2c22: i2c@1a8c000 { >> + compatible = "qcom,geni-i2c"; >> + reg = <0x0 0x01a8c000 0x0 0x4000>; >> >> - interrupts-extended = <&intc GIC_SPI 167 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 9 IRQ_TYPE_EDGE_RISING>, >> - <&soccp_smp2p_in 10 IRQ_TYPE_EDGE_RISING>; >> - interrupt-names = "wdog", >> - "fatal", >> - "ready", >> - "handover", >> - "stop-ack", >> - "pong", >> - "wake-ack"; > > Please try to use git format-patch --patience > > Konrad