From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162A6C636CD for ; Fri, 10 Feb 2023 10:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232057AbjBJKbP (ORCPT ); Fri, 10 Feb 2023 05:31:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232037AbjBJKbO (ORCPT ); Fri, 10 Feb 2023 05:31:14 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BD446D637 for ; Fri, 10 Feb 2023 02:31:11 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id j23so4639895wra.0 for ; Fri, 10 Feb 2023 02:31:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=EoP3N0+HyfNxDRuzpcPoBnYi1M7DcjjI/H/2+p16pBQ=; b=y53wZ1cyUbE2DR60T8dKx8BlNMPI4M6CzHQq2hL7tlvbpH1a3t5yBjcGd+7Piwlibs rOGJSj20Jx0vmI4MN4IcVu7tIRPYIBVPi2sw99/K8fpi+ujYrXEvxmqjQKQobzNFNX5F M7OfrvbUsyiZVUnQ9ZO4G1pjoB6LacQbfiRD9yPQ0eCkklQ/tOfgGLpcewnsPcaDa9nU nMeT6QRwJpKHvvn3LNne3bgKQoD+Z4nB0RfTAuzDmBj2Bn1M+ba1UXct1iBBsYdnEJQw aXCyWUSEiAQeP2+1klY5QzzKJD/HTnXN03/TaylEBDBVJ85DL7891MSXaFK+/ErwzaTD cVRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EoP3N0+HyfNxDRuzpcPoBnYi1M7DcjjI/H/2+p16pBQ=; b=vcN3dZLNP8UQoBnWy1FVsiNFI3OkMu+hOb7Y3E5VoF8yUebknz7X/Av3oXB/mkH3in cey43eTtSnI5lvHi7AbRWJWp8EidewQWq0S483omA4cJnQENfSI4hWqdZOkfsg7gIDqd UzXFpYAYKzvcXZEHiYg6SPzDphEUGVjD66JlkluRDxrldAdcndVQR+e4esjBREmRUk6L OH1VpsPwfU8+4vXJ3yNK86Gn9tfxcj8tx7lpI73Zpeiy6DWF5OL1R6Y9vcs8YMM0bb+X TGg0MKKNkCocl/zGVzUF1/UFASn4HRISFbU8m7Dzoaxe7bGHoCxFeGVRZ2o3dzxsKHvB 37bw== X-Gm-Message-State: AO0yUKU/zXfxjHdOvGpFXsyeeNP0H8Uv+DFH3+mE0Ez+nhusjroYmEQP 4uTRyrdOG1UjqILhbRkOvpjYJQ== X-Google-Smtp-Source: AK7set83bAYzbIOw3hqSGA3caGrA7n0CkMX9pgiGQddnRDcI///tWiZjqyHj7uimc9mqXiVcWn0E7A== X-Received: by 2002:a05:6000:4:b0:2bf:ae17:bf58 with SMTP id h4-20020a056000000400b002bfae17bf58mr13181044wrx.37.1676025069861; Fri, 10 Feb 2023 02:31:09 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5a65:5553:55cf:3027? ([2a01:e0a:982:cbb0:5a65:5553:55cf:3027]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003db0ee277b2sm7854940wmq.5.2023.02.10.02.31.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 02:31:09 -0800 (PST) Message-ID: <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> Date: Fri, 10 Feb 2023 11:31:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Content-Language: en-US To: Greg Kroah-Hartman Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31/01/2023 10:16, Greg Kroah-Hartman wrote: > On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: >> Introduce the UCSI PMIC Glink aux driver that communicates >> with the aDSP firmware with the UCSI protocol which handles >> the USB-C Port(s) Power Delivery. >> >> The UCSI messaging is necessary on newer Qualcomm SoCs to >> provide USB role switch and altmode notifications. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/usb/typec/ucsi/Kconfig | 7 + >> drivers/usb/typec/ucsi/Makefile | 1 + >> drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 329 insertions(+) >> >> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig >> index 8f9c4b9f31f7..dee6069e46a2 100644 >> --- a/drivers/usb/typec/ucsi/Kconfig >> +++ b/drivers/usb/typec/ucsi/Kconfig >> @@ -58,4 +58,11 @@ config UCSI_STM32G0 >> To compile the driver as a module, choose M here: the module will be >> called ucsi_stm32g0. >> >> +config UCSI_PMIC_GLINK >> + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" >> + depends on QCOM_PMIC_GLINK > > No way to test build this code without this option? Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed > >> + help >> + This driver enables UCSI support on platforms that expose UCSI >> + interface as PMIC GLINK device. > > Module name when built? OK will add a follow-patch if needed Thanks, Neil > > A follow-on patch can be sent, this is minor. > > thanks, > > greg k-h