Re: [PATCH 0/8] Add OnePlus 6T display (Samsung S6E3FC2X01 DDIC with AMS641RW panel)

[David Heidelberg <david@ixit.cz>]

On 25/09/2025 11:37, Konrad Dybcio wrote:
> On 9/25/25 11:12 AM, David Heidelberg via B4 Relay wrote:
>> This patchset enables display on the OnePlus 6T smartphone.
>>
>> Minor adjust to the device-tree of OnePlus 6 had to be done
>> to properly document reset GPIO used. Also same adjustments
>> had been done to the sofef00 panel driver (used by OnePlus 6).
>>
>> In the last step new DDIC driver is introduced together with AMS641RW
>> panel sequences.
> 
> I think you skipped the elephant in the room - some of these patches
> break panel for the phone intermittently..

Thank you for the review Konrad. I plan to incorporate all your 
suggested changes in the next revision.

To clarify, while sofef00 has been introduced as supporting OnePlus 6T 
too, but it never did (and the compatible was removed later).

All the changes CAN'T BREAK anything for OnePlus 6T display as it's not 
supported yet by mainline.

All the changes SHOULDN'T CHANGE anything for the OnePlus 6, as both 
sides (device-tree and the driver) is changed at once to correct reset 
polarity.

David

> 
> Konrad

-- 
David Heidelberg