Re: [PATCH 1/2] drm/sched: Rename priority MIN to LOW

["Christian König" <christian.koenig@amd.com>]

Am 27.11.23 um 15:13 schrieb Luben Tuikov:
> On 2023-11-27 08:55, Christian König wrote:
>> Hi Luben,
>>
>> Am 24.11.23 um 08:57 schrieb Christian König:
>>> Am 24.11.23 um 06:27 schrieb Luben Tuikov:
>>>> Rename DRM_SCHED_PRIORITY_MIN to DRM_SCHED_PRIORITY_LOW.
>>>>
>>>> This mirrors DRM_SCHED_PRIORITY_HIGH, for a list of DRM scheduler
>>>> priorities
>>>> in ascending order,
>>>>     DRM_SCHED_PRIORITY_LOW,
>>>>     DRM_SCHED_PRIORITY_NORMAL,
>>>>     DRM_SCHED_PRIORITY_HIGH,
>>>>     DRM_SCHED_PRIORITY_KERNEL.
>>>>
>>>> Cc: Rob Clark <robdclark@gmail.com>
>>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>> Cc: Danilo Krummrich <dakr@redhat.com>
>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>> Cc: Christian König <christian.koenig@amd.com>
>>>> Cc: linux-arm-msm@vger.kernel.org
>>>> Cc: freedreno@lists.freedesktop.org
>>>> Cc: dri-devel@lists.freedesktop.org
>>>> Signed-off-by: Luben Tuikov <ltuikov89@gmail.com>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>> Looks like you missed one usage in Nouveau:
>>
>> drivers/gpu/drm/nouveau/nouveau_sched.c:21:41: error:
>> ‘DRM_SCHED_PRIORITY_MIN’ undeclared here (not in a function); did you
>> mean ‘DRM_SCHED_PRIORITY_LOW’?
>>      21 |         NOUVEAU_SCHED_PRIORITY_SINGLE = DRM_SCHED_PRIORITY_MIN,
>>         | ^~~~~~~~~~~~~~~~~~~~~~
>>         | DRM_SCHED_PRIORITY_LOW
>>
>> This now results in a build error on drm-misc-next.
> I'm waiting for someone to R-B the fix I posted two days ago:
> https://lore.kernel.org/r/20231125192246.87268-2-ltuikov89@gmail.com

There must be something wrong with the dri-devel mailing list (or my 
gmail, but I doubt so). I don't see this mail in my inbox anywhere.

Feel free to add my rb and push it.

Thanks,
Christian.