From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445D7C54EB4 for ; Mon, 23 Jan 2023 22:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbjAWW7X (ORCPT ); Mon, 23 Jan 2023 17:59:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231749AbjAWW7U (ORCPT ); Mon, 23 Jan 2023 17:59:20 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E8A1367ED for ; Mon, 23 Jan 2023 14:59:02 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so11679512wmb.2 for ; Mon, 23 Jan 2023 14:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IZpSsT6QI0rgCdyfZs7KnVG5ae2iXjgk88FXgcyzmRA=; b=u5YeiB5rqWMAFD8zMzjvfbaFygIA9yFyCGmYqetLzBTxTDxda40pEo/CEnjcItlDxi EAj9F/ALM4fpbpfTCjGzuGUf58H6DR1XjBJhxxFo0/sqp0g6FiEQ1VZew29eZ1WLqA5x M2mlXycExKOVQSDPiNJ5G2yee9aX5VGK2Mp/IcjXQ5sr8nCsI9PT9wciXDwoTuhcYbNV YW8nziM6jLvJBaWlWmQ5QWoprB1UJJ3E6tlIeeGhKOD0jmMDHxfSHTEaDxvzIVOZXtYz oPWyPC9pbYyTrTDh3QQV2Bl05htN5LSILIbm5qXrQFMpZ36JnQWG0Rc3O9pzJlKeEizd DUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IZpSsT6QI0rgCdyfZs7KnVG5ae2iXjgk88FXgcyzmRA=; b=EKVK3R8kcRrXmd5EVouqD9HNfU9Xji3Y9Hs+61qPDP5dlC5K4ZYsWj8gK51RBR2zfX dp3R8JzA2Ntw97oUnswSkf2Ja53NXm7YtzZpL3iwKI9ro+VVyHaSz5FfdKghr4Rz4/vn XVNnocvv84tCggZDKYI+ne+/+C3dqck4RACym0bmBfBG7g34O3fW/P1InezmBmRMFrtw TVQOO8elURInnH7KiP1ciZ0Fnh68O79YeDhfZGLy8OBZ6rkcuZLJcvjDEjGCI3yZcYpn zmwLCbViR8aWxHQ4WVjrKIZ7zifRr3D7X8rV6kmrgFEZ2upgyOeusuyJs8YCm8haAkYS jIlg== X-Gm-Message-State: AFqh2krnPTcNyU1eWcPMWzw4pEqIEWkP1DB05gyL9dHNsA3xNkXcltZB 2PWRxu3Z1xZeCj2CDRLo1XLryw== X-Google-Smtp-Source: AMrXdXtHjG/WoKRMTL4vHHKw+QJOus1BHZT4nnfsCks4OXHZZWPMWOdEEOz5p7UVsK240vz5ky2+GA== X-Received: by 2002:a05:600c:3296:b0:3cf:82b9:2fe6 with SMTP id t22-20020a05600c329600b003cf82b92fe6mr26652326wmp.8.1674514730781; Mon, 23 Jan 2023 14:58:50 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id k23-20020a05600c479700b003d9e74dd9b2sm389691wmo.9.2023.01.23.14.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 14:58:50 -0800 (PST) Message-ID: <742ff9cd-e7be-11b8-3805-5b60aba6b2f1@linaro.org> Date: Mon, 23 Jan 2023 22:58:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] interconnect: Skip call into provider if initial bw is zero Content-Language: en-US To: Mike Tipton , Vivek Aknurwar , djakov@kernel.org Cc: quic_okukatla@quicinc.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "abel >> Philipp Zabel" , abelvesa@kernel.org, abel.vesa@linaro.org References: <1673647679-15216-1-git-send-email-quic_viveka@quicinc.com> <83a7bfed-3b16-3d01-b1b2-f197252bd0b1@linaro.org> <5e1f37ba-494a-19d2-e412-7631508ab142@linaro.org> <151790dd-02e5-a1f5-aab5-360f39e21c57@quicinc.com> <35dcb764-e340-5fe7-6637-cdb5f84266ce@linaro.org> <6dd7b0b0-f6fb-9de4-c365-d6cbfe04f2c0@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <6dd7b0b0-f6fb-9de4-c365-d6cbfe04f2c0@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/01/2023 20:37, Mike Tipton wrote: > > This isn't actually changing it for all providers. Only for those that > define the get_bw() callback. Right now that's only qcom/msm8974 and > imx/imx. If get_bw() isn't defined, then icc_node_add() defaults to > INT_MAX. So, the logical behavior in that case is unchanged. Which means > this isn't even changing the behavior for rpmh yet, either. Yes that adds up. Looking at the commit for get_bw() for the 8974, I think this change would be OK with the intent of this commit commit 9caf2d956cfa254c6d89c5f4d7b3f8235d75b28f Author: Georgi Djakov Date: Mon Nov 9 14:45:12 2020 +0200 @Abel what effect will skipping pre->aggregation() have on i.MX ? --- bod