From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manu Gautam Subject: Re: [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs Date: Wed, 20 Dec 2017 10:33:16 +0530 Message-ID: <74306e8c-acbc-f21c-fefc-0a719f06329c@codeaurora.org> References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-3-git-send-email-mgautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vivek Gautam Cc: Kishon Vijay Abraham I , linux-arm-msm , Linux USB Mailing List , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , "open list:GENERIC PHY FRAMEWORK" List-Id: linux-arm-msm@vger.kernel.org On 12/20/2017 8:07 AM, Vivek Gautam wrote: > Hi Manu, > > [snip] > >> @@ -998,29 +992,17 @@ static int qcom_qmp_phy_reset_init(struct device *dev) >> static int qcom_qmp_phy_clk_init(struct device *dev) >> { >> struct qcom_qmp *qmp = dev_get_drvdata(dev); >> - int ret, i; >> + int num = qmp->cfg->num_clks; >> + int i; >> >> - qmp->clks = devm_kcalloc(dev, qmp->cfg->num_clks, >> - sizeof(*qmp->clks), GFP_KERNEL); >> + qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL); >> if (!qmp->clks) >> return -ENOMEM; >> >> - for (i = 0; i < qmp->cfg->num_clks; i++) { >> - struct clk *_clk; >> - const char *name = qmp->cfg->clk_list[i]; >> - >> - _clk = devm_clk_get(dev, name); >> - if (IS_ERR(_clk)) { >> - ret = PTR_ERR(_clk); >> - if (ret != -EPROBE_DEFER) >> - dev_err(dev, "failed to get %s clk, %d\n", >> - name, ret); >> - return ret; >> - } >> - qmp->clks[i] = _clk; >> - } >> + for (i = 0; i < num; i++) >> + qmp->clks->id = qmp->cfg->clk_list[i]; > I think i missed this one while rebasing. > We need to use index with this. Should be: > qmp->clks[i]->id = qmp->cfg->clk_list[i]; > Thanks, I will change this accordingly in next version. > Regards > Vivek > > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html