From: "Brokhman Tatyana" <tlinder@codeaurora.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Tanya Brokhman <tlinder@codeaurora.org>,
balbi@ti.com, 'Sarah Sharp' <sarah.a.sharp@linux.intel.com>,
greg@kroah.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, ablay@codeaurora.org,
'open list' <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd
Date: Thu, 26 May 2011 09:15:10 -0700 (PDT) [thread overview]
Message-ID: <744ad016b77694e43f07d8bbc8f5b439.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1105261028040.1960-100000@iolanthe.rowland.org>
Hi Alan,
>> I also thought of that. This can be done...
>> Just to make sure we're on the same page:
>> We can add a "max_sup_speed" field to struct usb_composite_driver. Each
>> of
>> the Gadget drivers will set this field prior to calling
>> usb_composite_probe(). Then, in usb_composite_probe(), we'll update the
>> composite_driver.speed as follows:
>>
>> composite_driver.speed = min(composite_driver.speed,
>> driver->max_sup_speed);
>
> Just call it max_speed. You can mention in the kerneldoc that it is
> the maximum speed supported by the driver.
No problem. I understand that you agree to this approach?
I was going to wait for Felipe to comment but he'll be out of reach for
several days so I'll post a new patch set on Sunday.
Thanks for you help!
Tanya Brokhman
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-05-26 16:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 6:41 [PATCH v12 0/8] usb gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
[not found] ` <1306132882-9668-1-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-23 6:41 ` [PATCH/RESEND v12 1/8] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-23 12:31 ` Sebastian Andrzej Siewior
2011-05-23 22:18 ` Mike Frysinger
2011-05-24 5:10 ` Tanya Brokhman
2011-05-24 5:14 ` Mike Frysinger
2011-05-24 5:37 ` Tanya Brokhman
2011-05-24 17:12 ` Mike Frysinger
2011-05-23 6:41 ` [PATCH v12 2/8] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-05-23 6:41 ` [PATCH/RESEND v12 3/8] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
2011-05-23 6:41 ` [PATCH/RESEND v12 5/8] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 6/8] usb:dummy_hcd: use the shared_hcd infrastructure Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
[not found] ` <1306132882-9668-8-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-23 7:05 ` Felipe Balbi
2011-05-23 7:20 ` Tanya Brokhman
2011-05-23 7:21 ` Felipe Balbi
2011-05-23 8:18 ` Tanya Brokhman
2011-05-23 8:32 ` Felipe Balbi
2011-05-23 9:16 ` Tanya Brokhman
2011-05-23 14:22 ` Alan Stern
2011-05-23 16:08 ` Sarah Sharp
2011-05-23 16:28 ` Alan Stern
2011-05-23 21:06 ` Felipe Balbi
[not found] ` <BD27AEAC-1E6D-480C-9E18-A970B992AD75-l0cyMroinI0@public.gmane.org>
2011-05-23 21:21 ` Alan Stern
2011-05-24 5:53 ` Tanya Brokhman
2011-05-24 10:18 ` Felipe Balbi
2011-05-24 10:31 ` Tanya Brokhman
2011-05-24 10:33 ` Felipe Balbi
2011-05-24 10:43 ` Tanya Brokhman
2011-05-24 14:20 ` Alan Stern
2011-05-25 4:46 ` Tanya Brokhman
2011-05-25 9:21 ` Felipe Balbi
[not found] ` <20110525092124.GI14556-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-25 9:26 ` Tanya Brokhman
2011-05-25 9:27 ` Felipe Balbi
2011-05-25 9:43 ` Tanya Brokhman
2011-05-25 9:49 ` Felipe Balbi
2011-05-25 10:03 ` Tanya Brokhman
2011-05-25 10:29 ` Felipe Balbi
2011-05-25 10:52 ` Tanya Brokhman
2011-05-25 11:23 ` Felipe Balbi
2011-05-25 11:33 ` Tanya Brokhman
2011-05-25 12:42 ` Felipe Balbi
2011-05-25 14:23 ` Alan Stern
2011-05-25 14:39 ` Alan Stern
2011-05-28 11:05 ` Tanya Brokhman
2011-05-28 14:15 ` Alan Stern
2011-06-07 10:33 ` Felipe Balbi
2011-05-25 17:07 ` Brokhman Tatyana
2011-05-25 17:29 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1105251316170.1987-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2011-05-25 18:13 ` Brokhman Tatyana
2011-05-25 18:59 ` Alan Stern
2011-05-26 6:51 ` Tanya Brokhman
2011-05-26 14:31 ` Alan Stern
2011-05-26 16:15 ` Brokhman Tatyana [this message]
2011-05-25 9:20 ` Felipe Balbi
2011-05-23 15:55 ` Sarah Sharp
[not found] ` <20110523072142.GK3095-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-23 14:20 ` Alan Stern
[not found] ` <20110523070556.GJ3095-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-23 14:18 ` Alan Stern
2011-05-23 6:41 ` [PATCH v12 8/8] usb:gadget: coding style fixes Tatyana Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744ad016b77694e43f07d8bbc8f5b439.squirrel@www.codeaurora.org \
--to=tlinder@codeaurora.org \
--cc=ablay@codeaurora.org \
--cc=balbi@ti.com \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).