From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, wcheng@codeaurora.org
Subject: Re: [PATCH v3 6/7] usb: typec: qcom: Remove standalone qcom pm8150b typec driver
Date: Fri, 5 Nov 2021 16:05:37 +0000 [thread overview]
Message-ID: <749a058d-a16d-3a92-25b6-97afcfaa7787@linaro.org> (raw)
In-Reply-To: <YYVHcHC1Gm92VxEM@kuha.fi.intel.com>
>>
>> I don't like that you create point where the support is temporarily
>> removed for this hardware. I know Guenter asked that you remove the
>> old driver in a separate patch, but I believe at that point you were
>> also proposing different config option name for the new driver, so you
>> could have removed the old driver only after you added the new one.
>>
>> Since you now use the same configuration option name - which makes
>> perfect sense to me - I think you need to refactor this series. Maybe
>> you could first just move the old driver under drivers/usb/typec/tcpm/
>> in one patch, and then modify and slit it in another patch.
No problem with this in principle
> Or just merge this patch to the next one.
I think this for preference unless Guenter has an objection ..
easier/less work
---
bod
next prev parent reply other threads:[~2021-11-05 16:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 3:35 [PATCH v3 0/7] Add pm8150b TPCM driver Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 1/7] dt-bindings: usb: Add qcom,pmic-usb-typec dt-binding header Bryan O'Donoghue
2021-11-12 22:28 ` Rob Herring
2021-11-12 23:03 ` Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 2/7] dt-bindings: usb: Add Qualcomm PMIC type C controller YAML schema Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 3/7] dt-bindings: usb: Add qcom,pmic-usb-pdphy dt-binding header Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 4/7] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 5/7] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2021-11-05 14:41 ` Rob Herring
2021-11-08 17:13 ` Rob Herring
2021-11-08 19:00 ` Bryan O'Donoghue
2021-11-08 19:22 ` Rob Herring
2021-11-08 19:36 ` Bryan O'Donoghue
2021-11-12 22:25 ` Rob Herring
2021-11-12 23:05 ` Bryan O'Donoghue
2021-11-05 3:35 ` [PATCH v3 6/7] usb: typec: qcom: Remove standalone qcom pm8150b typec driver Bryan O'Donoghue
2021-11-05 14:59 ` Heikki Krogerus
2021-11-05 15:02 ` Heikki Krogerus
2021-11-05 16:05 ` Bryan O'Donoghue [this message]
2021-11-05 19:24 ` Guenter Roeck
2021-11-05 3:35 ` [PATCH v3 7/7] usb: typec: qcom: Add a pm8150b TCPM driver Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=749a058d-a16d-3a92-25b6-97afcfaa7787@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).