From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subhash Jadavani Subject: Re: [PATCH v3 05/12] phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy Date: Tue, 01 Nov 2016 11:42:09 -0700 Message-ID: <74c76068ceee53d779d307a272c502fc@codeaurora.org> References: <1477772534-14170-1-git-send-email-vivek.gautam@codeaurora.org> <1477772534-14170-6-git-send-email-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41062 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcKASmK (ORCPT ); Tue, 1 Nov 2016 14:42:10 -0400 In-Reply-To: <1477772534-14170-6-git-send-email-vivek.gautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vivek Gautam Cc: kishon@ti.com, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com, martin.petersen@oracle.com, sboyd@codeaurora.org, ygardi@codeaurora.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-scsi-owner@vger.kernel.org On 2016-10-29 13:22, Vivek Gautam wrote: > The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy > present on msm8996. So skip obtaining these clocks using > compatible match. > > Signed-off-by: Vivek Gautam > --- > > New patch in v3 of this cleanup series. > Comes in place of the following patch in v2 - > phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent > > drivers/phy/phy-qcom-ufs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c > index a173b30..11c8cae 100644 > --- a/drivers/phy/phy-qcom-ufs.c > +++ b/drivers/phy/phy-qcom-ufs.c > @@ -184,6 +184,10 @@ int ufs_qcom_phy_clk_get(struct device *dev, > { > int err; > > + if (of_device_is_compatible(phy_common->dev->of_node, > + "qcom,msm8996-ufs-phy-qmp-14nm")) Vivek, This change looks good but you might need a minor change if we agree to change the compatible string name ("qcom,msm8996-ufs-phy-qmp-14nm") as commented on patch #4. > + goto skip_txrx_clk; > + > err = ufs_qcom_phy_clk_get(phy_common->dev, "tx_iface_clk", > &phy_common->tx_iface_clk); > if (err) > @@ -199,6 +203,7 @@ int ufs_qcom_phy_clk_get(struct device *dev, > if (err) > goto out; > > +skip_txrx_clk: > /* > * "ref_clk_parent" is optional hence don't abort init if it's not > * found. -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project