From: Joe Perches <joe@perches.com>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
vkoul@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz,
tiwai@suse.com, srinivas.kandagatla@linaro.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org
Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints
Date: Wed, 13 Jul 2022 09:01:16 -0700 [thread overview]
Message-ID: <75404573094d1c46172fcd51dad6a4e564da1542.camel@perches.com> (raw)
In-Reply-To: <8cde58d2-3b10-b88b-2d10-88e76fbcac06@quicinc.com>
On Wed, 2022-07-13 at 20:22 +0530, Srinivasa Rao Mandadapu wrote:
> On 7/13/2022 7:53 PM, Pierre-Louis Bossart wrote:
> Thanks for your time Pierre-Louis!!!
> >
> > On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote:
> > > Upadte error prints to debug prints to avoid redundant logging in kernel
> > update
[]
> > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
[]
> > > @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> > > break;
> > > case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> > > case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> > > - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> > > - __func__);
> > > + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__);
Could also drop the "%s: ", __func__ as it's already a unique message
and dynamic debug could add it back if really desired.
next prev parent reply other threads:[~2022-07-13 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:22 [PATCH] soundwire: qcom: Update error prints to debug prints Srinivasa Rao Mandadapu
2022-07-13 13:56 ` Andrew Halaney
2022-07-13 14:51 ` Srinivasa Rao Mandadapu
2022-07-13 14:23 ` Pierre-Louis Bossart
2022-07-13 14:52 ` Srinivasa Rao Mandadapu
2022-07-13 16:01 ` Joe Perches [this message]
2022-07-13 16:45 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75404573094d1c46172fcd51dad6a4e564da1542.camel@perches.com \
--to=joe@perches.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox