From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B3AC7618E for ; Fri, 21 Apr 2023 18:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232545AbjDUSmP (ORCPT ); Fri, 21 Apr 2023 14:42:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjDUSmO (ORCPT ); Fri, 21 Apr 2023 14:42:14 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B277C1728; Fri, 21 Apr 2023 11:42:13 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33LBYTbb011343; Fri, 21 Apr 2023 18:42:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=D+zxcmfcTVJSf2VwbasakLQRdVH5zKDovEgkZgH543E=; b=ERlKO4epj3mOPBXCw8MB8Sky51a4uvPPcm3BWVV2wsbu5WZsni+ZLwfMgHyDaJNEFjpo 4p42SUaxVhReQY8SL4xUcRzxohnuzRZB90pjw3szw/ZT1a1OceHiH6VNKZW8uffxkC9e 7hdb64+uTuNWt8M1pTAyM/CTuIWM5DUK0e5CtWVcu7szTXspOrllwQ2TC3jFPomPfkU+ FJNrylk1Eeu4kl8AAht1gnG7/U3xjJfk4axcWbWG4mUZ0zquYb+6mq70/Hj8Lnbh2hUR E9gMQhaTvKP+eLsz6nf6GWq2mRI6ucPzc2aKZ6SFKy5CcfT5KY45AUhvs1C6ae2iRXQa ow== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q3phdhc5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Apr 2023 18:42:01 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33LIg0Ps009769 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Apr 2023 18:42:01 GMT Received: from [10.110.74.190] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 21 Apr 2023 11:41:59 -0700 Message-ID: <7579b02e-5b4d-72b7-4cef-e18f9fc86d7d@quicinc.com> Date: Fri, 21 Apr 2023 11:41:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] drm/msm/dp: unregister audio driver during unbind Content-Language: en-US To: Srinivas Kandagatla , , , , , , CC: , , , , , , , , References: <20230421145657.12186-1-srinivas.kandagatla@linaro.org> From: Abhinav Kumar In-Reply-To: <20230421145657.12186-1-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 45iFphmqevtGiCTObiY7FBrdu-TvvRs0 X-Proofpoint-ORIG-GUID: 45iFphmqevtGiCTObiY7FBrdu-TvvRs0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-21_08,2023-04-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 mlxlogscore=775 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304210164 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4/21/2023 7:56 AM, Srinivas Kandagatla wrote: > while binding the code always registers a audio driver, however there > is no corresponding unregistration done in unbind. This leads to multiple > redundant audio platform devices if dp_display_bind and dp_display_unbind > happens multiple times during startup. On X13s platform this resulted in > 6 to 9 audio codec device instead of just 3 codec devices for 3 dp ports. > > Fix this by unregistering codecs on unbind. > > Signed-off-by: Srinivas Kandagatla > --- Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Reviewed-by: Abhinav Kumar (pls ignore the line break in the fixes tag, its a mail editor issue, I will apply the tag properly while applying to -fixes)