From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6A4139D for ; Fri, 12 Apr 2024 00:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880638; cv=none; b=ezj3N41QUUj7QbIFYoXvEjrziNpZul/EQtVANEFntBE8Ze3x2mwBDlNh6kF05y/W8c7xyqb/JnIEa+d3OFXSTXepYw+72t3bElLyGelcFUy3btmT1ERUVheLCS6bJ8ly5oUzaEERUPgvMUmfNyGipO5qKkc2p2y/S5y6DHxSW2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880638; c=relaxed/simple; bh=sQTNnIYHgfKGUn3VmqYNRjZP61Vv3s3ZfEeOIWFjfQo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hY0J46LLsC2gUTRY3F4cMlvjI6y/YYISmypYNYdRNB4oSYrqpA0DvM2B3g93MDHXBSTpXf2YtzFRAmsYIZoZ/SBskk8J+iwyZ66GbSgpZAIdewoKoNdWqH9hg8bifq89EpkpAeYJceDcVjagUOFFnrbUBr46Jwjga/JyxWznsFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=T93DSPFq; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T93DSPFq" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2da08b06e0dso1489301fa.2 for ; Thu, 11 Apr 2024 17:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712880634; x=1713485434; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uWeAeryC+HSBQqc05Jp0Ysdkpvfyotn0oaGu/IDriio=; b=T93DSPFqVQeokljdRYFMUv4jRvcYYhfecIuL5x9BQerhP3wIE1eHaMjVzCfInkz2Uj /Uusvkxu4lNtCNtPDb/yZ6qu+HvPH8lfdZ+44AXIJwk43ZJNYCmy+woij515sE5hOx2c eINbenHHqupvbTR86Y4FbdJ0zbIgM5ltgZ1aLPXMnWjGZj2lEKPZJQ38AWD0YCQKJ4W/ +TnGfvzITFBcLuU9GK73d7c88cflCu6Hr3DKKs6ETrFrpOjPBOKN1LV8u51lYYX7ksUO kww5s+UMiObg07wxW8VOtWdIkTzuHu8g483rPoJQpU1/V/EIMq8t8m+hJ6L2wl0tBxyB Wtrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712880634; x=1713485434; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uWeAeryC+HSBQqc05Jp0Ysdkpvfyotn0oaGu/IDriio=; b=QuHvjs4v2Hs9lyNb6exvZVbA5/WXMWgY9irl6SWhSB9HQoaqu+LNobXsW9PCjo+M2D dtavcnXX1KEtdyxL7Drt/PQGbvfxVXXM6StHr4zYzcYPvVF3+xS+dGeBOu6VmoN6iEkU TcWTsI63U1xv6eRI1N/kaqZbjEl0kb/XLg8gauxt5Y8xqxitjg2KHqP2LiC+Vp/YQMN/ LqJy8jzWSXFL/kbbJV0Yx+XA8hQtk8dChTmRPFj9+ycJ1Nh1ZzJ1AFryrP0rMQ1cD8PC XfTD3+Q3EmBeCVlg95gZ0pY0gLVd7RcZyjAkuU8ScgT4tgi1EUacfD6rdGk+Q7G4DMIC RcFg== X-Forwarded-Encrypted: i=1; AJvYcCXiSpbv4qoe9LY3Bpcp+i08NqCRn054QrbHgoKw5gq33HyDoJCRP9uJ+0o4d7R2nRe7GRuOi5lw6iV80OfIFn+pSpLx5Ba2ra7tuD+DpQ== X-Gm-Message-State: AOJu0Yyn3t2G4enK3QLMwWPDg+342+Y2tt7a1JFAyDnsOvjGFFO0xGEj zpy9iMeWXXKHqnVv3UDkm1r2VVGcDRc8IaVlFsBWBEAcFS9d6puXBh9ldIzAdNc= X-Google-Smtp-Source: AGHT+IFXAtUviYLODojZB8y1DGATalo/JeZWCLCv1nVOL1U9loFS9KRzrRPuGc6MkUfK7tlXBtUy6g== X-Received: by 2002:a05:651c:1543:b0:2d4:6c52:23d5 with SMTP id y3-20020a05651c154300b002d46c5223d5mr620714ljp.50.1712880634395; Thu, 11 Apr 2024 17:10:34 -0700 (PDT) Received: from [172.30.204.35] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id f15-20020a2e6a0f000000b002d868f2939bsm331735ljc.103.2024.04.11.17.10.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 17:10:34 -0700 (PDT) Message-ID: <7634a8ba-e783-46ce-be91-779cd603bd3b@linaro.org> Date: Fri, 12 Apr 2024 02:10:30 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them To: Elliot Berman Cc: Bjorn Andersson , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, Neil Armstrong References: <20240405-topic-smem_speedbin-v1-0-ce2b864251b1@linaro.org> <20240405-topic-smem_speedbin-v1-1-ce2b864251b1@linaro.org> <20240410132510649-0700.eberman@hu-eberman-lv.qualcomm.com> <2c2bca6c-b429-4cef-b63a-ee3bd6c9eecb@linaro.org> <20240411130802689-0700.eberman@hu-eberman-lv.qualcomm.com> <20240411162849104-0700.eberman@hu-eberman-lv.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240411162849104-0700.eberman@hu-eberman-lv.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/12/24 01:49, Elliot Berman wrote: > On Thu, Apr 11, 2024 at 10:24:08PM +0200, Konrad Dybcio wrote: >> >> >> On 4/11/24 22:09, Elliot Berman wrote: >>> On Thu, Apr 11, 2024 at 10:05:30PM +0200, Konrad Dybcio wrote: >>>> >>>> >>>> On 4/11/24 20:55, Elliot Berman wrote: >>>>> On Fri, Apr 05, 2024 at 10:41:29AM +0200, Konrad Dybcio wrote: >>>>>> In preparation for parsing the chip "feature code" (FC) and "product >>>>>> code" (PC) (essentially the parameters that let us conclusively >>>>>> characterize the sillicon we're running on, including various speed >>>>>> bins), move the socinfo version defines to the public header and >>>>>> include some more FC/PC defines. >>>>>> >>>>>> Signed-off-by: Konrad Dybcio >>>>>> --- >> >> [...] >> >>> >>> 0xf is the last one. >> >> One more question, are the "internal/external feature codes" referring to >> internality/externality of the chips (i.e. "are they QC-lab-only engineering >> samples), or what else does that represent? > > Yes, QC-lab-only engineering samples is the right interpretation of > these feature codes. Do you think it would be beneficial to keep the logic for these ESes in the upstream GPU driver? Otherwise, I can yank out half of the added lines. Konrad