From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: Add device tree for Sony Xperia 1 IV
Date: Thu, 14 Jul 2022 13:16:15 +0200 [thread overview]
Message-ID: <763aaaab-ce5e-5fad-51ed-95147c46afd8@linaro.org> (raw)
In-Reply-To: <20220713201047.1449786-4-konrad.dybcio@somainline.org>
On 13/07/2022 22:10, Konrad Dybcio wrote:
> Add support for Sony Xperia 1 IV, a.k.a PDX223. This device is a part
> of the SoMC SM8450 Nagara platform and currently it is the only
> device based on that board, so no -common DTSI is created until (if?)
> other Nagara devices appear.
>
> This commit brings support for:
Thank you for your patch. There is something to discuss/improve.
> + pm8450_s3: smps3 {
> + regulator-name = "pm8450_s3";
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <600000>;
> + };
> +
> + pm8450_l2: ldo2 {
> + regulator-name = "pm8450_l2";
> + regulator-min-microvolt = <880000>;
> + regulator-max-microvolt = <912000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> + pm8450_l3: ldo3 {
> + regulator-name = "pm8450_l3";
> + regulator-min-microvolt = <912000>;
> + regulator-max-microvolt = <912000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
Remove blank line.
> + };
> +
> + pmr735a-rpmh-regulators {
> + compatible = "qcom,pmr735a-rpmh-regulators";
> + qcom,pmic-id = "e";
> +
> + vdd-s1-supply = <&vph_pwr>;
> + vdd-s2-supply = <&vph_pwr>;
> + vdd-s3-supply = <&vph_pwr>;
> +
> + vdd-l1-l2-supply = <&pmr735a_s2>;
> + vdd-l3-supply = <&pmr735a_s1>;
> + vdd-l4-supply = <&pm8350c_s1>;
> + vdd-l5-l6-supply = <&pm8350c_s1>;
> + vdd-l7-bob-supply = <&vreg_bob>;
> +
> + pmr735a_s1: smps1 {
> + regulator-name = "pmr735a_s1";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1296000>;
> + };
> +
> + pmr735a_s2: smps2 {
> + regulator-name = "pmr735a_s2";
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <1040000>;
> + };
> +
> + pmr735a_s3: smps3 {
> + regulator-name = "pmr735a_s3";
> + regulator-min-microvolt = <435000>;
> + regulator-max-microvolt = <2352000>;
> + };
> +
> + pmr735a_l1: ldo1 {
> + regulator-name = "pmr735a_l1";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <800000>;
> + };
> +
> + pmr735a_l2: ldo2 {
> + regulator-name = "pmr735a_l2";
> + regulator-min-microvolt = <480000>;
> + regulator-max-microvolt = <912000>;
> + };
> +
> + pmr735a_l3: ldo3 {
> + regulator-name = "pmr735a_l3";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + };
> +
> + pmr735a_l4: ldo4 {
> + regulator-name = "pmr735a_l4";
> + regulator-min-microvolt = <1776000>;
> + regulator-max-microvolt = <1776000>;
> + };
> +
> + pmr735a_l5: ldo5 {
> + regulator-name = "pmr735a_l5";
> + regulator-min-microvolt = <880000>;
> + regulator-max-microvolt = <880000>;
> + };
> +
> + pmr735a_l6: ldo6 {
> + regulator-name = "pmr735a_l6";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + };
> +
> + pmr735a_l7: ldo7 {
> + regulator-name = "pmr735a_l7";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + };
> + };
> +};
> +
> +&gpi_dma0 {
> + status = "okay";
> +};
> +
> +&gpi_dma1 {
> + status = "okay";
> +};
> +
> +&gpi_dma2 {
> + status = "okay";
> +};
> +
> +/* I2C4 is used, it hosts a Samsung touchscreen, but GPI DMA is broken.. */
> +
> +&i2c5 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* Dialog SLG51000 CMIC @ 75 */
> +};
> +
> +&i2c9 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* NXP SN1X0 NFC @ 28 */
> +};
> +
> +&i2c13 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* Richwave RTC6226 FM Radio Receiver @ 64 */
> +};
> +
> +&i2c14 {
> + clock-frequency = <1000000>;
> + status = "okay";
> +
> + cs35l41_l: cs35l41@40 {
Generic node name is needed.
> + compatible = "cirrus,cs35l41";
> + reg = <0x40>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> + cirrus,boost-peak-milliamp = <4000>;
> + cirrus,boost-ind-nanohenry = <1000>;
> + cirrus,boost-cap-microfarad = <15>;
> + cirrus,gpio2-src-select = <2>;
> + cirrus,gpio2-output-enable;
> + cirrus,asp-sdout-hiz = <3>;
> + #sound-dai-cells = <1>;
> + };
> +
> + cs35l41_r: cs35l41@41 {
Ditto.
> + compatible = "cirrus,cs35l41";
> + reg = <0x41>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> + cirrus,boost-peak-milliamp = <4000>;
> + cirrus,boost-ind-nanohenry = <1000>;
> + cirrus,boost-cap-microfarad = <15>;
> + cirrus,gpio2-src-select = <2>;
> + cirrus,gpio2-output-enable;
> + cirrus,asp-sdout-hiz = <3>;
> + #sound-dai-cells = <1>;
> + };
> +};
> +
> +&i2c15 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* AMS TCS3490 RGB+IR color sensor @ 72 */
> +};
> +
> +&i2c19 {
> + clock-frequency = <1000000>;
> + status = "okay";
> +
> + /* Cirrus Logic CS40L25A boosted haptics driver @ 40 */
> +};
> +
> +&pcie0 {
> + max-link-speed = <2>;
> + status = "okay";
> +};
> +
> +&pcie0_phy {
> + vdda-phy-supply = <&pm8350_l5>;
> + vdda-pll-supply = <&pm8350_l6>;
> + status = "okay";
> +};
> +
> +&remoteproc_adsp {
> + firmware-name = "qcom/adsp.mbn";
> + status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> + firmware-name = "qcom/cdsp.mbn";
> + status = "okay";
> +};
> +
> +&remoteproc_slpi {
> + firmware-name = "qcom/slpi.mbn";
> + status = "okay";
> +};
> +
> +&qupv3_id_0 {
> + status = "okay";
> +};
> +
> +&qupv3_id_1 {
> + status = "okay";
> +};
> +
> +&qupv3_id_2 {
> + status = "okay";
> +};
> +
> +&sdhc_2 {
> + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
> + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
> + vmmc-supply = <&pm8350c_l9>;
> + vqmmc-supply = <&pm8350c_l6>;
> + /* Forbid SDR104/SDR50 - broken hw! */
> + sdhci-caps-mask = <0x3 0x0>;
Wrong indentation.
> + no-sdio;
> + no-mmc;
> + status = "okay";
> +};
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-14 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 20:10 [PATCH 1/4] dt-bindings: arm: qcom: Document Sony Xperia 1 IV (PDX223) Konrad Dybcio
2022-07-13 20:10 ` [PATCH 2/4] arm64: dts: qcom: sm8450: Adjust memory map Konrad Dybcio
2022-07-13 20:10 ` [PATCH 3/4] arm64: dts: qcom: sm8450: Add SDHCI2 Konrad Dybcio
2022-07-14 11:13 ` Krzysztof Kozlowski
2022-07-13 20:10 ` [PATCH 4/4] arm64: dts: qcom: Add device tree for Sony Xperia 1 IV Konrad Dybcio
2022-07-14 11:16 ` Krzysztof Kozlowski [this message]
2022-07-14 11:12 ` [PATCH 1/4] dt-bindings: arm: qcom: Document Sony Xperia 1 IV (PDX223) Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763aaaab-ce5e-5fad-51ed-95147c46afd8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=anton@enomsg.org \
--cc=bjorn.andersson@linaro.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox