From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] clk: qcom: camcc-x1p42100: Add support for camera clock controller
Date: Wed, 28 Jan 2026 11:17:44 +0100 [thread overview]
Message-ID: <76763847-e5f2-484a-9ff6-dab5906bdaaa@oss.qualcomm.com> (raw)
In-Reply-To: <20260128-purwa-videocc-camcc-v1-5-b23de57df5ba@oss.qualcomm.com>
On 1/27/26 8:26 PM, Jagadeesh Kona wrote:
> Add support for the camera clock controller for camera clients to
> be able to request for camcc clocks on X1P42100 platform.
>
> Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
> ---
[...]
> +#include <dt-bindings/clock/qcom,x1e80100-camcc.h>
I have mixed feelings.
Purwa lacks sfe_0, pll7, pll8, ife_1 clocks and all their supporting
infrastructure. All other clocks seem to indeed be common.
Perhaps it's not that bad given it's a strict subset and they have
a shared DT
The driver itself looks OK
So
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-01-28 10:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 19:26 [PATCH 0/8] Add support for videocc and camcc on X1P42100 platform Jagadeesh Kona
2026-01-27 19:26 ` [PATCH 1/8] dt-bindings: clock: qcom: Add X1P42100 video clock controller Jagadeesh Kona
2026-01-27 20:34 ` Dmitry Baryshkov
2026-01-28 10:26 ` Konrad Dybcio
2026-02-04 17:44 ` Jagadeesh Kona
2026-01-28 10:08 ` Konrad Dybcio
2026-02-04 17:48 ` Jagadeesh Kona
2026-01-28 11:43 ` Krzysztof Kozlowski
2026-02-04 17:46 ` Jagadeesh Kona
2026-01-27 19:26 ` [PATCH 2/8] dt-bindings: clock: qcom: Add X1P42100 camera " Jagadeesh Kona
2026-01-28 11:45 ` Krzysztof Kozlowski
2026-01-27 19:26 ` [PATCH 3/8] clk: qcom: videocc-x1p42100: Add support for video " Jagadeesh Kona
2026-01-28 7:21 ` Taniya Das
2026-01-28 8:18 ` Abel Vesa
2026-01-29 0:37 ` Dmitry Baryshkov
2026-02-04 17:46 ` Jagadeesh Kona
2026-02-04 19:42 ` Dmitry Baryshkov
2026-01-27 19:26 ` [PATCH 4/8] clk: qcom: camcc-x1e80100: Add support for camera QDSS debug clocks Jagadeesh Kona
2026-01-27 22:26 ` Bryan O'Donoghue
2026-01-28 10:14 ` Konrad Dybcio
2026-01-29 0:38 ` Dmitry Baryshkov
2026-02-04 17:47 ` Jagadeesh Kona
2026-01-27 19:26 ` [PATCH 5/8] clk: qcom: camcc-x1p42100: Add support for camera clock controller Jagadeesh Kona
2026-01-28 4:45 ` Taniya Das
2026-01-28 10:17 ` Konrad Dybcio [this message]
2026-01-29 0:39 ` Dmitry Baryshkov
2026-02-04 17:47 ` Jagadeesh Kona
2026-01-27 19:26 ` [PATCH 6/8] arm64: dts: qcom: x1e80100: Add CAMCC block definition Jagadeesh Kona
2026-01-28 8:19 ` Abel Vesa
2026-01-27 19:26 ` [PATCH 7/8] arm64: dts: qcom: Update compatible for videocc and camcc nodes on purwa Jagadeesh Kona
2026-01-28 8:24 ` Abel Vesa
2026-01-28 10:19 ` Konrad Dybcio
2026-02-04 17:48 ` Jagadeesh Kona
2026-01-27 19:26 ` [PATCH 8/8] arm64: defconfig: Enable VIDEOCC and CAMCC drivers on Qualcomm X1P42100 Jagadeesh Kona
2026-02-08 11:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76763847-e5f2-484a-9ff6-dab5906bdaaa@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox