Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Manivannan Sadhasivam" <mani@kernel.org>
Cc: hemantk@codeaurora.org, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55
Date: Mon, 17 Jan 2022 16:20:12 +0800 (CST)	[thread overview]
Message-ID: <76f0a70a.2e7f.17e671f4eb0.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20220117075323.GA4209@thinkpad>



At 2022-01-17 15:53:23, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>On Sat, Jan 15, 2022 at 06:39:12PM +0800, Slark Xiao wrote:
>> For default mechanism, product would use default MRU 3500 if
>> they didn't define it. But for Foxconn SDX55, there is a known
>> issue which MRU 3500 would lead to data connection lost.
>> So we align it with Qualcomm default MRU settings.
>> 
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
>Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
>You need to add Fixes tag so that I can queue this patch for v5.17 RCs.
>
>Thanks,
>Mani
>
Hi Mani,
  New patch is committed. Please help do a check again.

Thanks!
>> ---
>>  drivers/bus/mhi/pci_generic.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
>> index 3a258a677df8..74e8fc342cfd 100644
>> --- a/drivers/bus/mhi/pci_generic.c
>> +++ b/drivers/bus/mhi/pci_generic.c
>> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
>>  	.config = &modem_foxconn_sdx55_config,
>>  	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>>  	.dma_data_width = 32,
>> +	.mru_default = 32768,
>>  	.sideband_wake = false,
>>  };
>>  
>> -- 
>> 2.25.1
>> 

      reply	other threads:[~2022-01-17  8:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15 10:39 [PATCH net] bus: mhi: Add mru_default for Foxconn SDX55 Slark Xiao
2022-01-17  7:53 ` Manivannan Sadhasivam
2022-01-17  8:20   ` Slark Xiao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76f0a70a.2e7f.17e671f4eb0.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox